★ wanayoo — archive 1999 https://github.com/nodejs/node/pull/26481Nouvelle recherche | Portail wanayoo
Skip to content

/node

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: edit "Involving the TSC" #26481

Closed
wants to merge 2 commits into
base: master
from

Conversation

Reviewers

@jasnell jasnell

@targos targos

@cjihrig cjihrig

@hiroppy hiroppy

@richardlau richardlau

@BethGriggs BethGriggs

@BridgeAR BridgeAR

Assignees
No one assigned
Labels
author ready doc
Projects
None yet
Milestone
No milestone
9 participants
@Trott @nodejs-github-bot @targos @jasnell @cjihrig @hiroppy @richardlau @BethGriggs @BridgeAR
@Trott
Copy link
Member

Trott commented Mar 6, 2019

Edit the "Involving the TSC" section of the Collaborator Guide to reduce
passive voice, make things concise, etc.

One thing I didn't do here but that I would definitely do if there is consensus: Remove mention of the tsc-review label and just tell people to @-mention the TSC. Sure, notification overload is a problem, but the tsc-review label always gets ignored. It's not even a placebo.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines
@Trott
doc: edit "Involving the TSC" 
Edit the "Involving the TSC" section of the Collaborator Guide to reduce
passive voice, make things concise, etc.
Loading status checks…
d02deda
@nodejs-github-bot

@nodejs-github-bot nodejs-github-bot added the doc label Mar 6, 2019

@richardlau

richardlau approved these changes Mar 6, 2019
View changes

Show resolved Hide resolved COLLABORATOR_GUIDE.md Outdated
@richardlau @Trott
Update COLLABORATOR_GUIDE.md 
Co-Authored-By: Trott <rtrott@gmail.com>
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
89c4056
@Trott

This comment has been minimized.

Sign in to view
Copy link
Member Author

Trott commented Mar 6, 2019 •
edited

Lite CI: https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/2791/ ✅

@Trott Trott added the author ready label Mar 6, 2019

@hiroppy

hiroppy approved these changes Mar 7, 2019
View changes

@targos

This comment has been minimized.

Sign in to view
Copy link
Member

targos commented Mar 7, 2019

Remove mention of the tsc-review label and just tell people to @-mention the TSC.

Yes, please!
@targos

targos approved these changes Mar 7, 2019
View changes

@jasnell

jasnell approved these changes Mar 7, 2019
View changes

@BridgeAR

BridgeAR approved these changes Mar 7, 2019
View changes

@BethGriggs

BethGriggs approved these changes Mar 7, 2019
View changes

@cjihrig

cjihrig approved these changes Mar 7, 2019
View changes

@Trott

This comment has been minimized.

Sign in to view
Copy link
Member Author

Trott commented Mar 8, 2019

Landed in ed465eb

@Trott Trott closed this Mar 8, 2019

Trott added a commit to Trott/io.js that referenced this pull request Mar 8, 2019

@Trott
doc: edit "Involving the TSC" 
Edit the "Involving the TSC" section of the Collaborator Guide to reduce
passive voice, make things concise, etc.

PR-URL: nodejs#26481
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Yuta Hiroto <hello@hiroppy.me>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
ed465eb

BridgeAR added a commit to BridgeAR/node that referenced this pull request Mar 12, 2019

@Trott @BridgeAR
doc: edit "Involving the TSC" 
Edit the "Involving the TSC" section of the Collaborator Guide to reduce
passive voice, make things concise, etc.

PR-URL: nodejs#26481
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Yuta Hiroto <hello@hiroppy.me>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Verified
This commit was signed with a verified signature.
@BridgeAR BridgeAR Ruben Bridgewater
GPG key ID: F07496B3EB3C1762 Learn about signing commits
aa85411

BridgeAR added a commit to BridgeAR/node that referenced this pull request Mar 13, 2019

@Trott @BridgeAR
doc: edit "Involving the TSC" 
Edit the "Involving the TSC" section of the Collaborator Guide to reduce
passive voice, make things concise, etc.

PR-URL: nodejs#26481
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Yuta Hiroto <hello@hiroppy.me>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Verified
This commit was signed with a verified signature.
@BridgeAR BridgeAR Ruben Bridgewater
GPG key ID: F07496B3EB3C1762 Learn about signing commits
cae30d9

@BridgeAR BridgeAR referenced this pull request Mar 13, 2019

Merged

2019-03-14, Version 11.12.0 (Current) #26644

BridgeAR added a commit that referenced this pull request Mar 14, 2019

@Trott @BridgeAR
doc: edit "Involving the TSC" 
Edit the "Involving the TSC" section of the Collaborator Guide to reduce
passive voice, make things concise, etc.

PR-URL: #26481
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Yuta Hiroto <hello@hiroppy.me>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Verified
This commit was signed with a verified signature.
@BridgeAR BridgeAR Ruben Bridgewater
GPG key ID: F07496B3EB3C1762 Learn about signing commits
5897bf4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.