★ wanayoo — archive 1999 https://github.com/nodejs/node/pull/26432Nouvelle recherche | Portail wanayoo
Skip to content

/node

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

buffer: do not affect memory after target for utf16 write #26432

Closed
wants to merge 1 commit into
base: master
from

Conversation

Reviewers

@JungMinu JungMinu

@richardlau richardlau

@BridgeAR BridgeAR

Assignees
No one assigned
Labels
C++ author ready buffer lts-watch-v10.x lts-watch-v8.x
Projects
None yet
Milestone
No milestone
6 participants
@addaleax @nodejs-github-bot @antsmartian @BridgeAR @JungMinu @richardlau
@addaleax
Copy link
Member

addaleax commented Mar 4, 2019

Do not write one character too much before shifting the whole result
to the left when using UTF16-LE, possibly overwriting already-used
memory while doing so.

Fixes: #26422

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
@addaleax
buffer: do not affect memory after target for utf16 write 
Do not write one character too much before shifting the whole result
to the left when using UTF16-LE, possibly overwriting already-used
memory while doing so.

Fixes: #26422
Verified
This commit was signed with a verified signature.
@addaleax addaleax Anna Henningsen
GPG key ID: 9C63F3A6CD2AD8F9 Learn about signing commits
Loading status checks…
8278fbe

@addaleax addaleax added buffer lts-watch-v8.x lts-watch-v10.x labels Mar 4, 2019

@nodejs-github-bot

@nodejs-github-bot nodejs-github-bot added the C++ label Mar 4, 2019

@addaleax addaleax referenced this pull request Mar 4, 2019

Closed

buffer.write incorrectly written one more byte in utf16le encoding #26422

@richardlau

richardlau approved these changes Mar 4, 2019
View changes

@antsmartian

This comment has been minimized.

Sign in to view
Copy link
Contributor

antsmartian commented Mar 4, 2019 •
edited by addaleax

CI: https://ci.nodejs.org/job/node-test-pull-request/21191/ (✔️)
@BridgeAR

BridgeAR approved these changes Mar 4, 2019
View changes

@BridgeAR BridgeAR added the author ready label Mar 5, 2019

@JungMinu

JungMinu approved these changes Mar 5, 2019
View changes

@BridgeAR

This comment has been minimized.

Sign in to view
Copy link
Member

BridgeAR commented Mar 6, 2019

Landed in 31147c4 🎉

@BridgeAR BridgeAR closed this Mar 6, 2019

BridgeAR added a commit to BridgeAR/node that referenced this pull request Mar 6, 2019

@addaleax @BridgeAR
buffer: do not affect memory after target for utf16 write 
Do not write one character too much before shifting the whole result
to the left when using UTF16-LE, possibly overwriting already-used
memory while doing so.

Fixes: nodejs#26422

PR-URL: nodejs#26432
Fixes: nodejs#26422
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Minwoo Jung <minwoo@nodesource.com>
Verified
This commit was signed with a verified signature.
@BridgeAR BridgeAR Ruben Bridgewater
GPG key ID: F07496B3EB3C1762 Learn about signing commits
31147c4

BridgeAR added a commit to BridgeAR/node that referenced this pull request Mar 12, 2019

@addaleax @BridgeAR
buffer: do not affect memory after target for utf16 write 
Do not write one character too much before shifting the whole result
to the left when using UTF16-LE, possibly overwriting already-used
memory while doing so.

Fixes: nodejs#26422

PR-URL: nodejs#26432
Fixes: nodejs#26422
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Minwoo Jung <minwoo@nodesource.com>
Verified
This commit was signed with a verified signature.
@BridgeAR BridgeAR Ruben Bridgewater
GPG key ID: F07496B3EB3C1762 Learn about signing commits
7d8edec

@BridgeAR BridgeAR referenced this pull request Mar 13, 2019

Merged

2019-03-14, Version 11.12.0 (Current) #26644

BridgeAR added a commit that referenced this pull request Mar 14, 2019

@addaleax @BridgeAR
buffer: do not affect memory after target for utf16 write 
Do not write one character too much before shifting the whole result
to the left when using UTF16-LE, possibly overwriting already-used
memory while doing so.

Fixes: #26422

PR-URL: #26432
Fixes: #26422
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Minwoo Jung <minwoo@nodesource.com>
Verified
This commit was signed with a verified signature.
@BridgeAR BridgeAR Ruben Bridgewater
GPG key ID: F07496B3EB3C1762 Learn about signing commits
68bb1e9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.