★ wanayoo — archive 1999 https://github.com/nodejs/node/pull/26426Nouvelle recherche | Portail wanayoo
Skip to content

/node

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

src: remove redundant cast in string_search.h #26426

Closed
wants to merge 1 commit into
base: master
from

Conversation

Reviewers

@jasnell jasnell

@addaleax addaleax

@cjihrig cjihrig

@richardlau richardlau

@BridgeAR BridgeAR

Assignees
No one assigned
Labels
C++ author ready buffer
Projects
None yet
Milestone
No milestone
7 participants
@gengjiawen @BridgeAR @jasnell @addaleax @cjihrig @richardlau @nodejs-github-bot
@gengjiawen
Copy link
Contributor

gengjiawen commented Mar 4, 2019

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added buffer C++ labels Mar 4, 2019

@richardlau

richardlau approved these changes Mar 4, 2019
View changes

@addaleax

addaleax approved these changes Mar 4, 2019
View changes

@cjihrig

cjihrig approved these changes Mar 4, 2019
View changes

@BridgeAR

This comment has been minimized.

Sign in to view
Copy link
Member

BridgeAR commented Mar 5, 2019

@gengjiawen I really like that you clean up a lot of code at the moment! As a personal request though: would you be so kind and combine a couple of these in a single PR if they feel somewhat related (e.g., removing a couple of redundant casts)? And it is still good to have small PRs, just maybe not as small. That reduces the overhead that we currently have to review and land the PRs :-)

CI https://ci.nodejs.org/job/node-test-pull-request/21205/

@BridgeAR BridgeAR added the author ready label Mar 5, 2019

@gengjiawen

This comment has been minimized.

Sign in to view
Copy link
Contributor Author

gengjiawen commented Mar 5, 2019

@gengjiawen I really like that you clean up a lot of code at the moment! As a personal request though: would you be so kind and combine a couple of these in a single PR if they feel somewhat related (e.g., removing a couple of redundant casts)? And it is still good to have small PRs, just maybe not as small. That reduces the overhead that we currently have to review and land the PRs :-)

@BridgeAR I will try to do it if prs are small next time. But I find it difficulty when some middle commit need to fix. How do you guys manage that? In my current workflow, I just need to switch that branch, fix it and amend the commit.
@jasnell

jasnell approved these changes Mar 5, 2019
View changes

@BridgeAR

BridgeAR approved these changes Mar 6, 2019
View changes

@BridgeAR

This comment has been minimized.

Sign in to view
Copy link
Member

BridgeAR commented Mar 6, 2019

Landed in 95e3119 🎉

@BridgeAR BridgeAR closed this Mar 6, 2019

BridgeAR added a commit to BridgeAR/node that referenced this pull request Mar 6, 2019

@gengjiawen @BridgeAR
src: remove redundant cast in string_search.h 
PR-URL: nodejs#26426
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Verified
This commit was signed with a verified signature.
@BridgeAR BridgeAR Ruben Bridgewater
GPG key ID: F07496B3EB3C1762 Learn about signing commits
95e3119

BridgeAR added a commit to BridgeAR/node that referenced this pull request Mar 12, 2019

@gengjiawen @BridgeAR
src: remove redundant cast in string_search.h 
PR-URL: nodejs#26426
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Verified
This commit was signed with a verified signature.
@BridgeAR BridgeAR Ruben Bridgewater
GPG key ID: F07496B3EB3C1762 Learn about signing commits
4ff5cfa

@BridgeAR BridgeAR referenced this pull request Mar 13, 2019

Merged

2019-03-14, Version 11.12.0 (Current) #26644

BridgeAR added a commit that referenced this pull request Mar 14, 2019

@gengjiawen @BridgeAR
src: remove redundant cast in string_search.h 
PR-URL: #26426
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Verified
This commit was signed with a verified signature.
@BridgeAR BridgeAR Ruben Bridgewater
GPG key ID: F07496B3EB3C1762 Learn about signing commits
81c5382
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.