★ wanayoo — archive 1999 https://github.com/nodejs/node/pull/26410Nouvelle recherche | Portail wanayoo
Skip to content

/node

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

src: remove redundant cast in util-inl.h #26410

Closed
wants to merge 1 commit into
base: master
from

Conversation

Reviewers

@danbev danbev

@jasnell jasnell

@bnoordhuis bnoordhuis

@addaleax addaleax

@cjihrig cjihrig

@joyeecheung joyeecheung

Assignees
No one assigned
Labels
C++ author ready
Projects
None yet
Milestone
No milestone
5 participants
@gengjiawen @BridgeAR @danbev @jasnell @nodejs-github-bot
@gengjiawen
Copy link
Contributor

gengjiawen commented Mar 3, 2019

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the C++ label Mar 3, 2019

@gengjiawen gengjiawen force-pushed the gengjiawen:redundant_cast_util_h branch from 2ef571a to 7e0d71e Mar 3, 2019

@jasnell

jasnell approved these changes Mar 3, 2019
View changes

@BridgeAR

This comment has been minimized.

Sign in to view
Copy link
Member

BridgeAR commented Mar 5, 2019

CI https://ci.nodejs.org/job/node-test-pull-request/21207/

@BridgeAR BridgeAR added the author ready label Mar 5, 2019

@BridgeAR BridgeAR requested review from addaleax , joyeecheung , cjihrig and bnoordhuis Mar 5, 2019

@danbev

danbev approved these changes Mar 8, 2019
View changes

@danbev

This comment has been minimized.

Sign in to view
Copy link
Member

danbev commented Mar 8, 2019

Landed in 6de8801.

@danbev danbev closed this Mar 8, 2019

danbev added a commit that referenced this pull request Mar 8, 2019

@gengjiawen @danbev
src: remove redundant cast in util-inl.h 
PR-URL: #26410
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Loading status checks…
6de8801

@gengjiawen gengjiawen deleted the gengjiawen:redundant_cast_util_h branch Mar 8, 2019

BridgeAR added a commit to BridgeAR/node that referenced this pull request Mar 12, 2019

@gengjiawen @BridgeAR
src: remove redundant cast in util-inl.h 
PR-URL: nodejs#26410
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Verified
This commit was signed with a verified signature.
@BridgeAR BridgeAR Ruben Bridgewater
GPG key ID: F07496B3EB3C1762 Learn about signing commits
8439e07

@BridgeAR BridgeAR referenced this pull request Mar 13, 2019

Merged

2019-03-14, Version 11.12.0 (Current) #26644

BridgeAR added a commit that referenced this pull request Mar 14, 2019

@gengjiawen @BridgeAR
src: remove redundant cast in util-inl.h 
PR-URL: #26410
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Verified
This commit was signed with a verified signature.
@BridgeAR BridgeAR Ruben Bridgewater
GPG key ID: F07496B3EB3C1762 Learn about signing commits
203fa63
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.