★ wanayoo — archive 1999 https://github.com/nodejs/node/pull/26407Nouvelle recherche | Portail wanayoo
Skip to content

/node

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

http: remove unused variable in _http_server.js #26407

Closed
wants to merge 1 commit into
base: master
from

Conversation

Reviewers

@jasnell jasnell

@lpinca lpinca

@tniessen tniessen

@BridgeAR BridgeAR

Assignees
No one assigned
Labels
author ready http
Projects
None yet
Milestone
No milestone
7 participants
@gengjiawen @lpinca @BridgeAR @danbev @jasnell @tniessen @nodejs-github-bot
@gengjiawen
Copy link
Contributor

gengjiawen commented Mar 3, 2019 •
edited by lpinca

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the http label Mar 3, 2019

@lpinca

lpinca approved these changes Mar 3, 2019
View changes

@lpinca

This comment has been minimized.

Sign in to view
Copy link
Member

lpinca commented Mar 3, 2019

CI: https://ci.nodejs.org/job/node-test-pull-request/21153/
@lpinca

This comment has been minimized.

Sign in to view
Copy link
Member

lpinca commented Mar 3, 2019

Subsystem in commit message should be http:

@gengjiawen gengjiawen changed the title lib: remove unused variable in _http_server.js http: remove unused variable in _http_server.js Mar 3, 2019

@gengjiawen gengjiawen force-pushed the gengjiawen:cleanup_http_server branch from 1921896 to 74e4711 Mar 3, 2019

@gengjiawen

This comment has been minimized.

Sign in to view
Copy link
Contributor Author

gengjiawen commented Mar 3, 2019

@lpinca Fixed :)
@lpinca

This comment has been minimized.

Sign in to view
Copy link
Member

lpinca commented Mar 3, 2019

Resume CI: https://ci.nodejs.org/job/node-test-pull-request/21156/
@BridgeAR

BridgeAR approved these changes Mar 3, 2019
View changes

@BridgeAR BridgeAR added the author ready label Mar 3, 2019

@tniessen

tniessen approved these changes Mar 4, 2019
View changes

@jasnell

jasnell approved these changes Mar 4, 2019
View changes

@BridgeAR

This comment has been minimized.

Sign in to view
Copy link
Member

BridgeAR commented Mar 5, 2019

Resumed CI https://ci.nodejs.org/job/node-test-pull-request/21235/
@BridgeAR

This comment has been minimized.

Sign in to view
Copy link
Member

BridgeAR commented Mar 6, 2019

Resumed CI https://ci.nodejs.org/job/node-test-pull-request/21285/
@danbev

This comment has been minimized.

Sign in to view
Copy link
Member

danbev commented Mar 7, 2019

Re-run of failing node-test-commit-arm-fanned (✔️)
@danbev

This comment has been minimized.

Sign in to view
Copy link
Member

danbev commented Mar 7, 2019

Landed in 0fa1165.

@danbev danbev closed this Mar 7, 2019

danbev added a commit that referenced this pull request Mar 7, 2019

@gengjiawen @danbev
http: remove unused variable in _http_server.js 
PR-URL: #26407
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
Loading status checks…
0fa1165

BridgeAR added a commit to BridgeAR/node that referenced this pull request Mar 12, 2019

@gengjiawen @BridgeAR
http: remove unused variable in _http_server.js 
PR-URL: nodejs#26407
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
Verified
This commit was signed with a verified signature.
@BridgeAR BridgeAR Ruben Bridgewater
GPG key ID: F07496B3EB3C1762 Learn about signing commits
5d2c522

@BridgeAR BridgeAR referenced this pull request Mar 13, 2019

Merged

2019-03-14, Version 11.12.0 (Current) #26644

BridgeAR added a commit that referenced this pull request Mar 14, 2019

@gengjiawen @BridgeAR
http: remove unused variable in _http_server.js 
PR-URL: #26407
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
Verified
This commit was signed with a verified signature.
@BridgeAR BridgeAR Ruben Bridgewater
GPG key ID: F07496B3EB3C1762 Learn about signing commits
c661d8c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.