★ wanayoo — archive 1999 https://github.com/nodejs/node/pull/26403Nouvelle recherche | Portail wanayoo
Skip to content

/node

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: remove flaky designation for test_threadsafe_function #26403

Closed
wants to merge 1 commit into
base: master
from

Conversation

Reviewers

@jasnell jasnell

@addaleax addaleax

@benjamingr benjamingr

@cjihrig cjihrig

@richardlau richardlau

@BridgeAR BridgeAR

Assignees
No one assigned
Labels
author ready n-api test
Projects
None yet
Milestone
No milestone
8 participants
@Trott @nodejs-github-bot @jasnell @addaleax @benjamingr @cjihrig @richardlau @BridgeAR
@Trott
Copy link
Member

Trott commented Mar 2, 2019

The test_threadsafe_function doesn't seem to be flaky anymore on
Windows. Optimistically removing the flaky designation in the relevant
status file.

Refs: #23621 (comment)

Will close #23621 before landing this.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
@Trott
test: remove flaky designation for test_threadsafe_function 
The test_threadsafe_function doesn't seem to be flaky anymore on
Windows. Optimistically removing the flaky designation in the relevant
status file.

Refs: #23621 (comment)
Loading status checks…
2404e41
@nodejs-github-bot

@nodejs-github-bot nodejs-github-bot added the test label Mar 2, 2019

@benjamingr

benjamingr approved these changes Mar 2, 2019
View changes

@richardlau

richardlau approved these changes Mar 2, 2019
View changes

@addaleax

addaleax approved these changes Mar 2, 2019
View changes

@addaleax addaleax added the n-api label Mar 2, 2019

@cjihrig

cjihrig approved these changes Mar 2, 2019
View changes

@Trott

This comment has been minimized.

Sign in to view
Copy link
Member Author

Trott commented Mar 2, 2019

CI: https://ci.nodejs.org/job/node-test-pull-request/21145/

@Trott Trott added the author ready label Mar 2, 2019

@jasnell

jasnell approved these changes Mar 2, 2019
View changes

@Trott

This comment has been minimized.

Sign in to view
Copy link
Member Author

Trott commented Mar 3, 2019

CI: https://ci.nodejs.org/job/node-test-pull-request/21149/ ✅
@BridgeAR

BridgeAR approved these changes Mar 3, 2019
View changes

@Trott

This comment has been minimized.

Sign in to view
Copy link
Member Author

Trott commented Mar 4, 2019

Landed in 33880d7

@Trott Trott closed this Mar 4, 2019

Trott added a commit to Trott/io.js that referenced this pull request Mar 4, 2019

@Trott
test: remove flaky designation for test_threadsafe_function 
The test_threadsafe_function doesn't seem to be flaky anymore on
Windows. Optimistically removing the flaky designation in the relevant
status file.

Refs: nodejs#23621 (comment)

PR-URL: nodejs#26403
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
33880d7

BridgeAR added a commit to BridgeAR/node that referenced this pull request Mar 12, 2019

@Trott @BridgeAR
test: remove flaky designation for test_threadsafe_function 
The test_threadsafe_function doesn't seem to be flaky anymore on
Windows. Optimistically removing the flaky designation in the relevant
status file.

Refs: nodejs#23621 (comment)

PR-URL: nodejs#26403
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Verified
This commit was signed with a verified signature.
@BridgeAR BridgeAR Ruben Bridgewater
GPG key ID: F07496B3EB3C1762 Learn about signing commits
e1aa510

@BridgeAR BridgeAR referenced this pull request Mar 13, 2019

Merged

2019-03-14, Version 11.12.0 (Current) #26644

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.