Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upbenchmark,lib: add process.hrtime.bigint benchmark #26381
Conversation
This comment has been minimized.
This comment has been minimized.
nodejs-github-bot
added
the
process
label
Mar 1, 2019
jasnell
approved these changes
Mar 1, 2019
lpinca
approved these changes
Mar 1, 2019
cjihrig
approved these changes
Mar 3, 2019
BridgeAR
approved these changes
Mar 3, 2019
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
Landed in 69906fb |
addaleax
closed this
Mar 5, 2019
addaleax
deleted the
addaleax:hrtime-bigint-benchmark
branch
Mar 5, 2019
added a commit
that referenced
this pull request
Mar 5, 2019
added a commit
to BridgeAR/node
that referenced
this pull request
Mar 12, 2019
BridgeAR
referenced this pull request
Mar 13, 2019
Merged
2019-03-14, Version 11.12.0 (Current) #26644
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
addaleax commentedMar 1, 2019
Add a benchmark, and amend the relevant source code comment to state
that currently, switching to directly returning a BigInt is not
stopped by technical obstacles but rather the fact that using a typed
array is actually a bit faster (about 2.5 %, measured locally).
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes