★ wanayoo — archive 1999 https://github.com/nodejs/node/pull/26370Nouvelle recherche | Portail wanayoo
Skip to content

/node

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tools: remove unneeded .gitignore entries #26370

Closed
wants to merge 1 commit into from

Conversation

@Trott
Copy link
Member

commented Mar 1, 2019

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
@nodejs-github-bot

This comment has been minimized.

Sign in to view
Copy link

commented Mar 1, 2019

@Trott build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/2724/pipeline

@nodejs-github-bot nodejs-github-bot added the meta label Mar 1, 2019

@refack
refack approved these changes Mar 1, 2019
View changes
@cjihrig
cjihrig approved these changes Mar 1, 2019
View changes
.gitignore
icu_config.gypi
.eslintcache

This comment has been minimized.

Sign in to view
Copy link
@cjihrig

cjihrig Mar 1, 2019

Contributor

What is the reasoning for removing this one? I wouldn't expect everyone to have this in their own .gitignore.

This comment has been minimized.

Sign in to view
Copy link
@refack

refack Mar 1, 2019

Member

IIUC they are all covered by

node/.gitignore

Line 2 in c45a9da

.*

This comment has been minimized.

Sign in to view
Copy link
@richardlau

richardlau Mar 1, 2019

Member

IIUC they are all covered by

node/.gitignore

Line 2 in c45a9da
.*

It would be nice if that was included in the commit message for anyone glancing through the commit history.

This comment has been minimized.

Sign in to view
Copy link
@Trott

Trott Mar 1, 2019

Author Member

It would be nice if that was included in the commit message for anyone glancing through the commit history.

@richardlau I've updated the commit message to say:

Remove entries from `.gitignore` that are already covered by the generic
`.*` entry on line 2 of the .gitignore file.
@richardlau
richardlau approved these changes Mar 1, 2019
View changes
.gitignore
icu_config.gypi
.eslintcache

This comment has been minimized.

Sign in to view
Copy link
@richardlau

richardlau Mar 1, 2019

Member

IIUC they are all covered by

node/.gitignore

Line 2 in c45a9da
.*

It would be nice if that was included in the commit message for anyone glancing through the commit history.

@Trott Trott force-pushed the Trott:eslintcache branch from c45a9da to b9f1338 Mar 1, 2019

@Trott
tools: remove unneeded .gitignore entries 
Remove entries from `.gitignore` that are already covered by the generic
`.*` entry on line 2 of the .gitignore file.
Loading status checks…
b9f1338
@jasnell
jasnell approved these changes Mar 1, 2019
View changes
@Trott

This comment has been minimized.

Sign in to view
Copy link
Member Author

commented Mar 2, 2019

Lite CI: https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/2738/

@Trott Trott added the author ready label Mar 2, 2019

@Trott

This comment has been minimized.

Sign in to view
Copy link
Member Author

commented Mar 3, 2019

Landed in b97cd9b

@Trott Trott closed this Mar 3, 2019

Trott added a commit to Trott/io.js that referenced this pull request Mar 3, 2019
@Trott
tools: remove unneeded .gitignore entries 
Remove entries from `.gitignore` that are already covered by the generic
`.*` entry on line 2 of the .gitignore file.

PR-URL: nodejs#26370
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
b97cd9b
BridgeAR added a commit that referenced this pull request Mar 4, 2019
@Trott @BridgeAR
tools: remove unneeded .gitignore entries 
Remove entries from `.gitignore` that are already covered by the generic
`.*` entry on line 2 of the .gitignore file.

PR-URL: #26370
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Verified
This commit was signed with a verified signature.
BridgeAR Ruben Bridgewater
GPG key ID: F07496B3EB3C1762 Learn about signing commits
6e9a7e1
@BridgeAR BridgeAR referenced this pull request Mar 4, 2019
Merged
BethGriggs added a commit that referenced this pull request Apr 16, 2019
@Trott @BethGriggs
tools: remove unneeded .gitignore entries 
Remove entries from `.gitignore` that are already covered by the generic
`.*` entry on line 2 of the .gitignore file.

PR-URL: #26370
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Verified
This commit was signed with a verified signature.
BethGriggs Bethany Nicolle Griggs
GPG key ID: D7062848A1AB005C Learn about signing commits
d4a8769
@BethGriggs BethGriggs referenced this pull request May 1, 2019
Merged
This was referenced May 29, 2019
Closed
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@refack refack

@jasnell jasnell

@cjihrig cjihrig

@richardlau richardlau

Assignees
No one assigned
Labels
author ready meta
Projects
None yet
Milestone
No milestone
6 participants
@Trott @nodejs-github-bot @refack @jasnell @cjihrig @richardlau
You can’t perform that action at this time.