★ wanayoo — archive 1999 https://github.com/nodejs/node/pull/26070Nouvelle recherche | Portail wanayoo
Skip to content

/node

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

src: extract common sockaddr creation code #26070

Closed
wants to merge 4 commits into from

Conversation

Reviewers

@jasnell jasnell

@addaleax addaleax

@richardlau richardlau

Assignees
No one assigned
Labels
C++ author ready dgram
Projects
None yet
Milestone
No milestone
6 participants
@danbev @nodejs-github-bot @addaleax @antsmartian @jasnell @richardlau
@danbev
Copy link
Member

commented Feb 13, 2019

This commit extracts code to create sockaddr which is shared by both
UDPWrap::DoBind and UDPWrap::DoSend.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
@danbev
src: extract common sockaddr creation code 
This commit extracts code to create sockaddr which is shared by both
UDPWrap::DoBind and UDPWrap::DoSend.
Loading status checks…
db1028c
@nodejs-github-bot

@nodejs-github-bot nodejs-github-bot added C++ dgram labels Feb 13, 2019

@danbev

This comment has been minimized.

Sign in to view
Copy link
Member Author

commented Feb 13, 2019

CI: https://ci.nodejs.org/job/node-test-pull-request/20758/

@danbev danbev added the work in progress (WIP) label Feb 13, 2019

@addaleax

addaleax reviewed Feb 13, 2019
View changes

Show resolved Hide resolved src/udp_wrap.cc Outdated
@danbev
squash!: use sockaddr_storage
Loading status checks…
4b16404
@danbev

This comment has been minimized.

Sign in to view
Copy link
Member Author

commented Feb 13, 2019

Updated CI: https://ci.nodejs.org/job/node-test-pull-request/20759/
@addaleax

addaleax approved these changes Feb 13, 2019
View changes

Show resolved Hide resolved src/udp_wrap.cc Outdated

@danbev danbev removed the work in progress (WIP) label Feb 14, 2019

@jasnell

jasnell approved these changes Feb 14, 2019
View changes

@richardlau

richardlau reviewed Feb 14, 2019
View changes

Show resolved Hide resolved src/udp_wrap.cc Outdated
@danbev
squash!: remove uv_ prefix
Loading status checks…
b297df1
@richardlau

richardlau approved these changes Feb 15, 2019
View changes

@addaleax

This comment has been minimized.

Sign in to view
Copy link
Member

commented Feb 15, 2019

CI: https://ci.nodejs.org/job/node-test-pull-request/20806/

@addaleax addaleax added the author ready label Feb 15, 2019

@antsmartian

This comment has been minimized.

Sign in to view
Copy link
Contributor

commented Feb 17, 2019

Resume CI: https://ci.nodejs.org/job/node-test-pull-request/20826/
@addaleax

This comment has been minimized.

Sign in to view
Copy link
Member

commented Feb 17, 2019

Landed in 05292cb

@addaleax addaleax closed this Feb 17, 2019

addaleax added a commit that referenced this pull request Feb 17, 2019

@danbev @addaleax
src: extract common sockaddr creation code 
This commit extracts code to create sockaddr which is shared by both
UDPWrap::DoBind and UDPWrap::DoSend.

PR-URL: #26070
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Verified
This commit was signed with a verified signature.
@addaleax addaleax Anna Henningsen
GPG key ID: 9C63F3A6CD2AD8F9 Learn about signing commits
Loading status checks…
05292cb

addaleax added a commit that referenced this pull request Feb 17, 2019

@danbev @addaleax
src: extract common sockaddr creation code 
This commit extracts code to create sockaddr which is shared by both
UDPWrap::DoBind and UDPWrap::DoSend.

PR-URL: #26070
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Verified
This commit was signed with a verified signature.
@addaleax addaleax Anna Henningsen
GPG key ID: 9C63F3A6CD2AD8F9 Learn about signing commits
e13ce0f

@danbev danbev deleted the danbev:udp_sockaddr branch Feb 25, 2019

@BridgeAR BridgeAR referenced this pull request Feb 26, 2019

Merged

v11.11.0 proposal #26322

rvagg added a commit that referenced this pull request Feb 28, 2019

@danbev @rvagg
src: extract common sockaddr creation code 
This commit extracts code to create sockaddr which is shared by both
UDPWrap::DoBind and UDPWrap::DoSend.

PR-URL: #26070
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
f44f335
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.