★ wanayoo — archive 1999 https://github.com/nodejs/node/pull/26031Nouvelle recherche | Portail wanayoo
Skip to content

/node

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: use emitter.listenerCount() in test-http-connect #26031

Closed
wants to merge 1 commit into from

Conversation

Reviewers

@danbev danbev

@jasnell jasnell

@addaleax addaleax

Assignees
No one assigned
Labels
test
Projects
None yet
Milestone
No milestone
5 participants
@lpinca @nodejs-github-bot @danbev @addaleax @jasnell
@lpinca
Copy link
Member

commented Feb 10, 2019

Use emitter.listenerCount() instead of the length property of the
array returned by emitter.listeners().

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
@lpinca
test: use emitter.listenerCount() in test-http-connect 
Use `emitter.listenerCount()` instead of the `length` property of the
array returned by `emitter.listeners()`.
Loading status checks…
e9128b9
@nodejs-github-bot

@nodejs-github-bot nodejs-github-bot added the test label Feb 10, 2019

@lpinca

This comment has been minimized.

Sign in to view
Copy link
Member Author

commented Feb 10, 2019 •
edited

I understand this has very little value but using ee.listeners('foo').length when ee.listenerCount('foo') exists, triggers my OCD.

It's ok if this is not accepted.
@jasnell

jasnell approved these changes Feb 11, 2019
View changes

@danbev

danbev approved these changes Feb 13, 2019
View changes

@danbev

This comment has been minimized.

Sign in to view
Copy link
Member

commented Feb 13, 2019

CI: https://ci.nodejs.org/job/node-test-pull-request/20752/
@addaleax

addaleax approved these changes Feb 13, 2019
View changes

@addaleax

This comment has been minimized.

Sign in to view
Copy link
Member

commented Feb 13, 2019

Landed in 2b090c1

@addaleax addaleax closed this Feb 13, 2019

addaleax added a commit that referenced this pull request Feb 13, 2019

@lpinca @addaleax
test: use emitter.listenerCount() in test-http-connect 
Use `emitter.listenerCount()` instead of the `length` property of the
array returned by `emitter.listeners()`.

PR-URL: #26031
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Verified
This commit was signed with a verified signature.
@addaleax addaleax Anna Henningsen
GPG key ID: 9C63F3A6CD2AD8F9 Learn about signing commits
Loading status checks…
2b090c1

@lpinca lpinca deleted the lpinca:fix/ocd branch Feb 14, 2019

targos added a commit that referenced this pull request Feb 14, 2019

@lpinca @targos
test: use emitter.listenerCount() in test-http-connect 
Use `emitter.listenerCount()` instead of the `length` property of the
array returned by `emitter.listeners()`.

PR-URL: #26031
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Verified
This commit was signed with a verified signature.
@targos targos Michaël Zasso
GPG key ID: 770F7A9A5AE15600 Learn about signing commits
64cc234

@targos targos referenced this pull request Feb 14, 2019

Merged

v11.10.0 proposal #26098

This was referenced Feb 15, 2019

Closed
Closed
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.