★ wanayoo — archive 1999 https://github.com/nodejs/node/pull/26017Nouvelle recherche | Portail wanayoo
Skip to content

/node

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

worker: keep stdio after exit #26017

Closed
wants to merge 1 commit into from

Conversation

Reviewers

@benjamingr benjamingr

@lpinca lpinca

@cjihrig cjihrig

Assignees
No one assigned
Labels
author ready worker
Projects
None yet
Milestone
No milestone
5 participants
@addaleax @nodejs-github-bot @benjamingr @lpinca @cjihrig
@addaleax
Copy link
Member

commented Feb 9, 2019 •
edited

This addresses review comments from #25871.

Refs: #25871

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
@addaleax
worker: keep stdio after exit 
This addresses review comments from
#25871.

Refs: #25871
Verified
This commit was signed with a verified signature.
@addaleax addaleax Anna Henningsen
GPG key ID: 9C63F3A6CD2AD8F9 Learn about signing commits
Loading status checks…
ac84d44
@nodejs-github-bot

@nodejs-github-bot nodejs-github-bot added the worker label Feb 9, 2019

@addaleax addaleax referenced this pull request Feb 9, 2019

Closed

worker: do not throw on property access or postMessage after termination #25871

@addaleax

This comment has been minimized.

Sign in to view
Copy link
Member Author

commented Feb 9, 2019

/cc @nodejs/workers @sam-github

CI: https://ci.nodejs.org/job/node-test-pull-request/20692/
@lpinca

lpinca approved these changes Feb 9, 2019
View changes

@benjamingr

benjamingr approved these changes Feb 9, 2019
View changes

@addaleax addaleax added the author ready label Feb 9, 2019

@cjihrig

cjihrig approved these changes Feb 11, 2019
View changes

@addaleax

This comment has been minimized.

Sign in to view
Copy link
Member Author

commented Feb 11, 2019

Resume CI: https://ci.nodejs.org/job/node-test-pull-request/20734/
@addaleax

This comment has been minimized.

Sign in to view
Copy link
Member Author

commented Feb 12, 2019

Landed in 9e84a26

@addaleax addaleax closed this Feb 12, 2019

@addaleax addaleax deleted the addaleax:worker-stdio-keep branch Feb 12, 2019

addaleax added a commit that referenced this pull request Feb 12, 2019

@addaleax
worker: keep stdio after exit 
This addresses review comments from
#25871.

Refs: #25871

PR-URL: #26017
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Verified
This commit was signed with a verified signature.
@addaleax addaleax Anna Henningsen
GPG key ID: 9C63F3A6CD2AD8F9 Learn about signing commits
Loading status checks…
9e84a26

addaleax added a commit that referenced this pull request Feb 13, 2019

@addaleax
worker: keep stdio after exit 
This addresses review comments from
#25871.

Refs: #25871

PR-URL: #26017
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Verified
This commit was signed with a verified signature.
@addaleax addaleax Anna Henningsen
GPG key ID: 9C63F3A6CD2AD8F9 Learn about signing commits
23868ba

@targos targos referenced this pull request Feb 14, 2019

Merged

v11.10.0 proposal #26098

This was referenced Feb 15, 2019

Closed
Closed
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.