★ wanayoo — archive 1999 https://github.com/nodejs/node/pull/25994Nouvelle recherche | Portail wanayoo
Skip to content

/node

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

win, build: add arbitrary MSBuild flag option and binlog option #25994

Closed
wants to merge 1 commit into
base: master
from

Conversation

Reviewers

@refack refack

@joaocgreis joaocgreis

Assignees
No one assigned
Labels
build windows
Projects
None yet
Milestone
No milestone
4 participants
@jkunkee @refack @joaocgreis @nodejs-github-bot
@jkunkee
Copy link
Contributor

jkunkee commented Feb 7, 2019 •
edited

This commit adds a 'verbose' flag to vcbuild.bat that turns on outputs
useful for build debugging, including MSBuild BinLogging and
DEBUG_HELPER logging.

It also adds a 'setlocal' call so internal environment variables no
longer leak out to the calling shell.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

[Edit: Note new commit message (cf0681c)]

@nodejs-github-bot nodejs-github-bot added build windows labels Feb 7, 2019

@jkunkee jkunkee force-pushed the jkunkee:win-build-script-tweaks branch from 94eea9a to 623ec64 Feb 7, 2019

@jkunkee jkunkee changed the title win, build: add 'verbose' mode and improve environment management win, build: add 'verbose' mode and scope environment changes Feb 7, 2019

@refack

refack requested changes Feb 7, 2019
View changes

Show resolved Hide resolved vcbuild.bat Outdated
@refack

This comment has been minimized.

Sign in to view
Copy link
Member

refack commented Feb 7, 2019

Hello @jkunkee
and welcome. Thank you for your contribution 🥇
If you are not familiar with our review and landing process, it's covered in CONTRIBUTING.md

I like the idea behind the proposed change, but I think we can do it with a simpler, more generic way 🤷‍♂️.

P.S. If you have any questions you can also feel free to contact me directly.
@refack

This comment has been minimized.

Sign in to view
Copy link
Member

refack commented Feb 7, 2019

/CC @nodejs/build-files @nodejs/platform-windows
@jkunkee

This comment has been minimized.

Sign in to view
Copy link
Contributor Author

jkunkee commented Feb 8, 2019

Thanks for the welcome and the review! I've reread the contributor and PR guides and will email you soon.

@jkunkee jkunkee referenced this pull request Feb 8, 2019

Open

Support ARM64 Windows desktop #25998

@jkunkee jkunkee force-pushed the jkunkee:win-build-script-tweaks branch 2 times, most recently from 4bed141 to 490f726 Feb 8, 2019

@refack

refack reviewed Feb 9, 2019
View changes

Show resolved Hide resolved vcbuild.bat Outdated

@jkunkee jkunkee force-pushed the jkunkee:win-build-script-tweaks branch 2 times, most recently from 4edce07 to cf0681c Feb 9, 2019

@jkunkee jkunkee changed the title win, build: add 'verbose' mode and scope environment changes win, build: add arbitrary MSBuild flag option and binlog option Feb 10, 2019

@jkunkee

This comment has been minimized.

Sign in to view
Copy link
Contributor Author

jkunkee commented Feb 10, 2019

Note new commit message (cf0681c)
@joaocgreis

joaocgreis approved these changes Feb 13, 2019
View changes

@joaocgreis

This comment has been minimized.

Sign in to view
Copy link
Member

joaocgreis commented Feb 13, 2019 •
edited

CI: https://ci.nodejs.org/view/All/job/node-test-pull-request/20750/ ❌ (arm-fanned)
Resumed: https://ci.nodejs.org/view/All/job/node-test-pull-request/20765/ ✔️

@refack does your request for changes still hold?
@jkunkee
win, build: add arbitrary MSBuild flag option and binlog option 
This change adds a 'msbuild_arg' option to vcbuild.bat that can be used
to pass arbitrary flags to MSBuild.

It also adds a 'binlog' flag as a shortcut 'msbuild_arg' option to
enable binary logging to `%config%\node.binlog`. This is especially
convenient when debugging changes to the build system.

In the process of developing this change, the idea of adding 'setlocal'
to the beginning of the script was rejected since other scripts in this
repo rely on the exported environment variables. This change adds a
note describing this.
Loading status checks…
11b5a48

@jkunkee jkunkee force-pushed the jkunkee:win-build-script-tweaks branch from cf0681c to 11b5a48 Feb 20, 2019

@joaocgreis

This comment has been minimized.

Sign in to view
Copy link
Member

joaocgreis commented Mar 4, 2019 •
edited

@refack I believe your feedback has been addressed, I'll assume there's no problem with landing this.

CI: https://ci.nodejs.org/job/node-test-pull-request/21182/ ✔️

joaocgreis added a commit that referenced this pull request Mar 4, 2019

@jkunkee @joaocgreis
win,build: add arbitrary and binlog options 
This change adds a 'msbuild_arg' option to vcbuild.bat that can be used
to pass arbitrary flags to MSBuild.

It also adds a 'binlog' flag as a shortcut 'msbuild_arg' option to
enable binary logging to `%config%\node.binlog`. This is especially
convenient when debugging changes to the build system.

In the process of developing this change, the idea of adding 'setlocal'
to the beginning of the script was rejected since other scripts in this
repo rely on the exported environment variables. This change adds a
note describing this.

PR-URL: #25994
Reviewed-By: João Reis <reis@janeasystems.com>
d57c526
@joaocgreis

This comment has been minimized.

Sign in to view
Copy link
Member

joaocgreis commented Mar 4, 2019

Landed in d57c526
Thanks @jkunkee!

@joaocgreis joaocgreis closed this Mar 4, 2019

@refack refack referenced this pull request Mar 4, 2019

Closed

build,win: simplify new `msbuild_arg` option #26431

3 of 3 tasks complete
@jkunkee

This comment has been minimized.

Sign in to view
Copy link
Contributor Author

jkunkee commented Mar 4, 2019

Thanks, @joaocgreis!

BridgeAR added a commit to BridgeAR/node that referenced this pull request Mar 6, 2019

@refack @BridgeAR
build,win: simplify new `msbuild_arg` option 
PR-URL: nodejs#26431
Refs: nodejs#25994
Reviewed-By: João Reis <reis@janeasystems.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Verified
This commit was signed with a verified signature.
@BridgeAR BridgeAR Ruben Bridgewater
GPG key ID: F07496B3EB3C1762 Learn about signing commits
dfffb6d

@jkunkee jkunkee deleted the jkunkee:win-build-script-tweaks branch Mar 8, 2019

BridgeAR added a commit to BridgeAR/node that referenced this pull request Mar 12, 2019

@jkunkee @BridgeAR
win,build: add arbitrary and binlog options 
This change adds a 'msbuild_arg' option to vcbuild.bat that can be used
to pass arbitrary flags to MSBuild.

It also adds a 'binlog' flag as a shortcut 'msbuild_arg' option to
enable binary logging to `%config%\node.binlog`. This is especially
convenient when debugging changes to the build system.

In the process of developing this change, the idea of adding 'setlocal'
to the beginning of the script was rejected since other scripts in this
repo rely on the exported environment variables. This change adds a
note describing this.

PR-URL: nodejs#25994
Reviewed-By: João Reis <reis@janeasystems.com>
Verified
This commit was signed with a verified signature.
@BridgeAR BridgeAR Ruben Bridgewater
GPG key ID: F07496B3EB3C1762 Learn about signing commits
d75cb91

BridgeAR added a commit to BridgeAR/node that referenced this pull request Mar 12, 2019

@refack @BridgeAR
build,win: simplify new `msbuild_arg` option 
PR-URL: nodejs#26431
Refs: nodejs#25994
Reviewed-By: João Reis <reis@janeasystems.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Verified
This commit was signed with a verified signature.
@BridgeAR BridgeAR Ruben Bridgewater
GPG key ID: F07496B3EB3C1762 Learn about signing commits
3dd7084

@BridgeAR BridgeAR referenced this pull request Mar 13, 2019

Merged

2019-03-14, Version 11.12.0 (Current) #26644

BridgeAR added a commit that referenced this pull request Mar 14, 2019

@refack @BridgeAR
build,win: simplify new `msbuild_arg` option 
PR-URL: #26431
Refs: #25994
Reviewed-By: João Reis <reis@janeasystems.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Verified
This commit was signed with a verified signature.
@BridgeAR BridgeAR Ruben Bridgewater
GPG key ID: F07496B3EB3C1762 Learn about signing commits
c247153
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.