★ wanayoo — archive 1999 https://github.com/nodejs/node/pull/25862Nouvelle recherche | Portail wanayoo
Skip to content

/node

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lib: use `internal/options` to query `--abort-on-uncaught-exception` #25862

Closed
wants to merge 1 commit into from

Conversation

Reviewers

@addaleax addaleax

@lpinca lpinca

@cjihrig cjihrig

@richardlau richardlau

@devsnek devsnek

Assignees
No one assigned
Labels
C++ async_hooks author ready
Projects
None yet
Milestone
No milestone
7 participants
@joyeecheung @nodejs-github-bot @addaleax @lpinca @cjihrig @richardlau @devsnek
@joyeecheung
Copy link
Member

commented Feb 1, 2019

Instead of using
internalBinding('config').shouldAbortOnUncaughtException.
Also removes that property from the binding.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
@nodejs-github-bot

@nodejs-github-bot nodejs-github-bot added async_hooks C++ labels Feb 1, 2019

@joyeecheung joyeecheung requested a review from addaleax Feb 1, 2019

@joyeecheung

This comment has been minimized.

Sign in to view
Copy link
Member Author

commented Feb 1, 2019

CI: https://ci.nodejs.org/job/node-test-pull-request/20500/
@richardlau

richardlau approved these changes Feb 1, 2019
View changes

@lpinca

lpinca approved these changes Feb 1, 2019
View changes

@devsnek

devsnek approved these changes Feb 1, 2019
View changes

@addaleax

addaleax approved these changes Feb 2, 2019
View changes

Copy link
Member

left a comment

LGTM but this needs a rebase :)
@cjihrig

cjihrig approved these changes Feb 2, 2019
View changes

@joyeecheung
lib: use `internal/options` to query `--abort-on-uncaught-exception` 
Instead of using
`internalBinding('config').shouldAbortOnUncaughtException`.
Also removes that property from the binding.
Verified
This commit was signed with a verified signature.
@joyeecheung joyeecheung Joyee Cheung
GPG key ID: 92B78A53C8303B8D Learn about signing commits
Loading status checks…
c9475ec

@joyeecheung joyeecheung force-pushed the joyeecheung:shouldabort branch from 0995c7e to c9475ec Feb 7, 2019

@joyeecheung

This comment has been minimized.

Sign in to view
Copy link
Member Author

commented Feb 7, 2019

Rebased. CI: https://ci.nodejs.org/job/node-test-pull-request/20641/

@joyeecheung joyeecheung added the author ready label Feb 7, 2019

@joyeecheung

This comment has been minimized.

Sign in to view
Copy link
Member Author

commented Feb 7, 2019

Resume: https://ci.nodejs.org/job/node-test-pull-request/20649/
@joyeecheung

This comment has been minimized.

Sign in to view
Copy link
Member Author

commented Feb 8, 2019

Landed in b44131a

@joyeecheung joyeecheung closed this Feb 8, 2019

joyeecheung added a commit that referenced this pull request Feb 8, 2019

@joyeecheung
lib: use `internal/options` to query `--abort-on-uncaught-exception` 
Instead of using
`internalBinding('config').shouldAbortOnUncaughtException`.
Also removes that property from the binding.

PR-URL: #25862
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Verified
This commit was signed with a verified signature.
@joyeecheung joyeecheung Joyee Cheung
GPG key ID: 92B78A53C8303B8D Learn about signing commits
Loading status checks…
b44131a

addaleax added a commit that referenced this pull request Feb 8, 2019

@joyeecheung @addaleax
lib: use `internal/options` to query `--abort-on-uncaught-exception` 
Instead of using
`internalBinding('config').shouldAbortOnUncaughtException`.
Also removes that property from the binding.

PR-URL: #25862
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Verified
This commit was signed with a verified signature.
@addaleax addaleax Anna Henningsen
GPG key ID: 9C63F3A6CD2AD8F9 Learn about signing commits
b06f2fa

@ZYSzys ZYSzys referenced this pull request Feb 10, 2019

Closed

[v11.x backport] src: cleanup cli options on `internalBinding('config')` #26027

2 of 2 tasks complete

@targos targos referenced this pull request Feb 14, 2019

Merged

v11.10.0 proposal #26098

This was referenced Feb 15, 2019

Closed
Closed
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.