Perfect your code
With built-in code review tools, GitHub makes it easy to raise the quality bar before you ship. Join the 36 million developers who've merged over 200 million pull requests.
Sign up for free See pricing for teams and enterprisessrc: add debug check for inspector uv_async_t #25777
Conversation
This comment has been minimized.
This comment has been minimized.
nodejs-github-bot
added
C++
inspector
labels
Jan 28, 2019
eugeneo
approved these changes
Jan 28, 2019
JungMinu
approved these changes
Jan 29, 2019
This comment has been minimized.
This comment has been minimized.
addaleax
added
the
author ready
label
Jan 29, 2019
jasnell
approved these changes
Jan 29, 2019
This comment has been minimized.
This comment has been minimized.
|
Landed in 15b0ab1 |
addaleax
closed this
Jan 30, 2019
addaleax
deleted the
addaleax:inspector-agent-init-check
branch
Jan 30, 2019
addaleax
added a commit
that referenced
this pull request
Jan 30, 2019
addaleax
added a commit
that referenced
this pull request
Jan 30, 2019
This was referenced Feb 15, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
addaleax commentedJan 28, 2019
Add a check to make sure start_io_thread_async is not
accidentally re-used or used when uninitialized.
(This is a bit of an odd check imo, but it helped me figure
out a real issue and it might do so again, so… why not?)
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes