★ wanayoo — archive 1999 https://github.com/nodejs/node/pull/25609Nouvelle recherche | Portail wanayoo
Skip to content

/node

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

http2: allow fully synchronous `_final()` #25609

Closed
wants to merge 2 commits into from

Conversation

@addaleax
Copy link
Member

commented Jan 21, 2019

/cc @mcollina

HTTP/2 streams do not use the fact that the native
StreamBase::Shutdown() is asynchronous by default and
always finish synchronously.

Adding a status code for this scenario allows skipping an
expensive MakeCallback() C++/JS boundary crossing.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
@addaleax
http2: allow fully synchronous `_final()` 
HTTP/2 streams do not use the fact that the native
`StreamBase::Shutdown()` is asynchronous by default and
always finish synchronously.

Adding a status code for this scenario allows skipping an
expensive `MakeCallback()` C++/JS boundary crossing.
Verified
This commit was signed with a verified signature.
addaleax Anna Henningsen
GPG key ID: 9C63F3A6CD2AD8F9 Learn about signing commits
Loading status checks…
90fbe14
@nodejs-github-bot

This comment has been minimized.

Sign in to view
Copy link

commented Jan 21, 2019

@addaleax build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/2316/pipeline

@nodejs-github-bot nodejs-github-bot added C++ lib / src labels Jan 21, 2019

@sam-github
sam-github approved these changes Jan 21, 2019
View changes
Copy link
Member

left a comment

The docs in particular are quite helpful, thanks.
src/stream_base.h Outdated Show resolved Hide resolved
@mcollina
mcollina approved these changes Jan 21, 2019
View changes
Copy link
Member

left a comment

LGTM
@addaleax
fixup! http2: allow fully synchronous `_final()`
Verified
This commit was signed with a verified signature.
addaleax Anna Henningsen
GPG key ID: 9C63F3A6CD2AD8F9 Learn about signing commits
Loading status checks…
66fdcc1
@addaleax

This comment has been minimized.

Sign in to view
Copy link
Member Author

commented Jan 21, 2019 •
edited

CI: https://ci.nodejs.org/job/node-test-pull-request/20239/ (✅)

@addaleax addaleax added the author ready label Jan 21, 2019

@addaleax

This comment has been minimized.

Sign in to view
Copy link
Member Author

commented Jan 23, 2019

Landed in 2b65399

@addaleax addaleax closed this Jan 23, 2019

@addaleax addaleax deleted the addaleax:shutdown-sync branch Jan 23, 2019

pull bot pushed a commit to shakir-abdo/node that referenced this pull request Jan 23, 2019
@addaleax
http2: allow fully synchronous `_final()` 
HTTP/2 streams do not use the fact that the native
`StreamBase::Shutdown()` is asynchronous by default and
always finish synchronously.

Adding a status code for this scenario allows skipping an
expensive `MakeCallback()` C++/JS boundary crossing.

PR-URL: nodejs#25609
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Verified
This commit was signed with a verified signature.
addaleax Anna Henningsen
GPG key ID: 9C63F3A6CD2AD8F9 Learn about signing commits
2b65399
addaleax added a commit that referenced this pull request Jan 23, 2019
@addaleax
http2: allow fully synchronous `_final()` 
HTTP/2 streams do not use the fact that the native
`StreamBase::Shutdown()` is asynchronous by default and
always finish synchronously.

Adding a status code for this scenario allows skipping an
expensive `MakeCallback()` C++/JS boundary crossing.

PR-URL: #25609
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Verified
This commit was signed with a verified signature.
addaleax Anna Henningsen
GPG key ID: 9C63F3A6CD2AD8F9 Learn about signing commits
9a410a1
@MylesBorins MylesBorins referenced this pull request Jan 24, 2019
Merged
BethGriggs added a commit that referenced this pull request Apr 29, 2019
@addaleax @BethGriggs
http2: allow fully synchronous `_final()` 
HTTP/2 streams do not use the fact that the native
`StreamBase::Shutdown()` is asynchronous by default and
always finish synchronously.

Adding a status code for this scenario allows skipping an
expensive `MakeCallback()` C++/JS boundary crossing.

PR-URL: #25609
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Verified
This commit was signed with a verified signature.
BethGriggs Bethany Nicolle Griggs
GPG key ID: D7062848A1AB005C Learn about signing commits
48ff32f
@BethGriggs BethGriggs referenced this pull request May 1, 2019
Merged
BethGriggs added a commit that referenced this pull request May 10, 2019
@addaleax @BethGriggs
http2: allow fully synchronous `_final()` 
HTTP/2 streams do not use the fact that the native
`StreamBase::Shutdown()` is asynchronous by default and
always finish synchronously.

Adding a status code for this scenario allows skipping an
expensive `MakeCallback()` C++/JS boundary crossing.

PR-URL: #25609
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Verified
This commit was signed with a verified signature.
BethGriggs Bethany Nicolle Griggs
GPG key ID: D7062848A1AB005C Learn about signing commits
6e5c208
MylesBorins added a commit that referenced this pull request May 16, 2019
@addaleax @MylesBorins
http2: allow fully synchronous `_final()` 
HTTP/2 streams do not use the fact that the native
`StreamBase::Shutdown()` is asynchronous by default and
always finish synchronously.

Adding a status code for this scenario allows skipping an
expensive `MakeCallback()` C++/JS boundary crossing.

PR-URL: #25609
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Verified
This commit was signed with a verified signature.
MylesBorins Myles Borins
GPG key ID: 933B01F40B5CA946 Learn about signing commits
decba1c
This was referenced May 29, 2019
Closed
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sam-github sam-github

@mcollina mcollina

Assignees
No one assigned
Labels
C++ author ready lib / src
Projects
None yet
Milestone
No milestone
4 participants
@addaleax @nodejs-github-bot @sam-github @mcollina
You can’t perform that action at this time.