build: make compress_json python3 compatible #25582
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch replaces a usage of `map` with list comprehension, which makes the script Python 3 compatiable.
refack
approved these changes
Jan 19, 2019
|
I'm looking at the history, and it seems like this is a node-core only tool. Maybe we can eliminate it. |
cclauss
approved these changes
Jan 19, 2019
|
@refack Good call. If we can get rid of this, one less file to maintain. |
What is the question? I introduced it to shrink the size of the embedded JSON. Currently it reduces its size from about 140k to 15k. |
|
Re-run of failing node-test-commit-linux-containered |
|
Landed in b31b84d. |
danbev
pushed a commit
that referenced
this issue
Jan 28, 2019
This patch replaces a usage of `map` with list comprehension, which makes the script Python 3 compatiable. PR-URL: #25582 Reviewed-By: Refael Ackermann <refack@gmail.com>
addaleax
pushed a commit
that referenced
this issue
Jan 28, 2019
This patch replaces a usage of `map` with list comprehension, which makes the script Python 3 compatiable. PR-URL: #25582 Reviewed-By: Refael Ackermann <refack@gmail.com>
Merged
BethGriggs
pushed a commit
that referenced
this issue
Apr 29, 2019
This patch replaces a usage of `map` with list comprehension, which makes the script Python 3 compatiable. PR-URL: #25582 Reviewed-By: Refael Ackermann <refack@gmail.com>
Merged
BethGriggs
pushed a commit
that referenced
this issue
May 10, 2019
This patch replaces a usage of `map` with list comprehension, which makes the script Python 3 compatiable. PR-URL: #25582 Reviewed-By: Refael Ackermann <refack@gmail.com>
MylesBorins
pushed a commit
that referenced
this issue
May 16, 2019
This patch replaces a usage of `map` with list comprehension, which makes the script Python 3 compatiable. PR-URL: #25582 Reviewed-By: Refael Ackermann <refack@gmail.com>
BaochengSu
pushed a commit
to BaochengSu/node
that referenced
this issue
Oct 20, 2020
This patch replaces a usage of `map` with list comprehension, which makes the script Python 3 compatiable. PR-URL: nodejs#25582 Reviewed-By: Refael Ackermann <refack@gmail.com> (cherry picked from commit b31b84d)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
This patch replaces a usage of
mapwith list comprehension,which makes the script Python 3 compatiable.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passescc @nodejs/python @cclauss