★ wanayoo — archive 1999 https://github.com/nodejs/node/pull/25571Nouvelle recherche | Portail wanayoo
Skip to content

/node

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: upgrade to libuv 1.25.0 #25571

Merged
merged 1 commit into from Jan 21, 2019

Conversation

@cjihrig
Copy link
Contributor

commented Jan 18, 2019

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
@nodejs-github-bot

This comment has been minimized.

Sign in to view
Copy link

commented Jan 18, 2019

@cjihrig build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/2290/pipeline

@nodejs-github-bot nodejs-github-bot added the libuv label Jan 18, 2019

@targos

This comment has been minimized.

Sign in to view
Copy link
Member

commented Jan 18, 2019

Are there notable changes?
@addaleax
addaleax approved these changes Jan 18, 2019
View changes
@cjihrig

This comment has been minimized.

Sign in to view
Copy link
Contributor Author

commented Jan 19, 2019

Are there notable changes?

The full changelog for the release is available here. Changes that might be notable to Node:
@cjihrig

This comment has been minimized.

Sign in to view
Copy link
Contributor Author

commented Jan 19, 2019

Green CI: https://ci.nodejs.org/job/node-test-pull-request/20209/
@cjihrig

This comment has been minimized.

Sign in to view
Copy link
Contributor Author

commented Jan 21, 2019

cc: @nodejs/libuv
@santigimeno
santigimeno approved these changes Jan 21, 2019
View changes
@cjihrig
deps: upgrade to libuv 1.25.0 
PR-URL: #25571
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
Verified
This commit was signed with a verified signature.
cjihrig Colin Ihrig
GPG key ID: 7434390BDBE9B9C5 Learn about signing commits
Loading status checks…
f698386

@cjihrig cjihrig force-pushed the cjihrig:libuv branch from f9f2365 to f698386 Jan 21, 2019

@cjihrig cjihrig merged commit f698386 into nodejs:master Jan 21, 2019
1 of 2 checks passed

1 of 2 checks passed

Travis CI - Pull Request Build Errored
Details
Travis CI - Branch Build Passed
Details

@cjihrig cjihrig deleted the cjihrig:libuv branch Jan 21, 2019

targos added a commit that referenced this pull request Jan 24, 2019
@cjihrig @targos
deps: upgrade to libuv 1.25.0 
PR-URL: #25571
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
Verified
This commit was signed with a verified signature.
targos Michaël Zasso
GPG key ID: 770F7A9A5AE15600 Learn about signing commits
c0859d7
@MylesBorins MylesBorins referenced this pull request Jan 24, 2019
Merged
@MylesBorins MylesBorins referenced this pull request May 2, 2019
Open
MylesBorins added a commit to MylesBorins/node that referenced this pull request May 16, 2019
@cjihrig @MylesBorins
deps: upgrade to libuv 1.25.0 
PR-URL: nodejs#25571
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
Verified
This commit was signed with a verified signature.
MylesBorins Myles Borins
GPG key ID: 933B01F40B5CA946 Learn about signing commits
45a47b0
MylesBorins added a commit that referenced this pull request May 16, 2019
@cjihrig @MylesBorins
deps: upgrade to libuv 1.25.0 
Backport-PR-URL: #27728
PR-URL: #25571
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
Verified
This commit was signed with a verified signature.
MylesBorins Myles Borins
GPG key ID: 933B01F40B5CA946 Learn about signing commits
e6275f9
@BethGriggs BethGriggs referenced this pull request May 16, 2019
Merged
This was referenced May 29, 2019
Closed
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@addaleax addaleax

@santigimeno santigimeno

Assignees
No one assigned
Labels
libuv
Projects
None yet
Milestone
No milestone
5 participants
@cjihrig @nodejs-github-bot @targos @addaleax @santigimeno
You can’t perform that action at this time.