Perfect your code
With built-in code review tools, GitHub makes it easy to raise the quality bar before you ship. Join the 31 million developers who've merged over 200 million pull requests.
Sign up for free See pricing for teams and enterprisestest: use stronger curves for keygen #25564
Conversation
This comment has been minimized.
This comment has been minimized.
nodejs-github-bot
added
the
test
label
Jan 18, 2019
This comment has been minimized.
This comment has been minimized.
sam-github
approved these changes
Jan 18, 2019
|
I know the commit description says |
danbev
force-pushed the
danbev:test-crypto-keygen-rhel8
branch
from
ef558fb
to
573f8cf
Jan 20, 2019
This comment has been minimized.
This comment has been minimized.
Yeah, that sounds good. I've updated now. Thanks |
danbev
changed the title
test: update P-192 and secp192k1 to 256 bit
test: use stronger curves for keygen
Jan 20, 2019
lpinca
approved these changes
Jan 20, 2019
This comment has been minimized.
This comment has been minimized.
|
Landed in 8b2e861. |
danbev
closed this
Jan 21, 2019
danbev
deleted the
danbev:test-crypto-keygen-rhel8
branch
Jan 21, 2019
danbev
added a commit
that referenced
this pull request
Jan 21, 2019
addaleax
added a commit
that referenced
this pull request
Jan 23, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
danbev commentedJan 18, 2019
This commit updates the named curves
P-192(prime192v1), andsecp192k1to 256 bit versions.
The motivation for this is that in Red Hat Enterprise Linux (RHEL) all
ECC curves < 224 bits are removed from OpenSSL provided by the system.
I'm not sure if other distributions do this but these 256 bit curves are
availalbe in OpenSSL 1.1.0j (current version on master) and OpenSSL
1.1.1 so as far as I can tell it should be safe change to make.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes