Perfect your code
With built-in code review tools, GitHub makes it easy to raise the quality bar before you ship. Join the 36 million developers who've merged over 200 million pull requests.
Sign up for free See pricing for teams and enterprisescrypto: fix key handle extraction #25562
Conversation
This comment has been minimized.
This comment has been minimized.
nodejs-github-bot
added
the
crypto
label
Jan 18, 2019
This comment has been minimized.
This comment has been minimized.
|
Node.js collaborators, please |
This was referenced Jan 18, 2019
Merged
lpinca
approved these changes
Jan 18, 2019
BridgeAR
approved these changes
Jan 18, 2019
BridgeAR
added
the
fast-track
label
Jan 18, 2019
This comment has been minimized.
This comment has been minimized.
|
Landed in 9315daa |
BridgeAR
closed this
Jan 18, 2019
BridgeAR
added a commit
to BridgeAR/node
that referenced
this pull request
Jan 18, 2019
addaleax
added a commit
that referenced
this pull request
Jan 23, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
tniessen commentedJan 18, 2019
I guess I don't need to say much about the commit itself. This causes the crash described in a comment in #25217, so it would be awesome if this could make it into 11.7.0 somehow, cc @BridgeAR.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes