★ wanayoo — archive 1999 https://github.com/nodejs/node/pull/25437Nouvelle recherche | Portail wanayoo
Skip to content

/node

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: check for tls renegotiation errors #25437

Closed
wants to merge 1 commit into from

Conversation

Reviewers

@addaleax addaleax

@lpinca lpinca

@cjihrig cjihrig

Assignees
No one assigned
Labels
test
Projects
None yet
Milestone
No milestone
7 participants
@sam-github @nodejs-github-bot @danbev @Trott @addaleax @lpinca @cjihrig
@sam-github
Copy link
Member

commented Jan 10, 2019

Check that the return value and callback error for tls.renegotiate()
does not indicate a failure. Also, remove unnecessary line wrapping and
indentation.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
@sam-github
test: check for tls renegotiation errors 
Check that the return value and callback error for tls.renegotiate()
does not indicate a failure. Also, remove unnecessary line wrapping and
indentation.
Loading status checks…
f80f319
@nodejs-github-bot

@nodejs-github-bot nodejs-github-bot added the test label Jan 10, 2019

@cjihrig

cjihrig approved these changes Jan 11, 2019
View changes

@lpinca

lpinca approved these changes Jan 11, 2019
View changes

@addaleax

addaleax approved these changes Jan 12, 2019
View changes

@danbev

This comment has been minimized.

Sign in to view
Copy link
Member

commented Jan 14, 2019

Landed in 641b013.

@danbev danbev closed this Jan 14, 2019

danbev added a commit that referenced this pull request Jan 14, 2019

@sam-github @danbev
test: check for tls renegotiation errors 
Check that the return value and callback error for tls.renegotiate()
does not indicate a failure. Also, remove unnecessary line wrapping and
indentation.

PR-URL: #25437
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Loading status checks…
641b013

addaleax added a commit that referenced this pull request Jan 14, 2019

@sam-github @addaleax
test: check for tls renegotiation errors 
Check that the return value and callback error for tls.renegotiate()
does not indicate a failure. Also, remove unnecessary line wrapping and
indentation.

PR-URL: #25437
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Verified
This commit was signed with a verified signature.
@addaleax addaleax Anna Henningsen
GPG key ID: 9C63F3A6CD2AD8F9 Learn about signing commits
29b89ba

@sam-github sam-github deleted the sam-github:check-for-renegotiate-errors branch Jan 14, 2019

@Trott

This comment has been minimized.

Sign in to view
Copy link
Member

commented Jan 15, 2019

Doesn't look like this PR got a full CI run.
@danbev

This comment has been minimized.

Sign in to view
Copy link
Member

commented Jan 15, 2019

Doesn't look like this PR got a full CI run.

I missed that completely, sorry 😞 Not that is helps much but I always run the complete test suite before pushing upstream.

@BridgeAR BridgeAR referenced this pull request Jan 16, 2019

Merged

v11.7.0 proposal #25537

BridgeAR added a commit to BridgeAR/node that referenced this pull request Jan 16, 2019

@sam-github @BridgeAR
test: check for tls renegotiation errors 
Check that the return value and callback error for tls.renegotiate()
does not indicate a failure. Also, remove unnecessary line wrapping and
indentation.

PR-URL: nodejs#25437
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Unverified
The committer email address is not verified.
Learn about signing commits
c3b9149

@MylesBorins MylesBorins referenced this pull request Jan 24, 2019

Merged

v11.8.0 proposal #25687

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.