★ wanayoo — archive 1999 https://github.com/nodejs/node/pull/25427Nouvelle recherche | Portail wanayoo
Skip to content

/node

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: remove unnecessary skipIfWorker() #25427

Closed
wants to merge 1 commit into from

Conversation

@Trott
Copy link
Member

commented Jan 10, 2019

test-inspector-port-cluster passes in workers. Remove skipIfWorker()
from the test.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
@Trott
test: remove unnecessary skipIfWorker() 
test-inspector-port-cluster passes in workers. Remove skipIfWorker()
from the test.
Loading status checks…
d41201c
@nodejs-github-bot

This comment has been minimized.

Sign in to view
Copy link

commented Jan 10, 2019

@Trott build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/2216/pipeline

@nodejs-github-bot nodejs-github-bot added the test label Jan 10, 2019

@Trott

This comment has been minimized.

Sign in to view
Copy link
Member Author

commented Jan 10, 2019 •
edited by addaleax

CI: https://ci.nodejs.org/job/node-test-pull-request/20041/ (✔️)
@eugeneo
eugeneo approved these changes Jan 10, 2019
View changes
@BridgeAR
BridgeAR approved these changes Jan 10, 2019
View changes

@addaleax addaleax added the author ready label Jan 10, 2019

@benjamingr
benjamingr approved these changes Jan 10, 2019
View changes
@cjihrig
cjihrig approved these changes Jan 10, 2019
View changes
@lpinca
lpinca approved these changes Jan 10, 2019
View changes
Trott added a commit to Trott/io.js that referenced this pull request Jan 12, 2019
@Trott
test: remove unnecessary skipIfWorker() 
test-inspector-port-cluster passes in workers. Remove skipIfWorker()
from the test.

PR-URL: nodejs#25427
Reviewed-By: Eugene Ostroukhov <eostroukhov@google.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
91ef9c4
@Trott

This comment has been minimized.

Sign in to view
Copy link
Member Author

commented Jan 12, 2019

Landed in 91ef9c4

@Trott Trott closed this Jan 12, 2019

addaleax added a commit that referenced this pull request Jan 14, 2019
@Trott @addaleax
test: remove unnecessary skipIfWorker() 
test-inspector-port-cluster passes in workers. Remove skipIfWorker()
from the test.

PR-URL: #25427
Reviewed-By: Eugene Ostroukhov <eostroukhov@google.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Verified
This commit was signed with a verified signature.
addaleax Anna Henningsen
GPG key ID: 9C63F3A6CD2AD8F9 Learn about signing commits
d86a3e8
@BridgeAR BridgeAR referenced this pull request Jan 16, 2019
Merged
BridgeAR added a commit to BridgeAR/node that referenced this pull request Jan 16, 2019
@Trott @BridgeAR
test: remove unnecessary skipIfWorker() 
test-inspector-port-cluster passes in workers. Remove skipIfWorker()
from the test.

PR-URL: nodejs#25427
Reviewed-By: Eugene Ostroukhov <eostroukhov@google.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Verified
This commit was signed with a verified signature.
BridgeAR Ruben Bridgewater
GPG key ID: F07496B3EB3C1762 Learn about signing commits
e5f88f5
@MylesBorins MylesBorins referenced this pull request Jan 24, 2019
Merged
BethGriggs added a commit that referenced this pull request Apr 28, 2019
@Trott @BethGriggs
test: remove unnecessary skipIfWorker() 
test-inspector-port-cluster passes in workers. Remove skipIfWorker()
from the test.

PR-URL: #25427
Reviewed-By: Eugene Ostroukhov <eostroukhov@google.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Verified
This commit was signed with a verified signature.
BethGriggs Bethany Nicolle Griggs
GPG key ID: D7062848A1AB005C Learn about signing commits
ada148d
@BethGriggs BethGriggs referenced this pull request May 1, 2019
Merged
BethGriggs added a commit that referenced this pull request May 10, 2019
@Trott @BethGriggs
test: remove unnecessary skipIfWorker() 
test-inspector-port-cluster passes in workers. Remove skipIfWorker()
from the test.

PR-URL: #25427
Reviewed-By: Eugene Ostroukhov <eostroukhov@google.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Verified
This commit was signed with a verified signature.
BethGriggs Bethany Nicolle Griggs
GPG key ID: D7062848A1AB005C Learn about signing commits
55899ef
MylesBorins added a commit that referenced this pull request May 16, 2019
@Trott @MylesBorins
test: remove unnecessary skipIfWorker() 
test-inspector-port-cluster passes in workers. Remove skipIfWorker()
from the test.

PR-URL: #25427
Reviewed-By: Eugene Ostroukhov <eostroukhov@google.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Verified
This commit was signed with a verified signature.
MylesBorins Myles Borins
GPG key ID: 933B01F40B5CA946 Learn about signing commits
d2df34d
This was referenced May 29, 2019
Closed
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eugeneo eugeneo

@benjamingr benjamingr

@lpinca lpinca

@cjihrig cjihrig

@BridgeAR BridgeAR

Assignees
No one assigned
Labels
author ready test
Projects
None yet
Milestone
No milestone
8 participants
@Trott @nodejs-github-bot @eugeneo @benjamingr @lpinca @cjihrig @BridgeAR @addaleax
You can’t perform that action at this time.