Perfect your code
With built-in code review tools, GitHub makes it easy to raise the quality bar before you ship. Join the 36 million developers who've merged over 200 million pull requests.
Sign up for free See pricing for teams and enterprises[v11.x] backport console related changes #25420
Conversation
joyeecheung
added some commits
Oct 12, 2018
This comment has been minimized.
This comment has been minimized.
nodejs-github-bot
added
console
v11.x
labels
Jan 9, 2019
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
@joyeecheung thanks a lot! I believe the second commit should be squashed into the first one while landing. Otherwise there would theoretically be one commit which would contain the breaking change in v11 (which might not be horrible?). |
addaleax
approved these changes
Jan 9, 2019
|
Thank you! :) |
BridgeAR
added a commit
that referenced
this pull request
Jan 9, 2019
This comment has been minimized.
This comment has been minimized.
|
Landed in 453bd18...4052aec |
BridgeAR
closed this
Jan 9, 2019
BridgeAR
added a commit
to BridgeAR/node
that referenced
this pull request
Jan 16, 2019
targos
added this to Closed PRs
in v11.x
Jan 30, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
joyeecheung commentedJan 9, 2019
•
edited
Backport #23509 #24047 and #24534 to v11.x
The second commit was added specifically for v11.x
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes