Perfect your code
With built-in code review tools, GitHub makes it easy to raise the quality bar before you ship. Join the 40 million developers who've merged over 200 million pull requests.
Sign up for free See pricing for teams and enterprisestest: fix module loading error for AIX 7.1 #25418
+2
−1
Conversation
This comment has been minimized.
This comment has been minimized.
nodejs-github-bot
added
the
test
label
Jan 9, 2019
richardlau
added
the
aix
label
Jan 9, 2019
BethGriggs
approved these changes
Jan 9, 2019
gireeshpunathil
approved these changes
Jan 9, 2019
This comment has been minimized.
This comment has been minimized.
richardlau
added
the
author ready
label
Jan 9, 2019
cjihrig
approved these changes
Jan 9, 2019
gdams
approved these changes
Jan 9, 2019
This comment has been minimized.
This comment has been minimized.
richardlau
force-pushed the
richardlau:alternative-aix-message
branch
from
e36a65d
to
fbab26f
Jan 11, 2019
richardlau
merged commit fbab26f
into
nodejs:master
Jan 11, 2019
addaleax
added a commit
that referenced
this pull request
Jan 14, 2019
Merged
BridgeAR
added a commit
to BridgeAR/node
that referenced
this pull request
Jan 16, 2019
Merged
BethGriggs
added a commit
that referenced
this pull request
Mar 15, 2019
BethGriggs
added a commit
that referenced
this pull request
Mar 15, 2019
Merged
Merged
This was referenced May 29, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
richardlau commentedJan 9, 2019
•
edited
Building the current
masteron AIX 7.1 andgcc 6.3.0I get the following test failure:I've verified using
python(not all of the AIX machines that I have access to have the necessary environment set up to build/run Node.js) that the error message fromdlopenis different on AIX 7.1 compared to AIX 6.1.AIX 7.1:
AIX 6.1:
This PR adds another allowed error message for AIX to allow the test to pass.
Note that the CI AIX machines are currently AIX 6.1.
cc @nodejs/platform-aix
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes