★ wanayoo — archive 1999 https://github.com/nodejs/node/pull/25417Nouvelle recherche | Portail wanayoo
Skip to content

/node

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: `os.networkInterfaces()` example outdated #25417

Closed
wants to merge 1 commit into from

Conversation

@jvelezpo
Copy link
Contributor

commented Jan 9, 2019

The os.networkInterfaces() example was outdated
as the IPv6 interfaces did not include the scopeid property,
now they do.

Fixes: #25408

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines
@jvelezpo
doc: `os.networkInterfaces()` example outdated 
The os.networkInterfaces() example was outdated
as the IPv6 interfaces did not include the scopeid property,
now they do.

Fixes: #25408
Verified
This commit was signed with a verified signature.
jvelezpo Juan Sebastian velez Posada
GPG key ID: 1D83B582E9CBBCB0 Learn about signing commits
Loading status checks…
1cbf090

@nodejs-github-bot nodejs-github-bot added doc os labels Jan 9, 2019

@vsemozhetbyt

This comment has been minimized.

Sign in to view
Copy link
Contributor

commented Jan 9, 2019

CI-lite: https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/2205/
@BridgeAR
BridgeAR approved these changes Jan 10, 2019
View changes

@BridgeAR BridgeAR added the author ready label Jan 10, 2019

@starkwang
starkwang approved these changes Jan 11, 2019
View changes
@vsemozhetbyt

This comment has been minimized.

Sign in to view
Copy link
Contributor

commented Jan 11, 2019

Landed in c380ea1
Thank you!

@vsemozhetbyt vsemozhetbyt closed this Jan 11, 2019

vsemozhetbyt added a commit that referenced this pull request Jan 11, 2019
@jvelezpo @vsemozhetbyt
doc: update `os.networkInterfaces()` example 
The os.networkInterfaces() example was outdated
as the IPv6 interfaces did not include the scopeid property,
now they do.

PR-URL: #25417
Fixes: #25408
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Weijia Wang <starkwang@126.com>
Loading status checks…
c380ea1
addaleax added a commit that referenced this pull request Jan 14, 2019
@jvelezpo @addaleax
doc: update `os.networkInterfaces()` example 
The os.networkInterfaces() example was outdated
as the IPv6 interfaces did not include the scopeid property,
now they do.

PR-URL: #25417
Fixes: #25408
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Weijia Wang <starkwang@126.com>
Verified
This commit was signed with a verified signature.
addaleax Anna Henningsen
GPG key ID: 9C63F3A6CD2AD8F9 Learn about signing commits
177635b
@BridgeAR BridgeAR referenced this pull request Jan 16, 2019
Merged
BridgeAR added a commit to BridgeAR/node that referenced this pull request Jan 16, 2019
@jvelezpo @BridgeAR
doc: update `os.networkInterfaces()` example 
The os.networkInterfaces() example was outdated
as the IPv6 interfaces did not include the scopeid property,
now they do.

PR-URL: nodejs#25417
Fixes: nodejs#25408
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Weijia Wang <starkwang@126.com>
Verified
This commit was signed with a verified signature.
BridgeAR Ruben Bridgewater
GPG key ID: F07496B3EB3C1762 Learn about signing commits
f101222
@MylesBorins MylesBorins referenced this pull request Jan 24, 2019
Merged
BethGriggs added a commit that referenced this pull request Apr 28, 2019
@jvelezpo @BethGriggs
doc: update `os.networkInterfaces()` example 
The os.networkInterfaces() example was outdated
as the IPv6 interfaces did not include the scopeid property,
now they do.

PR-URL: #25417
Fixes: #25408
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Weijia Wang <starkwang@126.com>
Verified
This commit was signed with a verified signature.
BethGriggs Bethany Nicolle Griggs
GPG key ID: D7062848A1AB005C Learn about signing commits
614edcb
@BethGriggs BethGriggs referenced this pull request May 1, 2019
Merged
BethGriggs added a commit that referenced this pull request May 10, 2019
@jvelezpo @BethGriggs
doc: update `os.networkInterfaces()` example 
The os.networkInterfaces() example was outdated
as the IPv6 interfaces did not include the scopeid property,
now they do.

PR-URL: #25417
Fixes: #25408
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Weijia Wang <starkwang@126.com>
Verified
This commit was signed with a verified signature.
BethGriggs Bethany Nicolle Griggs
GPG key ID: D7062848A1AB005C Learn about signing commits
46711c7
MylesBorins added a commit that referenced this pull request May 16, 2019
@jvelezpo @MylesBorins
doc: update `os.networkInterfaces()` example 
The os.networkInterfaces() example was outdated
as the IPv6 interfaces did not include the scopeid property,
now they do.

PR-URL: #25417
Fixes: #25408
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Weijia Wang <starkwang@126.com>
Verified
This commit was signed with a verified signature.
MylesBorins Myles Borins
GPG key ID: 933B01F40B5CA946 Learn about signing commits
3a30c87
This was referenced May 29, 2019
Closed
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BridgeAR BridgeAR

@starkwang starkwang

Assignees
No one assigned
Labels
author ready doc os
Projects
None yet
Milestone
No milestone
5 participants
@jvelezpo @vsemozhetbyt @BridgeAR @starkwang @nodejs-github-bot
You can’t perform that action at this time.