★ wanayoo — archive 1999 https://github.com/nodejs/node/pull/25370Nouvelle recherche | Portail wanayoo
Skip to content

/node

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

src: clean up `node::Init()` wrt embedder scenarios #25370

Closed
wants to merge 1 commit into from

Conversation

@addaleax
Copy link
Member

commented Jan 6, 2019

This makes the STL variant of node::Init() a bit more
suitable for inclusion in a proper embedder API, as errors
or other output are reported to the caller rather than
directly being printed, and the process is not exited
directly either.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
@nodejs-github-bot

This comment has been minimized.

Sign in to view
Copy link

commented Jan 6, 2019

@addaleax build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/2157/pipeline

@nodejs-github-bot nodejs-github-bot added the C++ label Jan 6, 2019

@bnoordhuis
bnoordhuis approved these changes Jan 7, 2019
View changes
src/node.cc Outdated Show resolved Hide resolved

@addaleax addaleax force-pushed the addaleax:embedder-api2 branch from 79f41b1 to 1c7e761 Jan 7, 2019

@bnoordhuis
bnoordhuis approved these changes Jan 8, 2019
View changes
Copy link
Member

left a comment

LGTM. Maybe add // Doesn't return. comments but that's up to you.
@jasnell
jasnell approved these changes Jan 8, 2019
View changes
@addaleax
src: clean up `node::Init()` wrt embedder scenarios 
This makes the STL variant of `node::Init()` a bit more
suitable for inclusion in a proper embedder API, as errors
or other output are reported to the caller rather than
directly being printed, and the process is not exited
directly either.
Verified
This commit was signed with a verified signature.
addaleax Anna Henningsen
GPG key ID: 9C63F3A6CD2AD8F9 Learn about signing commits
Loading status checks…
b52078f

@addaleax addaleax force-pushed the addaleax:embedder-api2 branch from 1c7e761 to b52078f Jan 8, 2019

@addaleax

This comment has been minimized.

Sign in to view
Copy link
Member Author

commented Jan 8, 2019

CI: https://ci.nodejs.org/job/node-test-pull-request/20005/

@addaleax addaleax added the author ready label Jan 9, 2019

@joyeecheung
joyeecheung approved these changes Jan 9, 2019
View changes
@danbev

This comment has been minimized.

Sign in to view
Copy link
Member

commented Jan 11, 2019

Landed in eb664c3.

@danbev danbev closed this Jan 11, 2019

danbev added a commit that referenced this pull request Jan 11, 2019
@addaleax @danbev
src: clean up `node::Init()` wrt embedder scenarios 
This makes the STL variant of `node::Init()` a bit more
suitable for inclusion in a proper embedder API, as errors
or other output are reported to the caller rather than
directly being printed, and the process is not exited
directly either.

PR-URL: #25370
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Loading status checks…
eb664c3
addaleax added a commit that referenced this pull request Jan 15, 2019
@addaleax
src: clean up `node::Init()` wrt embedder scenarios 
This makes the STL variant of `node::Init()` a bit more
suitable for inclusion in a proper embedder API, as errors
or other output are reported to the caller rather than
directly being printed, and the process is not exited
directly either.

PR-URL: #25370
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Verified
This commit was signed with a verified signature.
addaleax Anna Henningsen
GPG key ID: 9C63F3A6CD2AD8F9 Learn about signing commits
a162251
@BridgeAR BridgeAR referenced this pull request Jan 16, 2019
Merged
BridgeAR added a commit to BridgeAR/node that referenced this pull request Jan 16, 2019
@addaleax @BridgeAR
src: clean up `node::Init()` wrt embedder scenarios 
This makes the STL variant of `node::Init()` a bit more
suitable for inclusion in a proper embedder API, as errors
or other output are reported to the caller rather than
directly being printed, and the process is not exited
directly either.

PR-URL: nodejs#25370
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Verified
This commit was signed with a verified signature.
BridgeAR Ruben Bridgewater
GPG key ID: F07496B3EB3C1762 Learn about signing commits
97d1044
BridgeAR added a commit to BridgeAR/node that referenced this pull request Jan 17, 2019
@addaleax @BridgeAR
src: clean up `node::Init()` wrt embedder scenarios 
This makes the STL variant of `node::Init()` a bit more
suitable for inclusion in a proper embedder API, as errors
or other output are reported to the caller rather than
directly being printed, and the process is not exited
directly either.

PR-URL: nodejs#25370
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Verified
This commit was signed with a verified signature.
BridgeAR Ruben Bridgewater
GPG key ID: F07496B3EB3C1762 Learn about signing commits
299aefd
@MylesBorins MylesBorins referenced this pull request Jan 24, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bnoordhuis bnoordhuis

@jasnell jasnell

@joyeecheung joyeecheung

Assignees
No one assigned
Labels
C++ author ready
Projects
None yet
Milestone
No milestone
6 participants
@addaleax @nodejs-github-bot @danbev @bnoordhuis @jasnell @joyeecheung
You can’t perform that action at this time.