★ wanayoo — archive 1999 https://github.com/nodejs/node/pull/25368Nouvelle recherche | Portail wanayoo
Skip to content

/node

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

src: remove unused isolate variable #25368

Closed
wants to merge 1 commit into from

Conversation

@danbev
Copy link
Member

commented Jan 6, 2019

Currently the following compiler warning is generated:

../src/node_task_queue.cc:93:12: warning:
unused variable 'isolate' [-Wunused-variable]
  Isolate* isolate = env->isolate();
           ^
1 warning generated.

This commit removes the unused variable.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
@danbev
src: remove unused isolate variable 
Currently the following compiler warning is generated:
../src/node_task_queue.cc:93:12: warning:
unused variable 'isolate' [-Wunused-variable]
  Isolate* isolate = env->isolate();
           ^
1 warning generated.

This commit removes the unused variable.
Loading status checks…
5061bdf
@nodejs-github-bot

This comment has been minimized.

Sign in to view
Copy link

commented Jan 6, 2019

@danbev build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/2154/pipeline

@nodejs-github-bot nodejs-github-bot added the C++ label Jan 6, 2019

@danbev

This comment has been minimized.

Sign in to view
Copy link
Member Author

commented Jan 6, 2019

CI: https://ci.nodejs.org/job/node-test-pull-request/19955/
@jasnell
jasnell approved these changes Jan 6, 2019
View changes
@cjihrig
cjihrig approved these changes Jan 6, 2019
View changes
@cjihrig

This comment has been minimized.

Sign in to view
Copy link
Contributor

commented Jan 6, 2019

FWIW, I'm in favor of fast tracking trivial compiler warning fixes like this one.

@danbev danbev added the fast-track label Jan 6, 2019

@danbev

This comment has been minimized.

Sign in to view
Copy link
Member Author

commented Jan 6, 2019

Please +1 for fast tracking.
@addaleax

This comment has been minimized.

Sign in to view
Copy link
Member

commented Jan 6, 2019

Landed in 398916a

@addaleax addaleax closed this Jan 6, 2019

addaleax added a commit that referenced this pull request Jan 6, 2019
@danbev @addaleax
src: remove unused isolate variable 
Currently the following compiler warning is generated:
../src/node_task_queue.cc:93:12: warning:
unused variable 'isolate' [-Wunused-variable]
  Isolate* isolate = env->isolate();
           ^
1 warning generated.

This commit removes the unused variable.

PR-URL: #25368
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Verified
This commit was signed with a verified signature.
addaleax Anna Henningsen
GPG key ID: 9C63F3A6CD2AD8F9 Learn about signing commits
398916a

@danbev danbev deleted the danbev:node_task_unused_var branch Jan 7, 2019

@addaleax addaleax added the backport-requested-v11.x label Jan 9, 2019

@starkwang

This comment has been minimized.

Sign in to view
Copy link
Contributor

commented Jan 9, 2019

This change seems no need to be backported. The removed isolate variable is being used in here:

node/src/bootstrapper.cc

Lines 113 to 129 in 7d46437

void SetupPromises(const FunctionCallbackInfo<Value>& args) {
Environment* env = Environment::GetCurrent(args);
Isolate* isolate = env->isolate();
CHECK(args[0]->IsFunction());
CHECK(args[1]->IsObject());
Local<Object> constants = args[1].As<Object>();
NODE_DEFINE_CONSTANT(constants, kPromiseRejectWithNoHandler);
NODE_DEFINE_CONSTANT(constants, kPromiseHandlerAddedAfterReject);
NODE_DEFINE_CONSTANT(constants, kPromiseResolveAfterResolved);
NODE_DEFINE_CONSTANT(constants, kPromiseRejectAfterResolved);
isolate->SetPromiseRejectCallback(PromiseRejectCallback);
env->set_promise_handler_function(args[0].As<Function>());
}

@starkwang starkwang removed the backport-requested-v11.x label Jan 9, 2019

refack added a commit to refack/node that referenced this pull request Jan 14, 2019
@danbev @refack
src: remove unused isolate variable 
Currently the following compiler warning is generated:
../src/node_task_queue.cc:93:12: warning:
unused variable 'isolate' [-Wunused-variable]
  Isolate* isolate = env->isolate();
           ^
1 warning generated.

This commit removes the unused variable.

PR-URL: nodejs#25368
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
734e482
addaleax added a commit that referenced this pull request Jan 15, 2019
@danbev @addaleax
src: remove unused isolate variable 
Currently the following compiler warning is generated:
../src/node_task_queue.cc:93:12: warning:
unused variable 'isolate' [-Wunused-variable]
  Isolate* isolate = env->isolate();
           ^
1 warning generated.

This commit removes the unused variable.

PR-URL: #25368
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Verified
This commit was signed with a verified signature.
addaleax Anna Henningsen
GPG key ID: 9C63F3A6CD2AD8F9 Learn about signing commits
497a08a
@BridgeAR BridgeAR referenced this pull request Jan 16, 2019
Merged
BridgeAR added a commit to BridgeAR/node that referenced this pull request Jan 16, 2019
@danbev @BridgeAR
src: remove unused isolate variable 
Currently the following compiler warning is generated:
../src/node_task_queue.cc:93:12: warning:
unused variable 'isolate' [-Wunused-variable]
  Isolate* isolate = env->isolate();
           ^
1 warning generated.

This commit removes the unused variable.

PR-URL: nodejs#25368
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Verified
This commit was signed with a verified signature.
BridgeAR Ruben Bridgewater
GPG key ID: F07496B3EB3C1762 Learn about signing commits
7bb31bd
BridgeAR added a commit to BridgeAR/node that referenced this pull request Jan 17, 2019
@danbev @BridgeAR
src: remove unused isolate variable 
Currently the following compiler warning is generated:
../src/node_task_queue.cc:93:12: warning:
unused variable 'isolate' [-Wunused-variable]
  Isolate* isolate = env->isolate();
           ^
1 warning generated.

This commit removes the unused variable.

PR-URL: nodejs#25368
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Verified
This commit was signed with a verified signature.
BridgeAR Ruben Bridgewater
GPG key ID: F07496B3EB3C1762 Learn about signing commits
81924ff
@MylesBorins MylesBorins referenced this pull request Jan 24, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell

@cjihrig cjihrig

Assignees
No one assigned
Labels
C++ fast-track
Projects
None yet
Milestone
No milestone
6 participants
@danbev @nodejs-github-bot @cjihrig @addaleax @starkwang @jasnell
You can’t perform that action at this time.