★ wanayoo — archive 1999 https://github.com/nodejs/node/pull/25367Nouvelle recherche | Portail wanayoo
Skip to content

/node

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: update benchmark doc #25367

Closed
wants to merge 1 commit into from

Conversation

@kkty
Copy link
Contributor

commented Jan 6, 2019

Benchmark for arrays no longer exists, but it was still referenced in
documentation.

Refs: #21831

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines
@kkty
doc: update benchmark doc 
Benchmark for arrays no longer exists, but it was still referenced in
documentation.

Refs: #21831
Loading status checks…
751d1a0

@nodejs-github-bot nodejs-github-bot added benchmark doc labels Jan 6, 2019

@jasnell
jasnell approved these changes Jan 6, 2019
View changes
@cjihrig
cjihrig approved these changes Jan 6, 2019
View changes

@vsemozhetbyt vsemozhetbyt added the author ready label Jan 6, 2019

@vsemozhetbyt

This comment has been minimized.

Sign in to view
Copy link
Contributor

commented Jan 6, 2019

CI-lite: https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/2155/
@lpinca
lpinca approved these changes Jan 6, 2019
View changes
@addaleax
addaleax approved these changes Jan 9, 2019
View changes
@addaleax

This comment has been minimized.

Sign in to view
Copy link
Member

commented Jan 9, 2019

Landed in 9b7226d

@addaleax addaleax closed this Jan 9, 2019

addaleax added a commit that referenced this pull request Jan 9, 2019
@kkty @addaleax
doc: update benchmark doc 
Benchmark for arrays no longer exists, but it was still referenced in
documentation.

Refs: #21831

PR-URL: #25367
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Verified
This commit was signed with a verified signature.
addaleax Anna Henningsen
GPG key ID: 9C63F3A6CD2AD8F9 Learn about signing commits
Loading status checks…
9b7226d
addaleax added a commit that referenced this pull request Jan 9, 2019
@kkty @addaleax
doc: update benchmark doc 
Benchmark for arrays no longer exists, but it was still referenced in
documentation.

Refs: #21831

PR-URL: #25367
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Verified
This commit was signed with a verified signature.
addaleax Anna Henningsen
GPG key ID: 9C63F3A6CD2AD8F9 Learn about signing commits
Loading status checks…
7d46437
@BridgeAR BridgeAR referenced this pull request Jan 16, 2019
Merged
BridgeAR added a commit to BridgeAR/node that referenced this pull request Jan 16, 2019
@kkty @BridgeAR
doc: update benchmark doc 
Benchmark for arrays no longer exists, but it was still referenced in
documentation.

Refs: nodejs#21831

PR-URL: nodejs#25367
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Verified
This commit was signed with a verified signature.
BridgeAR Ruben Bridgewater
GPG key ID: F07496B3EB3C1762 Learn about signing commits
cefd802
@MylesBorins MylesBorins referenced this pull request Jan 24, 2019
Merged
BethGriggs added a commit that referenced this pull request Apr 28, 2019
@kkty @BethGriggs
doc: update benchmark doc 
Benchmark for arrays no longer exists, but it was still referenced in
documentation.

Refs: #21831

PR-URL: #25367
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Verified
This commit was signed with a verified signature.
BethGriggs Bethany Nicolle Griggs
GPG key ID: D7062848A1AB005C Learn about signing commits
Loading status checks…
27f3dba
@BethGriggs BethGriggs referenced this pull request May 1, 2019
Merged
BethGriggs added a commit that referenced this pull request May 10, 2019
@kkty @BethGriggs
doc: update benchmark doc 
Benchmark for arrays no longer exists, but it was still referenced in
documentation.

Refs: #21831

PR-URL: #25367
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Verified
This commit was signed with a verified signature.
BethGriggs Bethany Nicolle Griggs
GPG key ID: D7062848A1AB005C Learn about signing commits
ec10eaf
MylesBorins added a commit that referenced this pull request May 16, 2019
@kkty @MylesBorins
doc: update benchmark doc 
Benchmark for arrays no longer exists, but it was still referenced in
documentation.

Refs: #21831

PR-URL: #25367
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Verified
This commit was signed with a verified signature.
MylesBorins Myles Borins
GPG key ID: 933B01F40B5CA946 Learn about signing commits
b68d47a
This was referenced May 29, 2019
Closed
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell

@addaleax addaleax

@lpinca lpinca

@cjihrig cjihrig

Assignees
No one assigned
Labels
author ready benchmark doc
Projects
None yet
Milestone
No milestone
7 participants
@kkty @vsemozhetbyt @addaleax @jasnell @lpinca @cjihrig @nodejs-github-bot
You can’t perform that action at this time.