★ wanayoo — archive 1999 https://github.com/nodejs/node/pull/25365Nouvelle recherche | Portail wanayoo
Skip to content

/node

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: fix test-benchmark-zlib #25365

Closed
wants to merge 1 commit into from

Conversation

@Trott
Copy link
Member

commented Jan 6, 2019

The addition of brotli to zlib benchmarks means that test-benchmark-zlib
needs to be modified. This is that modification.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
@Trott
test: fix test-benchmark-zlib 
The addition of brotli to zlib benchmarks means that test-benchmark-zlib
needs to be modified. This is that modification.
Loading status checks…
4ef49c7
@nodejs-github-bot

This comment has been minimized.

Sign in to view
Copy link

commented Jan 6, 2019

@Trott build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/2153/pipeline

@nodejs-github-bot nodejs-github-bot added the test label Jan 6, 2019

@Trott

This comment has been minimized.

Sign in to view
Copy link
Member Author

commented Jan 6, 2019

node-daily-master will fail until this change lands, so please 👍 here to fast-track.

@Trott Trott added the fast-track label Jan 6, 2019

@Trott Trott referenced this pull request Jan 6, 2019
Closed
2 of 2 tasks complete
@cjihrig
cjihrig approved these changes Jan 6, 2019
View changes
@jasnell
jasnell approved these changes Jan 6, 2019
View changes
@lpinca
lpinca approved these changes Jan 6, 2019
View changes
@Trott

This comment has been minimized.

Sign in to view
Copy link
Member Author

commented Jan 6, 2019

Landed in 6f27f53

@Trott Trott closed this Jan 6, 2019

Trott added a commit to Trott/io.js that referenced this pull request Jan 6, 2019
@Trott
test: fix test-benchmark-zlib 
The addition of brotli to zlib benchmarks means that test-benchmark-zlib
needs to be modified. This is that modification.

PR-URL: nodejs#25365
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
6f27f53
addaleax added a commit that referenced this pull request Jan 9, 2019
@Trott @addaleax
test: fix test-benchmark-zlib 
The addition of brotli to zlib benchmarks means that test-benchmark-zlib
needs to be modified. This is that modification.

PR-URL: #25365
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Verified
This commit was signed with a verified signature.
addaleax Anna Henningsen
GPG key ID: 9C63F3A6CD2AD8F9 Learn about signing commits
523872b
refack added a commit to refack/node that referenced this pull request Jan 14, 2019
@Trott @refack
test: fix test-benchmark-zlib 
The addition of brotli to zlib benchmarks means that test-benchmark-zlib
needs to be modified. This is that modification.

PR-URL: nodejs#25365
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
1c41672
@BridgeAR BridgeAR referenced this pull request Jan 16, 2019
Merged
BridgeAR added a commit to BridgeAR/node that referenced this pull request Jan 16, 2019
@Trott @BridgeAR
test: fix test-benchmark-zlib 
The addition of brotli to zlib benchmarks means that test-benchmark-zlib
needs to be modified. This is that modification.

PR-URL: nodejs#25365
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Verified
This commit was signed with a verified signature.
BridgeAR Ruben Bridgewater
GPG key ID: F07496B3EB3C1762 Learn about signing commits
e32aacc
@MylesBorins MylesBorins referenced this pull request Jan 24, 2019
Merged
BethGriggs added a commit that referenced this pull request Apr 28, 2019
@Trott @BethGriggs
test: fix test-benchmark-zlib 
The addition of brotli to zlib benchmarks means that test-benchmark-zlib
needs to be modified. This is that modification.

PR-URL: #25365
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Verified
This commit was signed with a verified signature.
BethGriggs Bethany Nicolle Griggs
GPG key ID: D7062848A1AB005C Learn about signing commits
04952fd
@BethGriggs BethGriggs referenced this pull request May 1, 2019
Merged
BethGriggs added a commit that referenced this pull request May 10, 2019
@Trott @BethGriggs
test: fix test-benchmark-zlib 
The addition of brotli to zlib benchmarks means that test-benchmark-zlib
needs to be modified. This is that modification.

PR-URL: #25365
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Verified
This commit was signed with a verified signature.
BethGriggs Bethany Nicolle Griggs
GPG key ID: D7062848A1AB005C Learn about signing commits
413651d
MylesBorins added a commit that referenced this pull request May 16, 2019
@Trott @MylesBorins
test: fix test-benchmark-zlib 
The addition of brotli to zlib benchmarks means that test-benchmark-zlib
needs to be modified. This is that modification.

PR-URL: #25365
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Verified
This commit was signed with a verified signature.
MylesBorins Myles Borins
GPG key ID: 933B01F40B5CA946 Learn about signing commits
acd6915
This was referenced May 29, 2019
Closed
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell

@lpinca lpinca

@cjihrig cjihrig

Assignees
No one assigned
Labels
fast-track test
Projects
None yet
Milestone
No milestone
5 participants
@Trott @nodejs-github-bot @jasnell @lpinca @cjihrig
You can’t perform that action at this time.