★ wanayoo — archive 1999 https://github.com/nodejs/node/pull/25327Nouvelle recherche | Portail wanayoo
Skip to content

/node

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: remove flag for test-addon-uv-handle-leak #25327

Closed
wants to merge 1 commit into from
+2 −2

Conversation

@Trott
Copy link
Member

commented Jan 3, 2019

test-addon-uv-handle-leak only requires worker_threads for the
subprocess which it explicitly calls with --experimental-worker. The
main test itself does not need it. Remove Flags: comment and move
loading of worker_threads into subprocess-only logic.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
@Trott
test: remove flag for test-addon-uv-handle-leak 
test-addon-uv-handle-leak only requires worker_threads for the
subprocess which it explicitly calls with --experimental-worker. The
main test itself does not need it. Remove Flags: comment and move
loading of worker_threads into subprocess-only logic.
Loading status checks…
34ddf8d

@nodejs-github-bot nodejs-github-bot added the test label Jan 3, 2019

@nodejs-github-bot

This comment has been minimized.

Sign in to view
Copy link

commented Jan 3, 2019

@Trott build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/2133/pipeline
@Trott

This comment has been minimized.

Sign in to view
Copy link
Member Author

commented Jan 3, 2019 •
edited

CI: https://ci.nodejs.org/job/node-test-pull-request/19923/ ✅
@cjihrig
cjihrig approved these changes Jan 3, 2019
View changes

@Trott Trott added the author ready label Jan 3, 2019

@lpinca
lpinca approved these changes Jan 3, 2019
View changes
@mhdawson
mhdawson approved these changes Jan 3, 2019
View changes
Copy link
Member

left a comment

LGTM
@watilde
watilde approved these changes Jan 4, 2019
View changes
@jasnell
jasnell approved these changes Jan 4, 2019
View changes
@Trott

This comment has been minimized.

Sign in to view
Copy link
Member Author

commented Jan 6, 2019

Landed in 7ed790e

@Trott Trott closed this Jan 6, 2019

Trott added a commit to Trott/io.js that referenced this pull request Jan 6, 2019
@Trott
test: remove flag for test-addon-uv-handle-leak 
test-addon-uv-handle-leak only requires worker_threads for the
subprocess which it explicitly calls with --experimental-worker. The
main test itself does not need it. Remove Flags: comment and move
loading of worker_threads into subprocess-only logic.

PR-URL: nodejs#25327
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
7ed790e
addaleax added a commit that referenced this pull request Jan 9, 2019
@Trott @addaleax
test: remove flag for test-addon-uv-handle-leak 
test-addon-uv-handle-leak only requires worker_threads for the
subprocess which it explicitly calls with --experimental-worker. The
main test itself does not need it. Remove Flags: comment and move
loading of worker_threads into subprocess-only logic.

PR-URL: #25327
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Verified
This commit was signed with a verified signature.
addaleax Anna Henningsen
GPG key ID: 9C63F3A6CD2AD8F9 Learn about signing commits
456f76a
refack added a commit to refack/node that referenced this pull request Jan 14, 2019
@Trott @refack
test: remove flag for test-addon-uv-handle-leak 
test-addon-uv-handle-leak only requires worker_threads for the
subprocess which it explicitly calls with --experimental-worker. The
main test itself does not need it. Remove Flags: comment and move
loading of worker_threads into subprocess-only logic.

PR-URL: nodejs#25327
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
0089021
@BridgeAR BridgeAR referenced this pull request Jan 16, 2019
Merged
BridgeAR added a commit to BridgeAR/node that referenced this pull request Jan 16, 2019
@Trott @BridgeAR
test: remove flag for test-addon-uv-handle-leak 
test-addon-uv-handle-leak only requires worker_threads for the
subprocess which it explicitly calls with --experimental-worker. The
main test itself does not need it. Remove Flags: comment and move
loading of worker_threads into subprocess-only logic.

PR-URL: nodejs#25327
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Verified
This commit was signed with a verified signature.
BridgeAR Ruben Bridgewater
GPG key ID: F07496B3EB3C1762 Learn about signing commits
fb6d015
@MylesBorins MylesBorins referenced this pull request Jan 24, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell

@lpinca lpinca

@watilde watilde

@cjihrig cjihrig

@mhdawson mhdawson

Assignees
No one assigned
Labels
author ready test
Projects
None yet
Milestone
No milestone
7 participants
@Trott @nodejs-github-bot @jasnell @lpinca @watilde @cjihrig @mhdawson
You can’t perform that action at this time.