test: port encoding WPT into core #25321

joyeecheung · Jan 3, 2019

Note: the test runner does not yet support scanning and running tests under subdirectories, but in the case of encoding it's fine because the subdirectory stream contains tests for Text*CoderStream that we do not support yet.

There are still some tests failing, I've marked them in the test/wpt/status/encoding.json and opened #25315 to track one of the failures.

The first commit, and the biggest one, is generated with git node wpt.

test: pull enconding WPT test fixtures

test: support more icu requirements in the WPT status file

Support small-icu and full-icu requirements, where full-icu
implies small-icu.

test: use WPT runner to run encoding tests

test: remove duplicate encoding tests in favor of WPT

Checklist

make -j4 test (UNIX), or vcbuild test (Windows) passes
commit message follows commit guidelines


      test: pull enconding WPT test fixtures


      test: use WPT runner to run encoding tests


      test: remove duplicate encoding tests in favor of WPT


      test: support more icu requirements in the WPT status file

Support `small-icu` and `full-icu` requirements, where `full-icu`
implies `small-icu`.

nodejs-github-bot · Jan 3, 2019

@joyeecheung build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/2130/pipeline

joyeecheung · Jan 3, 2019

CI: https://ci.nodejs.org/job/node-test-pull-request/19921/

cc @nodejs/intl @nodejs/testing

joyeecheung · Jan 9, 2019

Ping @nodejs/intl @nodejs/testing @jasnell

Trott · 2019-01-09T06:33:38Z

Trott approved these changes

Jan 9, 2019

View changes

RSLGTM if CI is green

joyeecheung · Jan 9, 2019

Fresh CI: https://ci.nodejs.org/job/node-test-pull-request/20019/

jasnell · 2019-01-09T16:58:00Z

jasnell approved these changes

Jan 9, 2019

View changes

jasnell · 2019-01-09T17:11:16Z

jasnell approved these changes

Jan 9, 2019

View changes

BridgeAR · 2019-01-10T02:02:22Z

BridgeAR approved these changes

Jan 10, 2019

View changes

joyeecheung · Jan 10, 2019

Resume: https://ci.nodejs.org/job/node-test-pull-request/20047/

joyeecheung · Jan 10, 2019

Landed in 2d2f82c...dce2f3e


      test: pull enconding WPT test fixtures

PR-URL: #25321
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>


      test: support more icu requirements in the WPT status file

Support `small-icu` and `full-icu` requirements, where `full-icu`
implies `small-icu`.

PR-URL: #25321
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>


      test: use WPT runner to run encoding tests

PR-URL: #25321
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>


      test: remove duplicate encoding tests in favor of WPT

PR-URL: #25321
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>


      test: pull enconding WPT test fixtures

PR-URL: #25321
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>


      test: support more icu requirements in the WPT status file

Support `small-icu` and `full-icu` requirements, where `full-icu`
implies `small-icu`.

PR-URL: #25321
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>


      test: use WPT runner to run encoding tests

PR-URL: #25321
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>


      test: remove duplicate encoding tests in favor of WPT

PR-URL: #25321
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>


      test: pull enconding WPT test fixtures

PR-URL: nodejs#25321
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>


      test: support more icu requirements in the WPT status file

Support `small-icu` and `full-icu` requirements, where `full-icu`
implies `small-icu`.

PR-URL: nodejs#25321
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>


      test: use WPT runner to run encoding tests

PR-URL: nodejs#25321
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>


      test: remove duplicate encoding tests in favor of WPT

PR-URL: nodejs#25321
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>

joyeecheung added 4 commits Dec 4, 2018

test: pull enconding WPT test fixtures

Verified

This commit was signed with a verified signature.

joyeecheung Joyee Cheung

GPG key ID: 92B78A53C8303B8D Learn about signing commits

57abb93

test: use WPT runner to run encoding tests

Verified

This commit was signed with a verified signature.

joyeecheung Joyee Cheung

GPG key ID: 92B78A53C8303B8D Learn about signing commits

e014031

test: remove duplicate encoding tests in favor of WPT

Verified

This commit was signed with a verified signature.

joyeecheung Joyee Cheung

GPG key ID: 92B78A53C8303B8D Learn about signing commits

Loading status checks…

9629778

nodejs-github-bot added the test label Jan 3, 2019

joyeecheung requested a review from jasnell Jan 3, 2019

joyeecheung closed this Jan 10, 2019

joyeecheung added a commit that referenced this pull request Jan 10, 2019

joyeecheung referenced this pull request Jan 10, 2019

[Tracking Issue] Web Platform Tests revamp/update automation #23192

Open

5 of 14 tasks complete

addaleax added a commit that referenced this pull request Jan 14, 2019

BridgeAR referenced this pull request Jan 16, 2019

v11.7.0 proposal #25537

Merged

BridgeAR added a commit to BridgeAR/node that referenced this pull request Jan 16, 2019

MylesBorins referenced this pull request Jan 24, 2019

v11.8.0 proposal #25687

Merged

nodejs/node

test: port encoding WPT into core #25321

test: port encoding WPT into core #25321

joyeecheung commented Jan 3, 2019 •

edited

This comment has been minimized.

nodejs-github-bot commented Jan 3, 2019

nodejs-github-bot added the test label Jan 3, 2019

This comment has been minimized.

joyeecheung commented Jan 3, 2019

joyeecheung requested a review from jasnell Jan 3, 2019

This comment has been minimized.

joyeecheung commented Jan 9, 2019

Trott left a comment

This comment has been minimized.

joyeecheung commented Jan 9, 2019

This comment has been minimized.

joyeecheung commented Jan 10, 2019

This comment has been minimized.

joyeecheung commented Jan 10, 2019

joyeecheung closed this Jan 10, 2019

nodejs/node

Join GitHub today

test: port encoding WPT into core #25321

Conversation

joyeecheung commented Jan 3, 2019 • edited

test: pull enconding WPT test fixtures

test: support more icu requirements in the WPT status file

test: use WPT runner to run encoding tests

test: remove duplicate encoding tests in favor of WPT

Checklist

This comment has been minimized.

nodejs-github-bot commented Jan 3, 2019

nodejs-github-bot added the test label Jan 3, 2019

This comment has been minimized.

joyeecheung commented Jan 3, 2019

joyeecheung requested a review from jasnell Jan 3, 2019

This comment has been minimized.

joyeecheung commented Jan 9, 2019

Trott left a comment

This comment has been minimized.

joyeecheung commented Jan 9, 2019

This comment has been minimized.

joyeecheung commented Jan 10, 2019

This comment has been minimized.

joyeecheung commented Jan 10, 2019

joyeecheung closed this Jan 10, 2019

joyeecheung commented Jan 3, 2019 •

edited