★ wanayoo — archive 1999 https://github.com/nodejs/node/pull/25275Nouvelle recherche | Portail wanayoo
Skip to content

/node

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: remove unused --expose-native-as V8 flag #25275

Closed
wants to merge 1 commit into from
+1 −1

Conversation

@peterwmwong
Copy link
Contributor

commented Dec 29, 2018

test-preload.js was using a V8 flag (--expose-native-as) that made
an V8 internally used object available. As this test does not use this
object, this commit removes the usage of this flag.

In some distant past, this internally used object may have had some
external use, but currently is essentially an empty object.

In the near future, the V8 internal infrastructure (JS Natives)
producing the object exposed by --expose-native-as will be phased out.
For more details, visit:
https://bugs.chromium.org/p/v8/issues/detail?id=7624

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
@peterwmwong
test: remove unused --expose-native-as V8 flag 
test-preload.js was using a V8 flag (`--expose-native-as`) that made
an V8 internally used object available. As this test does not use this
object, this commit removes the usage of this flag.

In some distant past, this internally used object may have had some
external use, but currently is essentially an empty object.

In the near future, the V8 internal infrastructure (JS Natives)
producing the object exposed by `--expose-native-as` will be phased out.
For more details, visit:
https://bugs.chromium.org/p/v8/issues/detail?id=7624
Loading status checks…
326eb60

@nodejs-github-bot nodejs-github-bot added the test label Dec 29, 2018

@addaleax
addaleax approved these changes Dec 30, 2018
View changes
@addaleax

This comment has been minimized.

Sign in to view
Copy link
Member

commented Dec 30, 2018

CI: https://ci.nodejs.org/job/node-test-pull-request/19868/

@addaleax addaleax added the author ready label Dec 30, 2018

@cjihrig
cjihrig approved these changes Dec 31, 2018
View changes
@antsmartian
antsmartian approved these changes Dec 31, 2018
View changes
@peterwmwong

This comment has been minimized.

Sign in to view
Copy link
Contributor Author

commented Jan 2, 2019

Happy New Year! Thanks for the review and approvals!
This is my first PR against Node.js, is there anything needed from me to land this change?

Thanks in advance!
@addaleax

This comment has been minimized.

Sign in to view
Copy link
Member

commented Jan 2, 2019

Landed in 2370bc7 🎉

is there anything needed from me to land this change?

Sometimes posting a comment to the PR helps as a reminder, so, thanks :)

(Generally, once the author ready label is there and everything’s green and wrapped up, you don’t need to do more than possibly wait 48 hours since the PR was first opened, because we don’t usually land PRs before that.)

@addaleax addaleax closed this Jan 2, 2019

addaleax added a commit that referenced this pull request Jan 2, 2019
@peterwmwong @addaleax
test: remove unused --expose-native-as V8 flag 
test-preload.js was using a V8 flag (`--expose-native-as`) that made
an V8 internally used object available. As this test does not use this
object, this commit removes the usage of this flag.

In some distant past, this internally used object may have had some
external use, but currently is essentially an empty object.

In the near future, the V8 internal infrastructure (JS Natives)
producing the object exposed by `--expose-native-as` will be phased out.
For more details, visit:
https://bugs.chromium.org/p/v8/issues/detail?id=7624

PR-URL: #25275
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
Verified
This commit was signed with a verified signature.
addaleax Anna Henningsen
GPG key ID: 9C63F3A6CD2AD8F9 Learn about signing commits
Loading status checks…
2370bc7
@peterwmwong

This comment has been minimized.

Sign in to view
Copy link
Contributor Author

commented Jan 2, 2019

Thank you @addaleax !
addaleax added a commit that referenced this pull request Jan 5, 2019
@peterwmwong @addaleax
test: remove unused --expose-native-as V8 flag 
test-preload.js was using a V8 flag (`--expose-native-as`) that made
an V8 internally used object available. As this test does not use this
object, this commit removes the usage of this flag.

In some distant past, this internally used object may have had some
external use, but currently is essentially an empty object.

In the near future, the V8 internal infrastructure (JS Natives)
producing the object exposed by `--expose-native-as` will be phased out.
For more details, visit:
https://bugs.chromium.org/p/v8/issues/detail?id=7624

PR-URL: #25275
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
Verified
This commit was signed with a verified signature.
addaleax Anna Henningsen
GPG key ID: 9C63F3A6CD2AD8F9 Learn about signing commits
5a5bc58
hashseed added a commit to v8/node that referenced this pull request Jan 7, 2019
@peterwmwong @hashseed
test: remove unused --expose-native-as V8 flag 
test-preload.js was using a V8 flag (`--expose-native-as`) that made
an V8 internally used object available. As this test does not use this
object, this commit removes the usage of this flag.

In some distant past, this internally used object may have had some
external use, but currently is essentially an empty object.

In the near future, the V8 internal infrastructure (JS Natives)
producing the object exposed by `--expose-native-as` will be phased out.
For more details, visit:
https://bugs.chromium.org/p/v8/issues/detail?id=7624

PR-URL: nodejs#25275
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
6022ebd
refack added a commit to refack/node that referenced this pull request Jan 14, 2019
@peterwmwong @refack
test: remove unused --expose-native-as V8 flag 
test-preload.js was using a V8 flag (`--expose-native-as`) that made
an V8 internally used object available. As this test does not use this
object, this commit removes the usage of this flag.

In some distant past, this internally used object may have had some
external use, but currently is essentially an empty object.

In the near future, the V8 internal infrastructure (JS Natives)
producing the object exposed by `--expose-native-as` will be phased out.
For more details, visit:
https://bugs.chromium.org/p/v8/issues/detail?id=7624

PR-URL: nodejs#25275
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
dbd26b4
@BridgeAR BridgeAR referenced this pull request Jan 16, 2019
Merged
BridgeAR added a commit to BridgeAR/node that referenced this pull request Jan 16, 2019
@peterwmwong @BridgeAR
test: remove unused --expose-native-as V8 flag 
test-preload.js was using a V8 flag (`--expose-native-as`) that made
an V8 internally used object available. As this test does not use this
object, this commit removes the usage of this flag.

In some distant past, this internally used object may have had some
external use, but currently is essentially an empty object.

In the near future, the V8 internal infrastructure (JS Natives)
producing the object exposed by `--expose-native-as` will be phased out.
For more details, visit:
https://bugs.chromium.org/p/v8/issues/detail?id=7624

PR-URL: nodejs#25275
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
Verified
This commit was signed with a verified signature.
BridgeAR Ruben Bridgewater
GPG key ID: F07496B3EB3C1762 Learn about signing commits
0ba5508
@MylesBorins MylesBorins referenced this pull request Jan 24, 2019
Merged
BethGriggs added a commit that referenced this pull request Apr 28, 2019
@peterwmwong @BethGriggs
test: remove unused --expose-native-as V8 flag 
test-preload.js was using a V8 flag (`--expose-native-as`) that made
an V8 internally used object available. As this test does not use this
object, this commit removes the usage of this flag.

In some distant past, this internally used object may have had some
external use, but currently is essentially an empty object.

In the near future, the V8 internal infrastructure (JS Natives)
producing the object exposed by `--expose-native-as` will be phased out.
For more details, visit:
https://bugs.chromium.org/p/v8/issues/detail?id=7624

PR-URL: #25275
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
Verified
This commit was signed with a verified signature.
BethGriggs Bethany Nicolle Griggs
GPG key ID: D7062848A1AB005C Learn about signing commits
d28003b
@BethGriggs BethGriggs referenced this pull request May 1, 2019
Merged
BethGriggs added a commit that referenced this pull request May 10, 2019
@peterwmwong @BethGriggs
test: remove unused --expose-native-as V8 flag 
test-preload.js was using a V8 flag (`--expose-native-as`) that made
an V8 internally used object available. As this test does not use this
object, this commit removes the usage of this flag.

In some distant past, this internally used object may have had some
external use, but currently is essentially an empty object.

In the near future, the V8 internal infrastructure (JS Natives)
producing the object exposed by `--expose-native-as` will be phased out.
For more details, visit:
https://bugs.chromium.org/p/v8/issues/detail?id=7624

PR-URL: #25275
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
Verified
This commit was signed with a verified signature.
BethGriggs Bethany Nicolle Griggs
GPG key ID: D7062848A1AB005C Learn about signing commits
a8f934c
MylesBorins added a commit that referenced this pull request May 16, 2019
@peterwmwong @MylesBorins
test: remove unused --expose-native-as V8 flag 
test-preload.js was using a V8 flag (`--expose-native-as`) that made
an V8 internally used object available. As this test does not use this
object, this commit removes the usage of this flag.

In some distant past, this internally used object may have had some
external use, but currently is essentially an empty object.

In the near future, the V8 internal infrastructure (JS Natives)
producing the object exposed by `--expose-native-as` will be phased out.
For more details, visit:
https://bugs.chromium.org/p/v8/issues/detail?id=7624

PR-URL: #25275
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
Verified
This commit was signed with a verified signature.
MylesBorins Myles Borins
GPG key ID: 933B01F40B5CA946 Learn about signing commits
4155b74
This was referenced May 29, 2019
Closed
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@addaleax addaleax

@antsmartian antsmartian

@cjihrig cjihrig

Assignees
No one assigned
Labels
author ready test
Projects
None yet
Milestone
No milestone
5 participants
@peterwmwong @addaleax @antsmartian @cjihrig @nodejs-github-bot
You can’t perform that action at this time.