Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.
Sign updeps: V8: cherry-pick 56f6a76 #25269
Conversation
BridgeAR
requested a review
from
TimothyGu
Dec 29, 2018
This comment has been minimized.
This comment has been minimized.
nodejs-github-bot
added
build
V8 Engine
labels
Dec 29, 2018
TimothyGu
approved these changes
Dec 29, 2018
|
Rubber-stamp LGTM. |
fhinkel
approved these changes
Dec 29, 2018
ryzokuken
approved these changes
Dec 29, 2018
devsnek
approved these changes
Dec 29, 2018
This comment has been minimized.
This comment has been minimized.
|
just as a funny sidenote, we made the same mistake in node core :p #17507 |
mhdawson
approved these changes
Jan 3, 2019
|
Rubber stamp LGTM |
This comment has been minimized.
This comment has been minimized.
jasnell
approved these changes
Jan 8, 2019
BridgeAR
added
the
author ready
label
Jan 9, 2019
This comment has been minimized.
This comment has been minimized.
|
Resumed yellow CI https://ci.nodejs.org/job/node-test-pull-request/20008/ |
danbev
added a commit
that referenced
this pull request
Jan 9, 2019
This comment has been minimized.
This comment has been minimized.
danbev
closed this
Jan 9, 2019
This comment has been minimized.
This comment has been minimized.
|
@BridgeAR This would need a manual backport to v11.x-staging (it applies cleanly but does not compile) |
addaleax
added
the
backport-requested-v11.x
label
Jan 15, 2019
This comment has been minimized.
This comment has been minimized.
|
@addaleax I would like to backport this and it lands cleanly on v11.x but it relies on some other code and I do not know the code base well enough to backport this on my own (see also #25270 (comment)). It would be great if the @nodejs/v8-update could have a look at backporting this. |
targos
added this to Backport requested
in v11.x
Jan 30, 2019
This comment has been minimized.
This comment has been minimized.
This was referenced Apr 23, 2019
This was referenced Apr 23, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
BridgeAR commentedDec 29, 2018
•
edited
Original commit message:
Refs: v8/v8@56f6a76
Fixes: #25268
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes