★ wanayoo — archive 1999 https://github.com/nodejs/node/pull/25262Nouvelle recherche | Portail wanayoo
Skip to content

/node

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

process: move --help and --bash-completeion handling to startExecution #25262

Closed
wants to merge 1 commit into from
+14 −13

Conversation

@joyeecheung
Copy link
Member

commented Dec 29, 2018

Because they are similar to --prof-process and are part of
the execution instead of initialization.
Also move the getOptionValue initialization to top scope and add
comments about the flags.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
@joyeecheung
process: move --help and --bash-completeion handling to startExecution 
Because they are similar to `--prof-process` and are part of
the execution instead of initialization.
Also move the `getOptionValue` initialization to top scope since
it's used everywhere and add comments about the flags.
Verified
This commit was signed with a verified signature.
joyeecheung Joyee Cheung
GPG key ID: 92B78A53C8303B8D Learn about signing commits
Loading status checks…
0648e64
@nodejs-github-bot

This comment has been minimized.

Sign in to view
Copy link

commented Dec 29, 2018

@joyeecheung build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/2100/pipeline
@joyeecheung

This comment has been minimized.

Sign in to view
Copy link
Member Author

commented Dec 29, 2018 •
edited by addaleax

cc @addaleax @danbev

CI: https://ci.nodejs.org/job/node-test-pull-request/19862/ (✔️)
@danbev
danbev approved these changes Dec 29, 2018
View changes
@fhinkel
fhinkel approved these changes Dec 29, 2018
View changes

@joyeecheung joyeecheung added process author ready labels Dec 30, 2018

@addaleax
addaleax approved these changes Dec 30, 2018
View changes
@joyeecheung

This comment has been minimized.

Sign in to view
Copy link
Member Author

commented Dec 31, 2018

Landed in ee12607

@joyeecheung joyeecheung closed this Dec 31, 2018

pull bot pushed a commit to zys-contribs/node that referenced this pull request Dec 31, 2018
@joyeecheung
process: move --help and --bash-completeion handling to startExecution 
Because they are similar to `--prof-process` and are part of
the execution instead of initialization.
Also move the `getOptionValue` initialization to top scope since
it's used everywhere and add comments about the flags.

PR-URL: nodejs#25262
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Verified
This commit was signed with a verified signature.
joyeecheung Joyee Cheung
GPG key ID: 92B78A53C8303B8D Learn about signing commits
Loading status checks…
ee12607

@addaleax addaleax added the backport-requested-v11.x label Jan 5, 2019

@addaleax

This comment has been minimized.

Sign in to view
Copy link
Member

commented Jan 5, 2019

Should this be backported to v11.x-staging? If yes please follow the guide and raise a backport PR, if not let me know or add the dont-land-on label.

@BridgeAR BridgeAR added this to Backport requested in v11.x Jan 10, 2019

refack added a commit to refack/node that referenced this pull request Jan 14, 2019
@joyeecheung @refack
process: move --help and --bash-completeion handling to startExecution 
Because they are similar to `--prof-process` and are part of
the execution instead of initialization.
Also move the `getOptionValue` initialization to top scope since
it's used everywhere and add comments about the flags.

PR-URL: nodejs#25262
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
0183570
@addaleax

This comment has been minimized.

Sign in to view
Copy link
Member

commented Jan 15, 2019

This applies cleanly now :)
addaleax added a commit that referenced this pull request Jan 15, 2019
@joyeecheung @addaleax
process: move --help and --bash-completeion handling to startExecution 
Because they are similar to `--prof-process` and are part of
the execution instead of initialization.
Also move the `getOptionValue` initialization to top scope since
it's used everywhere and add comments about the flags.

PR-URL: #25262
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Verified
This commit was signed with a verified signature.
addaleax Anna Henningsen
GPG key ID: 9C63F3A6CD2AD8F9 Learn about signing commits
Loading status checks…
59b5e77

@addaleax addaleax removed the backport-requested-v11.x label Jan 15, 2019

@BridgeAR BridgeAR referenced this pull request Jan 16, 2019
Merged
BridgeAR added a commit to BridgeAR/node that referenced this pull request Jan 16, 2019
@joyeecheung @BridgeAR
process: move --help and --bash-completeion handling to startExecution 
Because they are similar to `--prof-process` and are part of
the execution instead of initialization.
Also move the `getOptionValue` initialization to top scope since
it's used everywhere and add comments about the flags.

PR-URL: nodejs#25262
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Verified
This commit was signed with a verified signature.
BridgeAR Ruben Bridgewater
GPG key ID: F07496B3EB3C1762 Learn about signing commits
3befd53
BridgeAR added a commit to BridgeAR/node that referenced this pull request Jan 17, 2019
@joyeecheung @BridgeAR
process: move --help and --bash-completeion handling to startExecution 
Because they are similar to `--prof-process` and are part of
the execution instead of initialization.
Also move the `getOptionValue` initialization to top scope since
it's used everywhere and add comments about the flags.

PR-URL: nodejs#25262
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Verified
This commit was signed with a verified signature.
BridgeAR Ruben Bridgewater
GPG key ID: F07496B3EB3C1762 Learn about signing commits
5eada9d
@MylesBorins MylesBorins referenced this pull request Jan 24, 2019
Merged

@targos targos removed this from Backport requested in v11.x Jan 30, 2019

@BethGriggs BethGriggs added the backport-requested-v10.x label Jul 2, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fhinkel fhinkel

@danbev danbev

@addaleax addaleax

Assignees
No one assigned
Labels
author ready backport-requested-v10.x process
Projects
None yet
Milestone
No milestone
6 participants
@joyeecheung @nodejs-github-bot @addaleax @fhinkel @danbev @BethGriggs
You can’t perform that action at this time.