★ wanayoo — archive 1999 https://github.com/nodejs/node/pull/25207Nouvelle recherche | Portail wanayoo
Skip to content

/node

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

src: introduce DCHECK macro and use DCHECK* macros where possible #25207

Merged
merged 2 commits into from Dec 26, 2018

Conversation

@cjihrig
Copy link
Contributor

commented Dec 24, 2018

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
@nodejs-github-bot

This comment has been minimized.

Sign in to view
Copy link

commented Dec 24, 2018

@cjihrig build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/2059/pipeline

@nodejs-github-bot nodejs-github-bot added C++ lib / src labels Dec 24, 2018

@targos
targos approved these changes Dec 24, 2018
View changes
@addaleax
addaleax approved these changes Dec 24, 2018
View changes
@BridgeAR
BridgeAR approved these changes Dec 24, 2018
View changes
@tniessen
tniessen approved these changes Dec 25, 2018
View changes
@lpinca
lpinca approved these changes Dec 25, 2018
View changes
@addaleax

This comment has been minimized.

Sign in to view
Copy link
Member

commented Dec 26, 2018

CI: https://ci.nodejs.org/job/node-test-pull-request/19814/

@addaleax addaleax added the author ready label Dec 26, 2018

@Trott

This comment has been minimized.

Sign in to view
Copy link
Member

commented Dec 26, 2018

Resume Build CI: https://ci.nodejs.org/job/node-test-pull-request/19821/
@cjihrig

This comment has been minimized.

Sign in to view
Copy link
Contributor Author

commented Dec 26, 2018

CI had one failure (#21451) and will be fixed by #25226.
cjihrig added 2 commits Dec 24, 2018
@cjihrig
src: use DCHECK_* macros where possible 
PR-URL: #25207
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Verified
This commit was signed with a verified signature.
cjihrig Colin Ihrig
GPG key ID: 7434390BDBE9B9C5 Learn about signing commits
c2b4269
@cjihrig
src: introduce DCHECK macro 
This commit adds a DCHECK macro for consistency with the
other DCHECK_* macros.

PR-URL: #25207
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Verified
This commit was signed with a verified signature.
cjihrig Colin Ihrig
GPG key ID: 7434390BDBE9B9C5 Learn about signing commits
Loading status checks…
4e31a7f

@cjihrig cjihrig force-pushed the cjihrig:check branch from 7252ffb to 4e31a7f Dec 26, 2018

@cjihrig cjihrig merged commit 4e31a7f into nodejs:master Dec 26, 2018
0 of 2 checks passed

0 of 2 checks passed

Travis CI - Pull Request Build Errored
Details
Travis CI - Branch Build Failed
Details

@cjihrig cjihrig deleted the cjihrig:check branch Dec 26, 2018

@cjihrig cjihrig referenced this pull request Dec 26, 2018
Closed
2 of 2 tasks complete
targos added a commit that referenced this pull request Jan 1, 2019
@cjihrig @targos
src: use DCHECK_* macros where possible 
PR-URL: #25207
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Verified
This commit was signed with a verified signature.
targos Michaël Zasso
GPG key ID: 770F7A9A5AE15600 Learn about signing commits
e2a01ca
targos added a commit that referenced this pull request Jan 1, 2019
@cjihrig @targos
src: introduce DCHECK macro 
This commit adds a DCHECK macro for consistency with the
other DCHECK_* macros.

PR-URL: #25207
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Verified
This commit was signed with a verified signature.
targos Michaël Zasso
GPG key ID: 770F7A9A5AE15600 Learn about signing commits
99a5af6
refack added a commit to refack/node that referenced this pull request Jan 14, 2019
@cjihrig @refack
src: use DCHECK_* macros where possible 
PR-URL: nodejs#25207
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
26a507e
refack added a commit to refack/node that referenced this pull request Jan 14, 2019
@cjihrig @refack
src: introduce DCHECK macro 
This commit adds a DCHECK macro for consistency with the
other DCHECK_* macros.

PR-URL: nodejs#25207
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
b899aee
@BridgeAR BridgeAR referenced this pull request Jan 16, 2019
Merged
@MylesBorins MylesBorins referenced this pull request Jan 24, 2019
Merged

@BethGriggs BethGriggs added the backport-requested-v10.x label Jul 2, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@addaleax addaleax

@lpinca lpinca

@targos targos

@tniessen tniessen

@BridgeAR BridgeAR

Assignees
No one assigned
Labels
C++ author ready backport-requested-v10.x lib / src
Projects
None yet
Milestone
No milestone
9 participants
@cjihrig @nodejs-github-bot @addaleax @Trott @lpinca @targos @tniessen @BridgeAR @BethGriggs
You can’t perform that action at this time.