★ wanayoo — archive 1999 https://github.com/nodejs/node/pull/25169Nouvelle recherche | Portail wanayoo
Skip to content

/node

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: refactor stdio handling in test-esm-cjs-main #25169

Closed
wants to merge 1 commit into from

Conversation

@richardlau
Copy link
Member

commented Dec 21, 2018

Set encoding on the stderr/stdout streams instead of calling
data.toString(). Don't assume the complete expected messages arrive in
a single event.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
@richardlau
test: refactor stdio handling in test-esm-cjs-main 
Set encoding on the stderr/stdout streams instead of calling
data.toString(). Don't assume the complete expected messages arrive in
a single event.
Loading status checks…
3e226f1
@nodejs-github-bot

This comment has been minimized.

Sign in to view
Copy link

commented Dec 21, 2018

@richardlau build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/2029/pipeline

@nodejs-github-bot nodejs-github-bot added the test label Dec 21, 2018

@richardlau

This comment has been minimized.

Sign in to view
Copy link
Member Author

commented Dec 21, 2018

CI: https://ci.nodejs.org/job/node-test-pull-request/19723/
@cjihrig
cjihrig approved these changes Dec 21, 2018
View changes
@richardlau

This comment has been minimized.

Sign in to view
Copy link
Member Author

commented Dec 22, 2018

Resume CI: https://ci.nodejs.org/job/node-test-pull-request/19735/

@richardlau richardlau added the author ready label Dec 22, 2018

@danbev
danbev approved these changes Dec 27, 2018
View changes
danbev added a commit to danbev/node that referenced this pull request Dec 27, 2018
@richardlau @danbev
test: refactor stdio handling in test-esm-cjs-main 
Set encoding on the stderr/stdout streams instead of calling
data.toString(). Don't assume the complete expected messages arrive in
a single event.

PR-URL: nodejs#25169
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
67b724f
@danbev

This comment has been minimized.

Sign in to view
Copy link
Member

commented Dec 27, 2018

Landed in 67b724f.

@danbev danbev closed this Dec 27, 2018

targos added a commit that referenced this pull request Jan 1, 2019
@richardlau @targos
test: refactor stdio handling in test-esm-cjs-main 
Set encoding on the stderr/stdout streams instead of calling
data.toString(). Don't assume the complete expected messages arrive in
a single event.

PR-URL: #25169
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Verified
This commit was signed with a verified signature.
targos Michaël Zasso
GPG key ID: 770F7A9A5AE15600 Learn about signing commits
58af085
refack added a commit to refack/node that referenced this pull request Jan 14, 2019
@richardlau @refack
test: refactor stdio handling in test-esm-cjs-main 
Set encoding on the stderr/stdout streams instead of calling
data.toString(). Don't assume the complete expected messages arrive in
a single event.

PR-URL: nodejs#25169
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
370d23f
@BridgeAR BridgeAR referenced this pull request Jan 16, 2019
Merged
@MylesBorins MylesBorins referenced this pull request Jan 24, 2019
Merged
BethGriggs added a commit that referenced this pull request Apr 17, 2019
@richardlau @BethGriggs
test: refactor stdio handling in test-esm-cjs-main 
Set encoding on the stderr/stdout streams instead of calling
data.toString(). Don't assume the complete expected messages arrive in
a single event.

PR-URL: #25169
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Verified
This commit was signed with a verified signature.
BethGriggs Bethany Nicolle Griggs
GPG key ID: D7062848A1AB005C Learn about signing commits
6e74d01
BethGriggs added a commit that referenced this pull request Apr 28, 2019
@richardlau @BethGriggs
test: refactor stdio handling in test-esm-cjs-main 
Set encoding on the stderr/stdout streams instead of calling
data.toString(). Don't assume the complete expected messages arrive in
a single event.

PR-URL: #25169
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Verified
This commit was signed with a verified signature.
BethGriggs Bethany Nicolle Griggs
GPG key ID: D7062848A1AB005C Learn about signing commits
bccb521
@BethGriggs BethGriggs referenced this pull request May 1, 2019
Merged
BethGriggs added a commit that referenced this pull request May 10, 2019
@richardlau @BethGriggs
test: refactor stdio handling in test-esm-cjs-main 
Set encoding on the stderr/stdout streams instead of calling
data.toString(). Don't assume the complete expected messages arrive in
a single event.

PR-URL: #25169
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Verified
This commit was signed with a verified signature.
BethGriggs Bethany Nicolle Griggs
GPG key ID: D7062848A1AB005C Learn about signing commits
2b24fc4
MylesBorins added a commit that referenced this pull request May 16, 2019
@richardlau @MylesBorins
test: refactor stdio handling in test-esm-cjs-main 
Set encoding on the stderr/stdout streams instead of calling
data.toString(). Don't assume the complete expected messages arrive in
a single event.

PR-URL: #25169
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Verified
This commit was signed with a verified signature.
MylesBorins Myles Borins
GPG key ID: 933B01F40B5CA946 Learn about signing commits
19ed5c7
This was referenced May 29, 2019
Closed
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danbev danbev

@cjihrig cjihrig

Assignees
No one assigned
Labels
author ready test
Projects
None yet
Milestone
No milestone
4 participants
@richardlau @nodejs-github-bot @danbev @cjihrig
You can’t perform that action at this time.