★ wanayoo — archive 1999 https://github.com/nodejs/node/pull/25162Nouvelle recherche | Portail wanayoo
Skip to content

/node

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

util: simplify code #25162

Closed
wants to merge 1 commit into from

Conversation

@kkty
Copy link
Contributor

commented Dec 21, 2018

Simplify code by using return value of Object.defineProperty directly.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
@kkty
util: simplify code 
Simplify code by using return value of Object.defineProperty directly.
Loading status checks…
2695419

@nodejs-github-bot nodejs-github-bot added the util label Dec 21, 2018

@vdeturckheim
vdeturckheim approved these changes Dec 21, 2018
View changes
@shisama
shisama approved these changes Dec 22, 2018
View changes
@jasnell
jasnell approved these changes Dec 27, 2018
View changes
@shisama

This comment has been minimized.

Sign in to view
Copy link
Contributor

commented Dec 27, 2018

CI: https://ci.nodejs.org/job/node-test-pull-request/19840/
@tniessen
tniessen approved these changes Dec 27, 2018
View changes
@BridgeAR
BridgeAR approved these changes Dec 27, 2018
View changes
BridgeAR added a commit to BridgeAR/node that referenced this pull request Dec 27, 2018
@kkty @BridgeAR
util: simplify code 
Simplify code by using return value of Object.defineProperty directly.

PR-URL: nodejs#25162
Reviewed-By: Vladimir de Turckheim <vlad2t@hotmail.com>
Reviewed-By: Masashi Hirano <shisama07@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Verified
This commit was signed with a verified signature.
BridgeAR Ruben Bridgewater
GPG key ID: F07496B3EB3C1762 Learn about signing commits
455bcca
@BridgeAR

This comment has been minimized.

Sign in to view
Copy link
Member

commented Dec 27, 2018

Landed in 455bcca.

@kkty congratulations on your first commit to Node.js! 🎉

@BridgeAR BridgeAR closed this Dec 27, 2018

targos added a commit that referenced this pull request Jan 1, 2019
@kkty @targos
util: simplify code 
Simplify code by using return value of Object.defineProperty directly.

PR-URL: #25162
Reviewed-By: Vladimir de Turckheim <vlad2t@hotmail.com>
Reviewed-By: Masashi Hirano <shisama07@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Verified
This commit was signed with a verified signature.
targos Michaël Zasso
GPG key ID: 770F7A9A5AE15600 Learn about signing commits
88e7386
refack added a commit to refack/node that referenced this pull request Jan 14, 2019
@kkty @refack
util: simplify code 
Simplify code by using return value of Object.defineProperty directly.

PR-URL: nodejs#25162
Reviewed-By: Vladimir de Turckheim <vlad2t@hotmail.com>
Reviewed-By: Masashi Hirano <shisama07@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
de8adce
@BridgeAR BridgeAR referenced this pull request Jan 16, 2019
Merged
@MylesBorins MylesBorins referenced this pull request Jan 24, 2019
Merged
BethGriggs added a commit that referenced this pull request Apr 17, 2019
@kkty @BethGriggs
util: simplify code 
Simplify code by using return value of Object.defineProperty directly.

PR-URL: #25162
Reviewed-By: Vladimir de Turckheim <vlad2t@hotmail.com>
Reviewed-By: Masashi Hirano <shisama07@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Verified
This commit was signed with a verified signature.
BethGriggs Bethany Nicolle Griggs
GPG key ID: D7062848A1AB005C Learn about signing commits
62f0659
BethGriggs added a commit that referenced this pull request Apr 28, 2019
@kkty @BethGriggs
util: simplify code 
Simplify code by using return value of Object.defineProperty directly.

PR-URL: #25162
Reviewed-By: Vladimir de Turckheim <vlad2t@hotmail.com>
Reviewed-By: Masashi Hirano <shisama07@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Verified
This commit was signed with a verified signature.
BethGriggs Bethany Nicolle Griggs
GPG key ID: D7062848A1AB005C Learn about signing commits
6d7c2d3
@BethGriggs BethGriggs referenced this pull request May 1, 2019
Merged
BethGriggs added a commit that referenced this pull request May 10, 2019
@kkty @BethGriggs
util: simplify code 
Simplify code by using return value of Object.defineProperty directly.

PR-URL: #25162
Reviewed-By: Vladimir de Turckheim <vlad2t@hotmail.com>
Reviewed-By: Masashi Hirano <shisama07@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Verified
This commit was signed with a verified signature.
BethGriggs Bethany Nicolle Griggs
GPG key ID: D7062848A1AB005C Learn about signing commits
3f155bf
MylesBorins added a commit that referenced this pull request May 16, 2019
@kkty @MylesBorins
util: simplify code 
Simplify code by using return value of Object.defineProperty directly.

PR-URL: #25162
Reviewed-By: Vladimir de Turckheim <vlad2t@hotmail.com>
Reviewed-By: Masashi Hirano <shisama07@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Verified
This commit was signed with a verified signature.
MylesBorins Myles Borins
GPG key ID: 933B01F40B5CA946 Learn about signing commits
5dd31bc
This was referenced May 29, 2019
Closed
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell

@tniessen tniessen

@vdeturckheim vdeturckheim

@BridgeAR BridgeAR

@shisama shisama

Assignees
No one assigned
Labels
util
Projects
None yet
Milestone
No milestone
7 participants
@kkty @shisama @BridgeAR @jasnell @tniessen @vdeturckheim @nodejs-github-bot
You can’t perform that action at this time.