★ wanayoo — archive 1999 https://github.com/nodejs/node/pull/25139Nouvelle recherche | Portail wanayoo
Skip to content

/node

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

src: remove unused variable from string_search.h #25139

Closed
wants to merge 1 commit into from

Conversation

Reviewers

@jasnell jasnell

@lpinca lpinca

@cjihrig cjihrig

@joyeecheung joyeecheung

@richardlau richardlau

Assignees
No one assigned
Labels
C++ author ready buffer
Projects
None yet
Milestone
No milestone
8 participants
@addaleax @nodejs-github-bot @Trott @jasnell @lpinca @cjihrig @joyeecheung @richardlau
@addaleax
Copy link
Member

commented Dec 19, 2018

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
@addaleax
src: remove unused variable from string_search.h
Verified
This commit was signed with a verified signature.
@addaleax addaleax Anna Henningsen
GPG key ID: 9C63F3A6CD2AD8F9 Learn about signing commits
Loading status checks…
9d195a7
@nodejs-github-bot

@nodejs-github-bot nodejs-github-bot added buffer C++ labels Dec 19, 2018

@cjihrig

cjihrig approved these changes Dec 19, 2018
View changes

@joyeecheung

joyeecheung approved these changes Dec 19, 2018
View changes

@richardlau

richardlau approved these changes Dec 20, 2018
View changes

@jasnell

jasnell approved these changes Dec 20, 2018
View changes

@lpinca

lpinca approved these changes Dec 20, 2018
View changes

@addaleax

This comment has been minimized.

Sign in to view
Copy link
Member Author

commented Dec 27, 2018

CI: https://ci.nodejs.org/job/node-test-pull-request/19832/

@addaleax addaleax added the author ready label Dec 27, 2018

@addaleax

This comment has been minimized.

Sign in to view
Copy link
Member Author

commented Dec 30, 2018

Resume CI: https://ci.nodejs.org/job/node-test-pull-request/19878/
@addaleax

This comment has been minimized.

Sign in to view
Copy link
Member Author

commented Dec 31, 2018 •
edited by Trott

Resume CI again: https://ci.nodejs.org/job/node-test-pull-request/19880/ ✅
@Trott

This comment has been minimized.

Sign in to view
Copy link
Member

commented Dec 31, 2018

Landed in da13c44

@Trott Trott closed this Dec 31, 2018

Trott added a commit to Trott/io.js that referenced this pull request Dec 31, 2018

@addaleax @Trott
src: remove unused variable from string_search.h 
PR-URL: nodejs#25139
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
da13c44

targos added a commit that referenced this pull request Jan 1, 2019

@addaleax @targos
src: remove unused variable from string_search.h 
PR-URL: #25139
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Verified
This commit was signed with a verified signature.
@targos targos Michaël Zasso
GPG key ID: 770F7A9A5AE15600 Learn about signing commits
2f5c8b5

refack added a commit to refack/node that referenced this pull request Jan 14, 2019

Anna Henningsen @refack
src: remove unused variable from string_search.h 
PR-URL: nodejs#25139
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
5e8d23d

@BridgeAR BridgeAR referenced this pull request Jan 16, 2019

Merged

v11.7.0 proposal #25537

@MylesBorins MylesBorins referenced this pull request Jan 24, 2019

Merged

v11.8.0 proposal #25687

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.