★ wanayoo — archive 1999 https://github.com/nodejs/node/pull/25126Nouvelle recherche | Portail wanayoo
Skip to content

/node

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: mark sequential/test-inspector-debug-end and parallel/test-child-process-execfile as flaky #25126

Closed
wants to merge 1 commit into from

Conversation

@gireeshpunathil
Copy link
Member

commented Dec 19, 2018

Off late this has been failing in AIX. Debugging core dump
suggested that this is a side effect of exit-race that is
described in #25007
Mart it as flaky in AIX until that is resolved.

Refs: #25047

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
@nodejs-github-bot

This comment has been minimized.

Sign in to view
Copy link

commented Dec 19, 2018

@gireeshpunathil build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/2001/pipeline

@nodejs-github-bot nodejs-github-bot added the test label Dec 19, 2018

@gireeshpunathil gireeshpunathil requested a review from Trott Dec 19, 2018

@gireeshpunathil gireeshpunathil added the aix label Dec 19, 2018

@joyeecheung
joyeecheung approved these changes Dec 19, 2018
View changes
@gireeshpunathil
test: mark two tests as flaky in AIX 
sequential/test-inspector-debug-end and
parallel/test-child-process-execfile

Off late these have been failing in AIX. Debugging core dump
suggested that this is a side effect of exit-race that is
described in #25007
Mart these  as flaky in AIX until that is resolved.

Refs: #25047
Refs: #25029
Loading status checks…
c1ca1f4

@gireeshpunathil gireeshpunathil force-pushed the gireeshpunathil:aix_flake branch from 364e919 to c1ca1f4 Dec 19, 2018

@gireeshpunathil

This comment has been minimized.

Sign in to view
Copy link
Member Author

commented Dec 19, 2018

added an entry for the issue pertinent to #25029 as well, in this.

@gireeshpunathil gireeshpunathil changed the title test: mark sequential/test-inspector-debug-end as flaky test: mark sequential/test-inspector-debug-end and parallel/test-child-process-execfile as flaky Dec 19, 2018

@gireeshpunathil

This comment has been minimized.

Sign in to view
Copy link
Member Author

commented Dec 27, 2018

One week with a single approval, contemplating to land.

CI: https://ci.nodejs.org/job/node-test-pull-request/19829/

@gireeshpunathil gireeshpunathil added the author ready label Dec 27, 2018

@jasnell
jasnell approved these changes Dec 27, 2018
View changes
@gireeshpunathil

This comment has been minimized.

Sign in to view
Copy link
Member Author

commented Dec 28, 2018

Resume Build CI: https://ci.nodejs.org/job/node-test-pull-request/19849/
@gireeshpunathil

This comment has been minimized.

Sign in to view
Copy link
Member Author

commented Dec 28, 2018

landed as 7a867b8

@gireeshpunathil gireeshpunathil closed this Dec 28, 2018

gireeshpunathil added a commit that referenced this pull request Dec 28, 2018
@gireeshpunathil
test: mark two tests as flaky in AIX 
sequential/test-inspector-debug-end and
parallel/test-child-process-execfile

Off late these have been failing in AIX. Debugging core dump
suggested that this is a side effect of exit-race that is
described in #25007
Mart these  as flaky in AIX until that is resolved.

Refs: #25047
Refs: #25029

PR-URL: #25126
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Loading status checks…
7a867b8
targos added a commit that referenced this pull request Jan 1, 2019
@gireeshpunathil @targos
test: mark two tests as flaky in AIX 
sequential/test-inspector-debug-end and
parallel/test-child-process-execfile

Off late these have been failing in AIX. Debugging core dump
suggested that this is a side effect of exit-race that is
described in #25007
Mart these  as flaky in AIX until that is resolved.

Refs: #25047
Refs: #25029

PR-URL: #25126
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Verified
This commit was signed with a verified signature.
targos Michaël Zasso
GPG key ID: 770F7A9A5AE15600 Learn about signing commits
7e2ae75
refack added a commit to refack/node that referenced this pull request Jan 14, 2019
@gireeshpunathil @refack
test: mark two tests as flaky in AIX 
sequential/test-inspector-debug-end and
parallel/test-child-process-execfile

Off late these have been failing in AIX. Debugging core dump
suggested that this is a side effect of exit-race that is
described in nodejs#25007
Mart these  as flaky in AIX until that is resolved.

Refs: nodejs#25047
Refs: nodejs#25029

PR-URL: nodejs#25126
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
5a4fa54
@BridgeAR BridgeAR referenced this pull request Jan 16, 2019
Merged
@MylesBorins MylesBorins referenced this pull request Jan 24, 2019
Merged
BethGriggs added a commit that referenced this pull request Apr 17, 2019
@gireeshpunathil @BethGriggs
test: mark two tests as flaky in AIX 
sequential/test-inspector-debug-end and
parallel/test-child-process-execfile

Off late these have been failing in AIX. Debugging core dump
suggested that this is a side effect of exit-race that is
described in #25007
Mart these  as flaky in AIX until that is resolved.

Refs: #25047
Refs: #25029

PR-URL: #25126
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Verified
This commit was signed with a verified signature.
BethGriggs Bethany Nicolle Griggs
GPG key ID: D7062848A1AB005C Learn about signing commits
90e0ae5
BethGriggs added a commit that referenced this pull request Apr 28, 2019
@gireeshpunathil @BethGriggs
test: mark two tests as flaky in AIX 
sequential/test-inspector-debug-end and
parallel/test-child-process-execfile

Off late these have been failing in AIX. Debugging core dump
suggested that this is a side effect of exit-race that is
described in #25007
Mart these  as flaky in AIX until that is resolved.

Refs: #25047
Refs: #25029

PR-URL: #25126
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Verified
This commit was signed with a verified signature.
BethGriggs Bethany Nicolle Griggs
GPG key ID: D7062848A1AB005C Learn about signing commits
b8efc9d
@BethGriggs BethGriggs referenced this pull request May 1, 2019
Merged
BethGriggs added a commit that referenced this pull request May 10, 2019
@gireeshpunathil @BethGriggs
test: mark two tests as flaky in AIX 
sequential/test-inspector-debug-end and
parallel/test-child-process-execfile

Off late these have been failing in AIX. Debugging core dump
suggested that this is a side effect of exit-race that is
described in #25007
Mart these  as flaky in AIX until that is resolved.

Refs: #25047
Refs: #25029

PR-URL: #25126
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Verified
This commit was signed with a verified signature.
BethGriggs Bethany Nicolle Griggs
GPG key ID: D7062848A1AB005C Learn about signing commits
e33cf1d
MylesBorins added a commit that referenced this pull request May 16, 2019
@gireeshpunathil @MylesBorins
test: mark two tests as flaky in AIX 
sequential/test-inspector-debug-end and
parallel/test-child-process-execfile

Off late these have been failing in AIX. Debugging core dump
suggested that this is a side effect of exit-race that is
described in #25007
Mart these  as flaky in AIX until that is resolved.

Refs: #25047
Refs: #25029

PR-URL: #25126
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Verified
This commit was signed with a verified signature.
MylesBorins Myles Borins
GPG key ID: 933B01F40B5CA946 Learn about signing commits
0fe72b8
This was referenced May 29, 2019
Closed
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell

@joyeecheung joyeecheung

@Trott Trott

Assignees
No one assigned
Labels
aix author ready test
Projects
None yet
Milestone
No milestone
4 participants
@gireeshpunathil @nodejs-github-bot @jasnell @joyeecheung
You can’t perform that action at this time.