★ wanayoo — archive 1999 https://github.com/nodejs/node/pull/25108Nouvelle recherche | Portail wanayoo
Skip to content

/node

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

win, build: fix building addons on Windows #25108

Closed
wants to merge 1 commit into from

Conversation

@bzoz
Copy link
Contributor

commented Dec 18, 2018

Building addons would fail because addon-verify.js dependencies from
tools\doc where not installed. This fixes this issue by installing
those dependencies if addons are to be built.

Fixes: #25096

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
@bzoz
win, build: fix building addons on Windows 
Building addons would fail because addon-verify.js dependencies from
tools\doc where not installed. This fixes this issue by installing
those dependencies if addons are to be built.

Fixes: #25096
Loading status checks…
64d5574
@nodejs-github-bot

This comment has been minimized.

Sign in to view
Copy link

commented Dec 18, 2018

@bzoz build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/1992/pipeline

@nodejs-github-bot nodejs-github-bot added build windows labels Dec 18, 2018

@bzoz

This comment has been minimized.

Sign in to view
Copy link
Contributor Author

commented Dec 18, 2018 •
edited by Trott

CI: https://ci.nodejs.org/job/node-test-pull-request/19656/ ✔️
@bzoz bzoz referenced this pull request Dec 18, 2018
Closed
@bzoz

This comment has been minimized.

Sign in to view
Copy link
Contributor Author

commented Dec 20, 2018

cc @nodejs/platform-windows @nodejs/build-files
@BridgeAR
BridgeAR approved these changes Dec 20, 2018
View changes

@BridgeAR BridgeAR added the author ready label Dec 20, 2018

@addaleax

This comment has been minimized.

Sign in to view
Copy link
Member

commented Dec 31, 2018

Landed in 571273a

@addaleax addaleax closed this Dec 31, 2018

addaleax added a commit that referenced this pull request Dec 31, 2018
@bzoz @addaleax
win, build: fix building addons on Windows 
Building addons would fail because addon-verify.js dependencies from
tools\doc where not installed. This fixes this issue by installing
those dependencies if addons are to be built.

Fixes: #25096

PR-URL: #25108
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Verified
This commit was signed with a verified signature.
addaleax Anna Henningsen
GPG key ID: 9C63F3A6CD2AD8F9 Learn about signing commits
Loading status checks…
571273a
targos added a commit that referenced this pull request Jan 1, 2019
@bzoz @targos
win, build: fix building addons on Windows 
Building addons would fail because addon-verify.js dependencies from
tools\doc where not installed. This fixes this issue by installing
those dependencies if addons are to be built.

Fixes: #25096

PR-URL: #25108
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Verified
This commit was signed with a verified signature.
targos Michaël Zasso
GPG key ID: 770F7A9A5AE15600 Learn about signing commits
2df0d14
refack added a commit to refack/node that referenced this pull request Jan 14, 2019
@bzoz @refack
win, build: fix building addons on Windows 
Building addons would fail because addon-verify.js dependencies from
tools\doc where not installed. This fixes this issue by installing
those dependencies if addons are to be built.

Fixes: nodejs#25096

PR-URL: nodejs#25108
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
f23139f
@BridgeAR BridgeAR referenced this pull request Jan 16, 2019
Merged
@MylesBorins MylesBorins referenced this pull request Jan 24, 2019
Merged
BethGriggs added a commit that referenced this pull request Apr 28, 2019
@bzoz @BethGriggs
win, build: fix building addons on Windows 
Building addons would fail because addon-verify.js dependencies from
tools\doc where not installed. This fixes this issue by installing
those dependencies if addons are to be built.

Fixes: #25096

PR-URL: #25108
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Verified
This commit was signed with a verified signature.
BethGriggs Bethany Nicolle Griggs
GPG key ID: D7062848A1AB005C Learn about signing commits
9af9ee5
@BethGriggs BethGriggs referenced this pull request May 1, 2019
Merged
BethGriggs added a commit that referenced this pull request May 10, 2019
@bzoz @BethGriggs
win, build: fix building addons on Windows 
Building addons would fail because addon-verify.js dependencies from
tools\doc where not installed. This fixes this issue by installing
those dependencies if addons are to be built.

Fixes: #25096

PR-URL: #25108
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Verified
This commit was signed with a verified signature.
BethGriggs Bethany Nicolle Griggs
GPG key ID: D7062848A1AB005C Learn about signing commits
979a397
MylesBorins added a commit that referenced this pull request May 16, 2019
@bzoz @MylesBorins
win, build: fix building addons on Windows 
Building addons would fail because addon-verify.js dependencies from
tools\doc where not installed. This fixes this issue by installing
those dependencies if addons are to be built.

Fixes: #25096

PR-URL: #25108
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Verified
This commit was signed with a verified signature.
MylesBorins Myles Borins
GPG key ID: 933B01F40B5CA946 Learn about signing commits
91c4d28
This was referenced May 29, 2019
Closed
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BridgeAR BridgeAR

Assignees
No one assigned
Labels
author ready build windows
Projects
None yet
Milestone
No milestone
4 participants
@bzoz @nodejs-github-bot @addaleax @BridgeAR
You can’t perform that action at this time.