test: increase error information in test-cli-syntax-* #25021
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If there is an error, but not the error code the test expects, display more information about the error.
richardlau
approved these changes
Dec 13, 2018
antsmartian
approved these changes
Dec 13, 2018
cjihrig
approved these changes
Dec 13, 2018
codebytere
approved these changes
Dec 13, 2018
|
Extra output can be seen in the AIX run of this PR (it's green because the tests are marked flaky). I'm not sure it helps much (but totally not blocking this from landing). |
|
Resume Build CI: https://ci.nodejs.org/job/node-test-pull-request/19494/ |
|
Resume Build CI: https://ci.nodejs.org/job/node-test-pull-request/19496/ |
watilde
approved these changes
Dec 14, 2018
|
Landed in 914c494 |
Trott
added a commit
that referenced
this issue
Dec 14, 2018
If there is an error, but not the error code the test expects, display more information about the error. PR-URL: #25021 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Shelley Vohr <codebytere@gmail.com> Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
BethGriggs
pushed a commit
that referenced
this issue
Dec 18, 2018
If there is an error, but not the error code the test expects, display more information about the error. PR-URL: #25021 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Shelley Vohr <codebytere@gmail.com> Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Merged
refack
added a commit
to refack/node
that referenced
this issue
Jan 14, 2019
If there is an error, but not the error code the test expects, display more information about the error. PR-URL: nodejs#25021 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Shelley Vohr <codebytere@gmail.com> Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
BethGriggs
pushed a commit
that referenced
this issue
Apr 8, 2019
If there is an error, but not the error code the test expects, display more information about the error. PR-URL: #25021 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Shelley Vohr <codebytere@gmail.com> Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
If there is an error, but not the error code the test expects, display
more information about the error.
Collaborators, please👍 to fast-track.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes