★ wanayoo — archive 1999 https://github.com/nodejs/node/pull/25017Nouvelle recherche | Portail wanayoo
Skip to content

/node

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

src: pass isMainThread into bootstrap/node.js directly #25017

Closed
wants to merge 1 commit into from

Conversation

@joyeecheung
Copy link
Member

commented Dec 13, 2018 •
edited

Instead of loading the worker binding for the sole purpose of
detecting whether we are inside the main thread unconditionally.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
@joyeecheung
src: pass isMainThread into bootstrap/node.js directly 
Instead of loading the working binding for the sole purpose of
detecting whether we are inside the main thread unconditionally.
Verified
This commit was signed with a verified signature.
joyeecheung Joyee Cheung
GPG key ID: 92B78A53C8303B8D Learn about signing commits
Loading status checks…
3be9c8e
@nodejs-github-bot

This comment has been minimized.

Sign in to view
Copy link

commented Dec 13, 2018

@joyeecheung build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/1929/pipeline

@nodejs-github-bot nodejs-github-bot added the C++ label Dec 13, 2018

@joyeecheung joyeecheung referenced this pull request Dec 13, 2018
Closed
@addaleax
addaleax approved these changes Dec 14, 2018
View changes
@addaleax

This comment has been minimized.

Sign in to view
Copy link
Member

commented Dec 14, 2018 •
edited by Trott

CI: https://ci.nodejs.org/job/node-test-pull-request/19527/ ✔️
@devsnek
devsnek approved these changes Dec 14, 2018
View changes

@addaleax addaleax added the author ready label Dec 14, 2018

@jasnell
jasnell approved these changes Dec 15, 2018
View changes
@addaleax

This comment has been minimized.

Sign in to view
Copy link
Member

commented Dec 15, 2018

Landed in 7a6bd9f

@addaleax addaleax closed this Dec 15, 2018

addaleax added a commit that referenced this pull request Dec 15, 2018
@joyeecheung @addaleax
src: pass isMainThread into bootstrap/node.js directly 
Instead of loading the working binding for the sole purpose of
detecting whether we are inside the main thread unconditionally.

PR-URL: #25017
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: James M Snell <jasnell@gmail.com>
Verified
This commit was signed with a verified signature.
addaleax Anna Henningsen
GPG key ID: 9C63F3A6CD2AD8F9 Learn about signing commits
Loading status checks…
7a6bd9f

@MylesBorins MylesBorins added the backport-requested-v11.x label Dec 25, 2018

@MylesBorins

This comment has been minimized.

Sign in to view
Copy link
Member

commented Dec 25, 2018

This does not land cleanly on v11.x, is someone willing to do a backport?

@targos targos added this to Backport requested in v11.x Dec 28, 2018

@addaleax addaleax removed the backport-requested-v11.x label Jan 14, 2019

@addaleax

This comment has been minimized.

Sign in to view
Copy link
Member

commented Jan 14, 2019

Also cherry-picked with a minor conflict resolution in test/parallel/test-bootstrap-modules.js.
addaleax added a commit that referenced this pull request Jan 14, 2019
@joyeecheung @addaleax
src: pass isMainThread into bootstrap/node.js directly 
Instead of loading the working binding for the sole purpose of
detecting whether we are inside the main thread unconditionally.

PR-URL: #25017
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: James M Snell <jasnell@gmail.com>
Verified
This commit was signed with a verified signature.
addaleax Anna Henningsen
GPG key ID: 9C63F3A6CD2AD8F9 Learn about signing commits
Loading status checks…
b1500d9
refack added a commit to refack/node that referenced this pull request Jan 14, 2019
@joyeecheung @refack
src: pass isMainThread into bootstrap/node.js directly 
Instead of loading the working binding for the sole purpose of
detecting whether we are inside the main thread unconditionally.

PR-URL: nodejs#25017
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: James M Snell <jasnell@gmail.com>
b81e8ba

@BridgeAR BridgeAR moved this from Backport requested to Backported in v11.x Jan 14, 2019

@BridgeAR BridgeAR referenced this pull request Jan 16, 2019
Merged
BridgeAR added a commit to BridgeAR/node that referenced this pull request Jan 16, 2019
@joyeecheung @BridgeAR
src: pass isMainThread into bootstrap/node.js directly 
Instead of loading the working binding for the sole purpose of
detecting whether we are inside the main thread unconditionally.

PR-URL: nodejs#25017
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: James M Snell <jasnell@gmail.com>
Verified
This commit was signed with a verified signature.
BridgeAR Ruben Bridgewater
GPG key ID: F07496B3EB3C1762 Learn about signing commits
e678f4e
@MylesBorins MylesBorins referenced this pull request Jan 24, 2019
Merged

@BethGriggs BethGriggs added the dont-land-on-v10.x label Jul 2, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell

@addaleax addaleax

@devsnek devsnek

Assignees
No one assigned
Labels
C++ author ready dont-land-on-v10.x
Projects
  
Backported in v11.x
Milestone
No milestone
7 participants
@joyeecheung @nodejs-github-bot @addaleax @MylesBorins @jasnell @devsnek @BethGriggs
You can’t perform that action at this time.