★ wanayoo — archive 1999 https://github.com/nodejs/node/pull/24957Nouvelle recherche | Portail wanayoo
Skip to content

/node

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: mark test-cli-syntax as flaky/unreliable #24957

Closed
wants to merge 1 commit into from

Conversation

Reviewers

@addaleax addaleax

@watilde watilde

@cclauss cclauss

@richardlau richardlau

@gireeshpunathil gireeshpunathil

Assignees
No one assigned
Labels
author ready fast-track land-on-v10.x test
Projects
None yet
Milestone
No milestone
8 participants
@Trott @nodejs-github-bot @addaleax @watilde @cclauss @richardlau @gireeshpunathil @BethGriggs
@Trott
Copy link
Member

Trott commented Dec 11, 2018 •
edited

Collaborators, 👍 here to fast-track.

I hate to do this with a bug that occurs so frequently in CI and is likely to be significant in some environments, but if a fix isn't imminent, this is the right thing to do, I suppose...

Refs: #24403

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@Trott Trott added the fast-track label Dec 11, 2018

@nodejs-github-bot

@nodejs-github-bot nodejs-github-bot added the test label Dec 11, 2018

@Trott

This comment has been minimized.

Sign in to view
Copy link
Member Author

Trott commented Dec 11, 2018 •
edited

CI: https://ci.nodejs.org/job/node-test-pull-request/19419/

CI: https://ci.nodejs.org/job/node-test-pull-request/19422/ (remembering to check CERTIFY_SAFE this time...)
@gireeshpunathil

gireeshpunathil approved these changes Dec 11, 2018
View changes

@cclauss

cclauss approved these changes Dec 11, 2018
View changes

Copy link
Contributor

cclauss left a comment

This looks 💯 correct to me!
@addaleax

addaleax approved these changes Dec 11, 2018
View changes

@watilde

watilde approved these changes Dec 11, 2018
View changes

@addaleax addaleax added the author ready label Dec 11, 2018

@richardlau

richardlau approved these changes Dec 11, 2018
View changes

@Trott

This comment has been minimized.

Sign in to view
Copy link
Member Author

Trott commented Dec 11, 2018

Resume Build CI: https://ci.nodejs.org/job/node-test-pull-request/19428/
@Trott

This comment has been minimized.

Sign in to view
Copy link
Member Author

Trott commented Dec 11, 2018

Landed in 73ebfc2

@Trott Trott closed this Dec 11, 2018

Trott added a commit to Trott/io.js that referenced this pull request Dec 11, 2018

@Trott
test: mark test-cli-syntax as flaky/unreliable 
Refs: nodejs#24403

PR-URL: nodejs#24957
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
73ebfc2

BethGriggs added a commit that referenced this pull request Dec 17, 2018

@Trott @BethGriggs
test: mark test-cli-syntax as flaky/unreliable 
Refs: #24403

PR-URL: #24957
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Verified
This commit was signed with a verified signature.
@BethGriggs BethGriggs Bethany Nicolle Griggs
GPG key ID: D7062848A1AB005C Learn about signing commits
22b6bef

@BethGriggs BethGriggs referenced this pull request Dec 18, 2018

Merged

V11.5.0 proposal #25102

@beevelop beevelop referenced this pull request Dec 18, 2018

Closed

2018-12-18 Version 11.5.0 (Current) @BethGriggs #272

refack added a commit to refack/node that referenced this pull request Jan 14, 2019

@Trott @refack
test: mark test-cli-syntax as flaky/unreliable 
Refs: nodejs#24403

PR-URL: nodejs#24957
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
c5a563f

BethGriggs added a commit that referenced this pull request Feb 12, 2019

@Trott @BethGriggs
test: mark test-cli-syntax as flaky/unreliable 
Refs: #24403

PR-URL: #24957
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Verified
This commit was signed with a verified signature.
@BethGriggs BethGriggs Bethany Nicolle Griggs
GPG key ID: D7062848A1AB005C Learn about signing commits
2869b78

@BethGriggs BethGriggs added the land-on-v10.x label Feb 12, 2019

@BethGriggs BethGriggs referenced this pull request Feb 12, 2019

Merged

v10.15.3 proposal #26063

BethGriggs added a commit that referenced this pull request Feb 20, 2019

@Trott @BethGriggs
test: mark test-cli-syntax as flaky/unreliable 
Refs: #24403

PR-URL: #24957
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Verified
This commit was signed with a verified signature.
@BethGriggs BethGriggs Bethany Nicolle Griggs
GPG key ID: D7062848A1AB005C Learn about signing commits
6c5eb1f

rvagg added a commit that referenced this pull request Feb 28, 2019

@Trott @rvagg
test: mark test-cli-syntax as flaky/unreliable 
Refs: #24403

PR-URL: #24957
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
eafe870
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.