★ wanayoo — archive 1999 https://github.com/nodejs/node/pull/24839Nouvelle recherche | Portail wanayoo
Skip to content

/node

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

minor test fixes for addons-napi / napi-api #24839

Closed
wants to merge 7 commits into from

Conversation

Reviewers

@danbev danbev

@cjihrig cjihrig

@richardlau richardlau

Assignees
No one assigned
Labels
fast-track n-api test
Projects
None yet
Milestone
No milestone
5 participants
@Trott @nodejs-github-bot @danbev @cjihrig @richardlau
@Trott
Copy link
Member

Trott commented Dec 4, 2018

Collaborators, 👍 here to fast-track.

/cc @gabrielschulhof

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@Trott Trott added the fast-track label Dec 4, 2018

@nodejs-github-bot

@nodejs-github-bot nodejs-github-bot added n-api test labels Dec 4, 2018

@Trott Trott referenced this pull request Dec 4, 2018

Closed

test: partition N-API tests #24557

4 of 4 tasks complete
@Trott

This comment has been minimized.

Sign in to view
Copy link
Member Author

Trott commented Dec 4, 2018 •
edited

CI: https://ci.nodejs.org/job/node-test-pull-request/19213/ ✔️
@cjihrig

cjihrig approved these changes Dec 4, 2018
View changes

@richardlau

richardlau reviewed Dec 5, 2018
View changes

Show resolved Hide resolved test/addons-napi/addons-napi.status Outdated
@Trott

This comment has been minimized.

Sign in to view
Copy link
Member Author

Trott commented Dec 5, 2018 •
edited

CI: https://ci.nodejs.org/job/node-test-pull-request/19214/ ✔️
@richardlau

richardlau approved these changes Dec 5, 2018
View changes

@danbev

danbev approved these changes Dec 5, 2018
View changes

@Trott

This comment has been minimized.

Sign in to view
Copy link
Member Author

Trott commented Dec 5, 2018

Landed in a845d7a...06e5afa

@Trott Trott closed this Dec 5, 2018

Trott added a commit to Trott/io.js that referenced this pull request Dec 5, 2018

@Trott
test: add .gitignore file for node-api 
Refs: nodejs#24557 (comment)

PR-URL: nodejs#24839
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
61e332b

Trott added a commit to Trott/io.js that referenced this pull request Dec 5, 2018

@Trott
test: remove unused addons-napi directory 
Refs: nodejs#24557 (comment)

PR-URL: nodejs#24839
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
06e5afa

BridgeAR added a commit that referenced this pull request Dec 5, 2018

@Trott @BridgeAR
test: add .gitignore file for node-api 
Refs: #24557 (comment)

PR-URL: #24839
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Verified
This commit was signed with a verified signature.
@BridgeAR BridgeAR Ruben Bridgewater
GPG key ID: F07496B3EB3C1762 Learn about signing commits
20e0cf5

BridgeAR added a commit that referenced this pull request Dec 5, 2018

@Trott @BridgeAR
test: remove unused addons-napi directory 
Refs: #24557 (comment)

PR-URL: #24839
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Verified
This commit was signed with a verified signature.
@BridgeAR BridgeAR Ruben Bridgewater
GPG key ID: F07496B3EB3C1762 Learn about signing commits
3f8c79c

BridgeAR added a commit that referenced this pull request Dec 5, 2018

@Trott @BridgeAR
test: add .gitignore file for node-api 
Refs: #24557 (comment)

PR-URL: #24839
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Verified
This commit was signed with a verified signature.
@BridgeAR BridgeAR Ruben Bridgewater
GPG key ID: F07496B3EB3C1762 Learn about signing commits
a240d41

BridgeAR added a commit that referenced this pull request Dec 5, 2018

@Trott @BridgeAR
test: remove unused addons-napi directory 
Refs: #24557 (comment)

PR-URL: #24839
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Verified
This commit was signed with a verified signature.
@BridgeAR BridgeAR Ruben Bridgewater
GPG key ID: F07496B3EB3C1762 Learn about signing commits
e26eb08

@BridgeAR BridgeAR referenced this pull request Dec 5, 2018

Merged

v11.4.0 proposal #24854

4 of 4 tasks complete

BridgeAR added a commit that referenced this pull request Dec 7, 2018

@Trott @BridgeAR
test: add .gitignore file for node-api 
Refs: #24557 (comment)

PR-URL: #24839
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Verified
This commit was signed with a verified signature.
@BridgeAR BridgeAR Ruben Bridgewater
GPG key ID: F07496B3EB3C1762 Learn about signing commits
7069ed7

BridgeAR added a commit that referenced this pull request Dec 7, 2018

@Trott @BridgeAR
test: remove unused addons-napi directory 
Refs: #24557 (comment)

PR-URL: #24839
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Verified
This commit was signed with a verified signature.
@BridgeAR BridgeAR Ruben Bridgewater
GPG key ID: F07496B3EB3C1762 Learn about signing commits
0ed669c

BridgeAR added a commit that referenced this pull request Dec 7, 2018

@Trott @BridgeAR
test: add .gitignore file for node-api 
Refs: #24557 (comment)

PR-URL: #24839
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Verified
This commit was signed with a verified signature.
@BridgeAR BridgeAR Ruben Bridgewater
GPG key ID: F07496B3EB3C1762 Learn about signing commits
b1b3448

BridgeAR added a commit that referenced this pull request Dec 7, 2018

@Trott @BridgeAR
test: remove unused addons-napi directory 
Refs: #24557 (comment)

PR-URL: #24839
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Verified
This commit was signed with a verified signature.
@BridgeAR BridgeAR Ruben Bridgewater
GPG key ID: F07496B3EB3C1762 Learn about signing commits
cf567f4

This was referenced Dec 7, 2018

Closed
Closed
Closed
Closed
Closed

refack added a commit to refack/node that referenced this pull request Jan 14, 2019

@Trott @refack
test: add .gitignore file for node-api 
Refs: nodejs#24557 (comment)

PR-URL: nodejs#24839
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
28de0e5

refack added a commit to refack/node that referenced this pull request Jan 14, 2019

@Trott @refack
test: remove unused addons-napi directory 
Refs: nodejs#24557 (comment)

PR-URL: nodejs#24839
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
71459d8

BethGriggs added a commit that referenced this pull request Feb 12, 2019

@Trott @BethGriggs
test: add .gitignore file for node-api 
Refs: #24557 (comment)

PR-URL: #24839
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Verified
This commit was signed with a verified signature.
@BethGriggs BethGriggs Bethany Nicolle Griggs
GPG key ID: D7062848A1AB005C Learn about signing commits
d08b5e9

BethGriggs added a commit that referenced this pull request Feb 12, 2019

@Trott @BethGriggs
test: remove unused addons-napi directory 
Refs: #24557 (comment)

PR-URL: #24839
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Verified
This commit was signed with a verified signature.
@BethGriggs BethGriggs Bethany Nicolle Griggs
GPG key ID: D7062848A1AB005C Learn about signing commits
ff90d17

@BethGriggs BethGriggs referenced this pull request Feb 12, 2019

Merged

v10.15.3 proposal #26063

BethGriggs added a commit that referenced this pull request Feb 20, 2019

@Trott @BethGriggs
test: add .gitignore file for node-api 
Refs: #24557 (comment)

PR-URL: #24839
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Verified
This commit was signed with a verified signature.
@BethGriggs BethGriggs Bethany Nicolle Griggs
GPG key ID: D7062848A1AB005C Learn about signing commits
3388922

BethGriggs added a commit that referenced this pull request Feb 20, 2019

@Trott @BethGriggs
test: remove unused addons-napi directory 
Refs: #24557 (comment)

PR-URL: #24839
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Verified
This commit was signed with a verified signature.
@BethGriggs BethGriggs Bethany Nicolle Griggs
GPG key ID: D7062848A1AB005C Learn about signing commits
9da0683

rvagg added a commit that referenced this pull request Feb 28, 2019

@Trott @rvagg
test: add .gitignore file for node-api 
Refs: #24557 (comment)

PR-URL: #24839
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
da55d16

rvagg added a commit that referenced this pull request Feb 28, 2019

@Trott @rvagg
test: remove unused addons-napi directory 
Refs: #24557 (comment)

PR-URL: #24839
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
80c9282
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.