★ wanayoo — archive 1999 https://github.com/nodejs/node/pull/24807Nouvelle recherche | Portail wanayoo
Skip to content

/node

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: streamline Accepting Modifications in Collaborator Guide #24807

Closed
wants to merge 1 commit into from

Conversation

Reviewers

@richardlau richardlau

@BridgeAR BridgeAR

@vsemozhetbyt vsemozhetbyt

Assignees
No one assigned
Labels
author ready doc fast-track meta
Projects
None yet
Milestone
No milestone
5 participants
@Trott @nodejs-github-bot @richardlau @BridgeAR @vsemozhetbyt
@Trott
Copy link
Member

Trott commented Dec 3, 2018

Editing a sentence I missed simplifying in the last pass on that
section.

Collaborators, 👍 here to fast-track.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines
@Trott
doc: streamline Accepting Modifications in Collaborator Guide 
Editing a sentence I missed simplifying in the last pass on that
section.
Loading status checks…
2fb1a05

@Trott Trott added the fast-track label Dec 3, 2018

@nodejs-github-bot

@nodejs-github-bot nodejs-github-bot added the doc label Dec 3, 2018

@richardlau

richardlau approved these changes Dec 3, 2018
View changes

@BridgeAR

BridgeAR approved these changes Dec 3, 2018
View changes

@vsemozhetbyt

vsemozhetbyt approved these changes Dec 3, 2018
View changes

@vsemozhetbyt vsemozhetbyt added author ready meta labels Dec 3, 2018

@Trott

This comment has been minimized.

Sign in to view
Copy link
Member Author

Trott commented Dec 3, 2018

Landed in 2e03b76

@Trott Trott closed this Dec 3, 2018

Trott added a commit to Trott/io.js that referenced this pull request Dec 3, 2018

@Trott
doc: streamline Accepting Modifications in Collaborator Guide 
Editing a sentence I missed simplifying in the last pass on that
section.

PR-URL: nodejs#24807
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
2e03b76

BridgeAR added a commit that referenced this pull request Dec 5, 2018

@Trott @BridgeAR
doc: streamline Accepting Modifications in Collaborator Guide 
Editing a sentence I missed simplifying in the last pass on that
section.

PR-URL: #24807
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Verified
This commit was signed with a verified signature.
@BridgeAR BridgeAR Ruben Bridgewater
GPG key ID: F07496B3EB3C1762 Learn about signing commits
8b22bf4

BridgeAR added a commit that referenced this pull request Dec 5, 2018

@Trott @BridgeAR
doc: streamline Accepting Modifications in Collaborator Guide 
Editing a sentence I missed simplifying in the last pass on that
section.

PR-URL: #24807
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Verified
This commit was signed with a verified signature.
@BridgeAR BridgeAR Ruben Bridgewater
GPG key ID: F07496B3EB3C1762 Learn about signing commits
751d961

@BridgeAR BridgeAR referenced this pull request Dec 5, 2018

Merged

v11.4.0 proposal #24854

4 of 4 tasks complete

This was referenced Dec 7, 2018

Closed
Closed
Closed
Closed
Closed

refack added a commit to refack/node that referenced this pull request Jan 14, 2019

@Trott @refack
doc: streamline Accepting Modifications in Collaborator Guide 
Editing a sentence I missed simplifying in the last pass on that
section.

PR-URL: nodejs#24807
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
4a8d6d4

BethGriggs added a commit that referenced this pull request Feb 12, 2019

@Trott @BethGriggs
doc: streamline Accepting Modifications in Collaborator Guide 
Editing a sentence I missed simplifying in the last pass on that
section.

PR-URL: #24807
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Verified
This commit was signed with a verified signature.
@BethGriggs BethGriggs Bethany Nicolle Griggs
GPG key ID: D7062848A1AB005C Learn about signing commits
56916c8

@BethGriggs BethGriggs referenced this pull request Feb 12, 2019

Merged

v10.15.3 proposal #26063

BethGriggs added a commit that referenced this pull request Feb 20, 2019

@Trott @BethGriggs
doc: streamline Accepting Modifications in Collaborator Guide 
Editing a sentence I missed simplifying in the last pass on that
section.

PR-URL: #24807
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Verified
This commit was signed with a verified signature.
@BethGriggs BethGriggs Bethany Nicolle Griggs
GPG key ID: D7062848A1AB005C Learn about signing commits
4dc6e96

rvagg added a commit that referenced this pull request Feb 28, 2019

@Trott @rvagg
doc: streamline Accepting Modifications in Collaborator Guide 
Editing a sentence I missed simplifying in the last pass on that
section.

PR-URL: #24807
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
e7c29e0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.