★ wanayoo — archive 1999 https://github.com/nodejs/node/pull/24719Nouvelle recherche | Portail wanayoo
Skip to content

/node

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

crypto: harden bignum-to-binary conversions #24719

Closed
wants to merge 1 commit into from

Conversation

Reviewers

@jasnell jasnell

@cjihrig cjihrig

Assignees
No one assigned
Labels
C++ author ready crypto land-on-v10.x
Projects
None yet
Milestone
No milestone
8 participants
@bnoordhuis @nodejs-github-bot @addaleax @danbev @jasnell @cjihrig @Trott @BethGriggs
@bnoordhuis
Copy link
Member

bnoordhuis commented Nov 29, 2018

Refs: #24645
@bnoordhuis
crypto: harden bignum-to-binary conversions 
Refs: #24645
Loading status checks…
672ce0c
@nodejs-github-bot

@nodejs-github-bot nodejs-github-bot added C++ crypto labels Nov 29, 2018

@bnoordhuis bnoordhuis referenced this pull request Nov 29, 2018

Closed

diffieHellman.computeSecret Seemingly Produces An Incorrect Secret #24645

@cjihrig

cjihrig approved these changes Nov 29, 2018
View changes

@addaleax

This comment has been minimized.

Sign in to view
Copy link
Member

addaleax commented Nov 29, 2018 •
edited by Trott

CI: https://ci.nodejs.org/job/node-test-pull-request/19056/ ✔️
@jasnell

jasnell approved these changes Nov 30, 2018
View changes

@Trott Trott added the author ready label Dec 2, 2018

@danbev

This comment has been minimized.

Sign in to view
Copy link
Member

danbev commented Dec 3, 2018

Landed in 3513b0c.

@danbev danbev closed this Dec 3, 2018

danbev added a commit that referenced this pull request Dec 3, 2018

@bnoordhuis @danbev
crypto: harden bignum-to-binary conversions 
PR-URL: #24719
Refs: #24645
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Loading status checks…
3513b0c

BridgeAR added a commit that referenced this pull request Dec 5, 2018

@bnoordhuis @BridgeAR
crypto: harden bignum-to-binary conversions 
PR-URL: #24719
Refs: #24645
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Verified
This commit was signed with a verified signature.
@BridgeAR BridgeAR Ruben Bridgewater
GPG key ID: F07496B3EB3C1762 Learn about signing commits
12feb9e

@BridgeAR BridgeAR referenced this pull request Dec 5, 2018

Merged

v11.4.0 proposal #24854

4 of 4 tasks complete

This was referenced Dec 7, 2018

Closed
Closed
Closed
Closed
Closed

refack added a commit to refack/node that referenced this pull request Jan 14, 2019

@bnoordhuis @refack
crypto: harden bignum-to-binary conversions 
PR-URL: nodejs#24719
Refs: nodejs#24645
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
501bc12

BethGriggs added a commit that referenced this pull request Feb 12, 2019

@bnoordhuis @BethGriggs
crypto: harden bignum-to-binary conversions 
PR-URL: #24719
Refs: #24645
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Verified
This commit was signed with a verified signature.
@BethGriggs BethGriggs Bethany Nicolle Griggs
GPG key ID: D7062848A1AB005C Learn about signing commits
Loading status checks…
a2155e1

@BethGriggs BethGriggs added the land-on-v10.x label Feb 12, 2019

@BethGriggs BethGriggs referenced this pull request Feb 12, 2019

Merged

v10.15.3 proposal #26063

rvagg added a commit that referenced this pull request Feb 28, 2019

@bnoordhuis @rvagg
crypto: harden bignum-to-binary conversions 
PR-URL: #24719
Refs: #24645
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
3acf761
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.