★ wanayoo — archive 1999 https://github.com/nodejs/node/pull/24700Nouvelle recherche | Portail wanayoo
Skip to content

/node

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: describe current HTTP header size limit #24700

Closed
wants to merge 2 commits into from

Conversation

Reviewers

@mcollina mcollina

@vsemozhetbyt vsemozhetbyt

Assignees
No one assigned
Labels
author ready doc dont-land-on-v8.x errors fast-track http http_parser land-on-v10.x
Projects
None yet
Milestone
No milestone
6 participants
@sam-github @nodejs-github-bot @vsemozhetbyt @Trott @mcollina @MylesBorins
@sam-github
Copy link
Member

sam-github commented Nov 28, 2018

Document that the limit was changed from 80KB to 8KB in 1860352.

Fixes: #24693

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
@nodejs-github-bot

@nodejs-github-bot nodejs-github-bot added doc errors labels Nov 28, 2018

@sam-github

This comment has been minimized.

Sign in to view
Copy link
Member Author

sam-github commented Nov 28, 2018

This does not replace #24693, it fixes the existing reference to 80KB in errors.md, but doesn't touch the HTTP docs themselves. It was intended that this be part of 1860352 but it got missed, sorry.
@mcollina

mcollina approved these changes Nov 28, 2018
View changes

Copy link
Member

mcollina left a comment

LGTM
@sam-github
doc: describe current HTTP header size limit 
Document that the limit was changed from 80KB to 8KB in 1860352.

Fixes: #24693
Loading status checks…
19cdee8

@sam-github sam-github force-pushed the sam-github:doc-8kb-http-header-limit branch from bfb4d4a to 19cdee8 Nov 28, 2018

@vsemozhetbyt

vsemozhetbyt reviewed Nov 28, 2018
View changes

Show resolved Hide resolved doc/api/errors.md Outdated
@vsemozhetbyt

vsemozhetbyt approved these changes Nov 28, 2018
View changes

@vsemozhetbyt vsemozhetbyt added http http_parser labels Nov 28, 2018

@vsemozhetbyt @sam-github
fixup 
Co-Authored-By: sam-github <vieuxtech@gmail.com>
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
bb3d672
@sam-github

This comment has been minimized.

Sign in to view
Copy link
Member Author

sam-github commented Nov 28, 2018

sorry, misunderstood format of description field
@vsemozhetbyt

This comment has been minimized.

Sign in to view
Copy link
Member

vsemozhetbyt commented Nov 28, 2018

Node.js Collaborators, please, add 👍 here if you approve fast-tracking.
@vsemozhetbyt

This comment has been minimized.

Sign in to view
Copy link
Member

vsemozhetbyt commented Nov 28, 2018

CI-lite: https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/1711/

@vsemozhetbyt vsemozhetbyt added the author ready label Nov 28, 2018

@Trott Trott added the fast-track label Nov 28, 2018

@Trott

This comment has been minimized.

Sign in to view
Copy link
Member

Trott commented Nov 28, 2018

Landed in 063e8fb

@Trott Trott closed this Nov 28, 2018

Trott added a commit to Trott/io.js that referenced this pull request Nov 28, 2018

@sam-github @Trott
doc: describe current HTTP header size limit 
Document that the limit was changed from 80KB to 8KB in 1860352.

Fixes: nodejs#24693

PR-URL: nodejs#24700
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
063e8fb

@sam-github sam-github deleted the sam-github:doc-8kb-http-header-limit branch Nov 28, 2018

targos added a commit that referenced this pull request Nov 29, 2018

@sam-github @targos
doc: describe current HTTP header size limit 
Document that the limit was changed from 80KB to 8KB in 1860352.

Fixes: #24693

PR-URL: #24700
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Verified
This commit was signed with a verified signature.
@targos targos Michaël Zasso
GPG key ID: 770F7A9A5AE15600 Learn about signing commits
68dc100

@BridgeAR BridgeAR referenced this pull request Dec 5, 2018

Merged

v11.4.0 proposal #24854

4 of 4 tasks complete

This was referenced Dec 7, 2018

Closed
Closed
Closed
Closed
Closed

MylesBorins added a commit that referenced this pull request Dec 25, 2018

@sam-github @MylesBorins
doc: describe current HTTP header size limit 
Document that the limit was changed from 80KB to 8KB in 1860352.

Fixes: #24693

PR-URL: #24700
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Verified
This commit was signed with a verified signature.
@MylesBorins MylesBorins Myles Borins
GPG key ID: 933B01F40B5CA946 Learn about signing commits
Loading status checks…
f30d169

@MylesBorins MylesBorins added the dont-land-on-v8.x label Dec 25, 2018

@MylesBorins MylesBorins added the land-on-v10.x label Dec 25, 2018

MylesBorins added a commit that referenced this pull request Dec 25, 2018

@sam-github @MylesBorins
doc: describe current HTTP header size limit 
Document that the limit was changed from 80KB to 8KB in 1860352.

Fixes: #24693

PR-URL: #24700
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Verified
This commit was signed with a verified signature.
@MylesBorins MylesBorins Myles Borins
GPG key ID: 933B01F40B5CA946 Learn about signing commits
e669733

@MylesBorins MylesBorins referenced this pull request Dec 25, 2018

Merged

v10.15.0 proposal #25176

This was referenced Dec 26, 2018

Closed
Closed

refack added a commit to refack/node that referenced this pull request Jan 14, 2019

@sam-github @refack
doc: describe current HTTP header size limit 
Document that the limit was changed from 80KB to 8KB in 1860352.

Fixes: nodejs#24693

PR-URL: nodejs#24700
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
f045f1b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.