★ wanayoo — archive 1999 https://github.com/nodejs/node/pull/24669Nouvelle recherche | Portail wanayoo
Skip to content

/node

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tools: only sign release if promotion successful #24669

Closed
wants to merge 1 commit into from

Conversation

Reviewers

@jasnell jasnell

@Trott Trott

Assignees
No one assigned
Labels
author ready build land-on-v10.x tools
Projects
None yet
Milestone
No milestone
5 participants
@rvagg @nodejs-github-bot @Trott @jasnell @BethGriggs
@rvagg
Copy link
Member

rvagg commented Nov 27, 2018

To support nodejs/build#1596, but good practice regardless

@nodejs/releasers @nodejs/build

@rvagg rvagg added build tools labels Nov 27, 2018

@nodejs-github-bot

This comment has been minimized.

Sign in to view
Copy link

nodejs-github-bot commented Nov 27, 2018

@rvagg sadly an error occured when I tried to trigger a build :(

This was referenced Nov 27, 2018

Closed
Closed
@rvagg

This comment has been minimized.

Sign in to view
Copy link
Member Author

rvagg commented Nov 28, 2018

Used along with #24670 and the new asset checker with all 4 releases today, a sweet combination and worked well.
@jasnell

jasnell approved these changes Nov 30, 2018
View changes

@Trott

Trott approved these changes Dec 1, 2018
View changes

@Trott

This comment has been minimized.

Sign in to view
Copy link
Member

Trott commented Dec 1, 2018

Lite CI: https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/1761/

@Trott Trott added the author ready label Dec 1, 2018

@Trott

This comment has been minimized.

Sign in to view
Copy link
Member

Trott commented Dec 1, 2018 •
edited

Landed in f34ca9f

@Trott Trott closed this Dec 1, 2018

Trott added a commit to Trott/io.js that referenced this pull request Dec 1, 2018

@rvagg @Trott
tools: only sign release if promotion successful 
Ref: nodejs/build#1596

PR-URL: nodejs#24669
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
f34ca9f

@rvagg rvagg deleted the rvagg:rvagg/release_script_sign_if_exit_0 branch Dec 1, 2018

BridgeAR added a commit that referenced this pull request Dec 5, 2018

@rvagg @BridgeAR
tools: only sign release if promotion successful 
Ref: nodejs/build#1596

PR-URL: #24669
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Verified
This commit was signed with a verified signature.
@BridgeAR BridgeAR Ruben Bridgewater
GPG key ID: F07496B3EB3C1762 Learn about signing commits
e3649c8

@BridgeAR BridgeAR referenced this pull request Dec 5, 2018

Merged

v11.4.0 proposal #24854

4 of 4 tasks complete

This was referenced Dec 7, 2018

Closed
Closed
Closed
Closed
Closed

refack added a commit to refack/node that referenced this pull request Jan 14, 2019

@rvagg @refack
tools: only sign release if promotion successful 
Ref: nodejs/build#1596

PR-URL: nodejs#24669
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
17c0c10

BethGriggs added a commit that referenced this pull request Feb 12, 2019

@rvagg @BethGriggs
tools: only sign release if promotion successful 
Ref: nodejs/build#1596

PR-URL: #24669
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Verified
This commit was signed with a verified signature.
@BethGriggs BethGriggs Bethany Nicolle Griggs
GPG key ID: D7062848A1AB005C Learn about signing commits
f5f1266

@BethGriggs BethGriggs added the land-on-v10.x label Feb 12, 2019

@BethGriggs BethGriggs referenced this pull request Feb 12, 2019

Merged

v10.15.3 proposal #26063

rvagg added a commit that referenced this pull request Feb 28, 2019

@rvagg
tools: only sign release if promotion successful 
Ref: nodejs/build#1596

PR-URL: #24669
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
7ef612b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.