Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upstream: make async iterator .next() always resolve #24668
Conversation
mcollina
requested review from
fhinkel,
addaleax,
joyeecheung and
devsnek
Nov 27, 2018
This comment has been minimized.
This comment has been minimized.
nodejs-github-bot
commented
Nov 27, 2018
|
@mcollina sadly an error occured when I tried to trigger a build :( |
mcollina
referenced this pull request
Nov 27, 2018
Closed
Async iterator promises are not resolved after stream end #387
reconbot
approved these changes
Nov 27, 2018
|
Fixes nodejs/readable-stream#387 |
devsnek
approved these changes
Nov 27, 2018
fhinkel
approved these changes
Nov 27, 2018
joyeecheung
approved these changes
Nov 28, 2018
mcollina
force-pushed the
mcollina:stream-iterator-fix
branch
from
be46937
to
4fea207
Nov 29, 2018
This comment has been minimized.
This comment has been minimized.
BridgeAR
approved these changes
Nov 29, 2018
| } | ||
| assert.strictEqual(e, err); | ||
| })()]); | ||
| })(); |
This comment has been minimized.
This comment has been minimized.
|
|
||
| const b = r[Symbol.asyncIterator](); | ||
| const c = b.next(); | ||
| const d = b.next(); |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
Landed in fa1535a |
mcollina
closed this
Nov 29, 2018
mcollina
deleted the
mcollina:stream-iterator-fix
branch
Nov 29, 2018
pull bot
pushed a commit
to SimenB/node
that referenced
this pull request
Nov 29, 2018
targos
added a commit
that referenced
this pull request
Nov 29, 2018
This was referenced Dec 7, 2018
refack
added a commit
to refack/node
that referenced
this pull request
Jan 14, 2019
BethGriggs
added a commit
that referenced
this pull request
Feb 12, 2019
rvagg
added a commit
that referenced
this pull request
Feb 28, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
mcollina commentedNov 27, 2018
See: nodejs/readable-stream#387
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes