★ wanayoo — archive 1999 https://github.com/nodejs/node/pull/24654Nouvelle recherche | Portail wanayoo
Skip to content

/node

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cli: fix omitting `--` from `process.execArgv` #24654

Closed
wants to merge 1 commit into from

Conversation

Reviewers

@fhinkel fhinkel

@lpinca lpinca

@cjihrig cjihrig

@richardlau richardlau

@devsnek devsnek

Assignees
No one assigned
Labels
C++ author ready cli lts-watch-v10.x
Projects
None yet
Milestone
No milestone
9 participants
@addaleax @nodejs-github-bot @danbev @Trott @fhinkel @lpinca @cjihrig @richardlau @devsnek
@addaleax
Copy link
Member

addaleax commented Nov 26, 2018

This was essentially a typo that went unnoticed because we
didn’t have tests for this particular situation.

Fixes: #24647

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
@addaleax
cli: fix omitting `--` from `process.execArgv` 
This was essentially a typo that went unnoticed because we
didn’t have tests for this particular situation.

Fixes: #24647
Verified
This commit was signed with a verified signature.
@addaleax addaleax Anna Henningsen
GPG key ID: 9C63F3A6CD2AD8F9 Learn about signing commits
Loading status checks…
c503e18

@addaleax addaleax added the lts-watch-v10.x label Nov 26, 2018

@nodejs-github-bot

This comment has been minimized.

Sign in to view
Copy link

nodejs-github-bot commented Nov 26, 2018

@addaleax sadly an error occured when I tried to trigger a build :(

@nodejs-github-bot nodejs-github-bot added the C++ label Nov 26, 2018

@addaleax addaleax added the cli label Nov 26, 2018

@richardlau

richardlau approved these changes Nov 26, 2018
View changes

@cjihrig

cjihrig approved these changes Nov 26, 2018
View changes

@lpinca

lpinca approved these changes Nov 26, 2018
View changes

@devsnek

devsnek approved these changes Nov 26, 2018
View changes

@fhinkel

fhinkel approved these changes Nov 27, 2018
View changes

@danbev

This comment has been minimized.

Sign in to view
Copy link
Member

danbev commented Nov 29, 2018

CI: https://ci.nodejs.org/job/node-test-pull-request/19020/
@Trott

This comment has been minimized.

Sign in to view
Copy link
Member

Trott commented Nov 29, 2018

Resume Build CI: https://ci.nodejs.org/job/node-test-pull-request/19036/

@Trott Trott added the author ready label Nov 29, 2018

@Trott

This comment has been minimized.

Sign in to view
Copy link
Member

Trott commented Nov 29, 2018

CI: https://ci.nodejs.org/job/node-test-pull-request/19049/
@Trott

This comment has been minimized.

Sign in to view
Copy link
Member

Trott commented Nov 29, 2018

Landed in 83d6cb9

@Trott Trott closed this Nov 29, 2018

Trott added a commit to Trott/io.js that referenced this pull request Nov 29, 2018

@addaleax @Trott
process: fix omitting `--` from `process.execArgv` 
This was essentially a typo that went unnoticed because we
didn’t have tests for this particular situation.

Fixes: nodejs#24647

PR-URL: nodejs#24654
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
83d6cb9

targos added a commit that referenced this pull request Nov 29, 2018

@addaleax @targos
process: fix omitting `--` from `process.execArgv` 
This was essentially a typo that went unnoticed because we
didn’t have tests for this particular situation.

Fixes: #24647

PR-URL: #24654
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Verified
This commit was signed with a verified signature.
@targos targos Michaël Zasso
GPG key ID: 770F7A9A5AE15600 Learn about signing commits
effe307

@BridgeAR BridgeAR referenced this pull request Dec 5, 2018

Merged

v11.4.0 proposal #24854

4 of 4 tasks complete

This was referenced Dec 7, 2018

Closed
Closed
Closed
Closed
Closed

refack added a commit to refack/node that referenced this pull request Jan 14, 2019

Anna Henningsen @refack
process: fix omitting `--` from `process.execArgv` 
This was essentially a typo that went unnoticed because we
didn’t have tests for this particular situation.

Fixes: nodejs#24647

PR-URL: nodejs#24654
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
5f23d51

BethGriggs added a commit that referenced this pull request Feb 12, 2019

@addaleax @BethGriggs
process: fix omitting `--` from `process.execArgv` 
This was essentially a typo that went unnoticed because we
didn’t have tests for this particular situation.

Fixes: #24647

PR-URL: #24654
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Verified
This commit was signed with a verified signature.
@BethGriggs BethGriggs Bethany Nicolle Griggs
GPG key ID: D7062848A1AB005C Learn about signing commits
931a04e

@BethGriggs BethGriggs referenced this pull request Feb 12, 2019

Merged

v10.15.3 proposal #26063

BethGriggs added a commit that referenced this pull request Feb 20, 2019

@addaleax @BethGriggs
process: fix omitting `--` from `process.execArgv` 
This was essentially a typo that went unnoticed because we
didn’t have tests for this particular situation.

Fixes: #24647

PR-URL: #24654
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Verified
This commit was signed with a verified signature.
@BethGriggs BethGriggs Bethany Nicolle Griggs
GPG key ID: D7062848A1AB005C Learn about signing commits
38b0e5d

rvagg added a commit that referenced this pull request Feb 28, 2019

@addaleax @rvagg
process: fix omitting `--` from `process.execArgv` 
This was essentially a typo that went unnoticed because we
didn’t have tests for this particular situation.

Fixes: #24647

PR-URL: #24654
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
3d6266a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.