★ wanayoo — archive 1999 https://github.com/nodejs/node/pull/24642Nouvelle recherche | Portail wanayoo
Skip to content

/node

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tools: update remark-preset-lint-node to v1.3.1 #24642

Closed
wants to merge 2 commits into from

Conversation

Reviewers

@refack refack

@fhinkel fhinkel

@Trott Trott

Assignees
No one assigned
Labels
backport-requested-v10.x backported-to-v11.x build doc tools
Projects
  
Backported in v11.x
Milestone
No milestone
7 participants
@watilde @nodejs-github-bot @Trott @refack @fhinkel @targos @BethGriggs
@watilde
Copy link
Member

commented Nov 25, 2018

Summary
Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
@nodejs-github-bot

@nodejs-github-bot nodejs-github-bot added the tools label Nov 25, 2018

@Trott

This comment has been minimized.

Sign in to view
Copy link
Member

commented Nov 25, 2018

There are two .md files with trailing spaces that will need to be fixed before this lands. One is the README and the other is a CHANGELOG file if I recall correctly.
@Trott

This comment has been minimized.

Sign in to view
Copy link
Member

commented Nov 25, 2018

(The fix for the trailing spaces can happen in this PR itself. Probably best as a first commit and then the update of the presets as a second commit.)
@watilde

This comment has been minimized.

Sign in to view
Copy link
Member Author

commented Nov 25, 2018

I agree. Will arrange the commits and let me ping you when it's done.
@refack

refack approved these changes Nov 25, 2018
View changes

Copy link
Member

left a comment

Code changes LGTM
@refack

This comment has been minimized.

Sign in to view
Copy link
Member

commented Nov 25, 2018

ATM the linter complains only about

README.md
  65:18  warning  Remove trailing whitespace  no-trailing-spaces  remark-lint
⚠ 1 warning

@refack refack added doc build labels Nov 25, 2018

@watilde watilde force-pushed the watilde:feature/update-remark-preset branch from 892664d to 6b19147 Nov 26, 2018

@watilde

This comment has been minimized.

Sign in to view
Copy link
Member Author

commented Nov 26, 2018

I removed trailing whitespace in readme and ci gets green🥗 @Trott
@Trott

This comment has been minimized.

Sign in to view
Copy link
Member

commented Nov 26, 2018

Can you re-arrange the commits so that the doc change is first and the update to the plugin is second? (Or squash them into a single commit, although I prefer them separate for ease of backporting.) The way it is now, make lint fails on the first commit. That could be irksome while bisecting, for example.
@watilde

This comment has been minimized.

Sign in to view
Copy link
Member Author

commented Nov 26, 2018

This is what I did already :)

Can you re-arrange the commits so that the doc change is first and the update to the plugin is second?
@fhinkel

fhinkel approved these changes Nov 27, 2018
View changes

@Trott

This comment has been minimized.

Sign in to view
Copy link
Member

commented Nov 28, 2018

This is what I did already :)

I am easily confused, apparently. :-D
@Trott

Trott approved these changes Nov 28, 2018
View changes

@Trott

This comment has been minimized.

Sign in to view
Copy link
Member

commented Nov 28, 2018

Lite CI: https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/1705/
@Trott

This comment has been minimized.

Sign in to view
Copy link
Member

commented Nov 28, 2018

Landed in f351c5d...8ce0d4f

@Trott Trott closed this Nov 28, 2018

Trott added a commit to Trott/io.js that referenced this pull request Nov 28, 2018

@watilde @Trott
doc: remove trailing whitespace 
PR-URL: nodejs#24642
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
d0bf5ca

Trott added a commit to Trott/io.js that referenced this pull request Nov 28, 2018

@watilde @Trott
tools: update remark-preset-lint-node to v1.3.1 
PR-URL: nodejs#24642
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
8ce0d4f

@targos targos added the backport-requested-v11.x label Nov 28, 2018

targos added a commit to targos/node that referenced this pull request Nov 28, 2018

@watilde @targos
doc: remove trailing whitespace 
PR-URL: nodejs#24642
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Verified
This commit was signed with a verified signature.
@targos targos Michaël Zasso
GPG key ID: 770F7A9A5AE15600 Learn about signing commits
d011fc9

targos added a commit to targos/node that referenced this pull request Nov 28, 2018

@watilde @targos
tools: update remark-preset-lint-node to v1.3.1 
PR-URL: nodejs#24642
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Verified
This commit was signed with a verified signature.
@targos targos Michaël Zasso
GPG key ID: 770F7A9A5AE15600 Learn about signing commits
edea0fa

targos added a commit to targos/node that referenced this pull request Nov 28, 2018

@watilde @targos
doc: remove trailing whitespace 
PR-URL: nodejs#24642
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Verified
This commit was signed with a verified signature.
@targos targos Michaël Zasso
GPG key ID: 770F7A9A5AE15600 Learn about signing commits
8e37905

targos added a commit to targos/node that referenced this pull request Nov 28, 2018

@watilde @targos
tools: update remark-preset-lint-node to v1.3.1 
PR-URL: nodejs#24642
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Verified
This commit was signed with a verified signature.
@targos targos Michaël Zasso
GPG key ID: 770F7A9A5AE15600 Learn about signing commits
e217d81

@targos targos referenced this pull request Nov 28, 2018

Closed

[v11.x] backport "tools: update remark-preset-lint-node to v1.3.1" #24699

@watilde watilde deleted the watilde:feature/update-remark-preset branch Nov 29, 2018

@targos targos added backported-to-v11.x and removed backport-requested-v11.x labels Nov 30, 2018

targos added a commit that referenced this pull request Nov 30, 2018

@watilde @targos
doc: remove trailing whitespace 
Backport-PR-URL: #24699
PR-URL: #24642
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Verified
This commit was signed with a verified signature.
@targos targos Michaël Zasso
GPG key ID: 770F7A9A5AE15600 Learn about signing commits
654bd65

targos added a commit that referenced this pull request Nov 30, 2018

@watilde @targos
tools: update remark-preset-lint-node to v1.3.1 
Backport-PR-URL: #24699
PR-URL: #24642
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Verified
This commit was signed with a verified signature.
@targos targos Michaël Zasso
GPG key ID: 770F7A9A5AE15600 Learn about signing commits
Loading status checks…
e7fbdf5

@targos targos added this to Backported in v11.x Nov 30, 2018

@BridgeAR BridgeAR referenced this pull request Dec 5, 2018

Merged

v11.4.0 proposal #24854

4 of 4 tasks complete

This was referenced Dec 7, 2018

Closed
Closed
Closed
Closed
Closed

refack added a commit to refack/node that referenced this pull request Jan 14, 2019

@watilde @refack
doc: remove trailing whitespace 
PR-URL: nodejs#24642
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
61fed75

refack added a commit to refack/node that referenced this pull request Jan 14, 2019

@watilde @refack
tools: update remark-preset-lint-node to v1.3.1 
PR-URL: nodejs#24642
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
691c9cb

@BethGriggs BethGriggs added the backport-requested-v10.x label Mar 14, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.